From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Tantilov, Emil S" <emil.s.tantilov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, clrkwllms@kernel.org, rostedt@goodmis.org,
linux-rt-devel@lists.linux.dev, sgzhang@google.com,
boolli@google.com
Subject: Re: [PATCH iwl-net 0/3] idpf: virtchnl locking and async fixes
Date: Tue, 17 Mar 2026 15:38:50 +0100 [thread overview]
Message-ID: <20260317143850.BLrnAox8@linutronix.de> (raw)
In-Reply-To: <7247024b-fc8d-4a75-ba15-a10399db03bc@intel.com>
On 2026-03-17 07:20:18 [-0700], Tantilov, Emil S wrote:
> > Why is there a raw_spinlock_t? From a quick look a spinlock_t would do
> > just fine with not runtime change for !PREEMPT_RT.
>
> The handling of the virtchannel messages is done via the completion API
> and the transactions are using the raw spinlock from struct
> swait_queue_head:
>
> https://elixir.bootlin.com/linux/v6.19.8/source/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c#L298
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git/tree/include/linux/swait.h?h=dev-queue#n44
I am aware that completions use a raw_spinlock_t. I don't see the link.
What would break if you make that lock a spinlock_t?
> Thanks,
> Emil
Sebastian
next prev parent reply other threads:[~2026-03-17 14:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 23:28 [PATCH iwl-net 0/3] idpf: virtchnl locking and async fixes Emil Tantilov
2026-03-16 23:28 ` [PATCH iwl-net 1/3] idpf: improve locking around idpf_vc_xn_push_free() Emil Tantilov
2026-03-17 23:46 ` Li Li
2026-03-16 23:28 ` [PATCH iwl-net 2/3] idpf: set the payload size before calling the async handler Emil Tantilov
2026-03-18 0:11 ` Li Li
2026-03-19 16:21 ` Tantilov, Emil S
2026-03-16 23:28 ` [PATCH iwl-net 3/3] idpf: fix PREEMPT_RT raw/bh spinlock nesting for async VC handling Emil Tantilov
2026-03-18 0:13 ` Li Li
2026-03-17 9:00 ` [PATCH iwl-net 0/3] idpf: virtchnl locking and async fixes Sebastian Andrzej Siewior
2026-03-17 14:20 ` Tantilov, Emil S
2026-03-17 14:38 ` Sebastian Andrzej Siewior [this message]
2026-03-17 19:30 ` Tantilov, Emil S
2026-03-18 7:24 ` Sebastian Andrzej Siewior
2026-03-18 13:06 ` Tantilov, Emil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317143850.BLrnAox8@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=boolli@google.com \
--cc=clrkwllms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rostedt@goodmis.org \
--cc=sgzhang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox