From: Jakub Kicinski <kuba@kernel.org>
To: Andrea Mayer <andrea.mayer@uniroma2.it>
Cc: Justin Iurman <justin.iurman@6wind.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, justin.iurman@gmail.com,
nicolas.dichtel@6wind.com, stefano.salsano@uniroma2.it,
paolo.lungaroni@uniroma2.it, ahabdels@cisco.com,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] selftests: add check for seg6 tunsrc
Date: Tue, 17 Mar 2026 15:07:57 -0700 [thread overview]
Message-ID: <20260317150757.3419e6b9@kernel.org> (raw)
In-Reply-To: <20260317115430.cfd3846b20c1e2314d468b5d@uniroma2.it>
On Tue, 17 Mar 2026 11:54:30 +0100 Andrea Mayer wrote:
> > @@ -819,6 +853,7 @@ test_command_or_ksft_skip ip
> > test_command_or_ksft_skip ping
> > test_command_or_ksft_skip sysctl
> > test_command_or_ksft_skip grep
> > +test_command_or_ksft_skip ip6tables
>
> This will skip the entire script if ip6tables is not present, which
> takes down the baseline tests too.
> I think a probe at startup that checks for both tunsrc support and
> ip6tables would work well here. If either is missing, we can
> just gracefully skip the new tunsrc tests and let the rest of the script
> run as usual.
>
> The bottom line is that the script needs to keep working exactly as
> before when tunsrc is not supported or its dependencies are missing.
FWIW that's not the general guidance for networking tests.
If it's easy to handle cleanly then sure, but we should try to avoid
complicating tests with workarounds for degraded environments.
next prev parent reply other threads:[~2026-03-17 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 16:29 [PATCH net-next v3 0/2] Add support for seg6 tunsrc Justin Iurman
2026-03-16 16:29 ` [PATCH net-next v3 1/2] seg6: add per-route tunnel source address Justin Iurman
2026-03-16 16:29 ` [PATCH net-next v3 2/2] selftests: add check for seg6 tunsrc Justin Iurman
2026-03-17 10:54 ` Andrea Mayer
2026-03-17 22:07 ` Jakub Kicinski [this message]
2026-03-18 12:29 ` Justin Iurman
2026-03-19 3:50 ` Andrea Mayer
2026-03-16 20:01 ` [PATCH net-next v3 0/2] Add support " Justin Iurman
2026-03-17 0:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317150757.3419e6b9@kernel.org \
--to=kuba@kernel.org \
--cc=ahabdels@cisco.com \
--cc=andrea.mayer@uniroma2.it \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justin.iurman@6wind.com \
--cc=justin.iurman@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=paolo.lungaroni@uniroma2.it \
--cc=shuah@kernel.org \
--cc=stefano.salsano@uniroma2.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox