From: Jakub Kicinski <kuba@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>,
Shuah Khan <shuah@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v5 2/3] bnxt_en: Resize RSS contexts on channel count change
Date: Tue, 17 Mar 2026 15:53:59 -0700 [thread overview]
Message-ID: <20260317155359.33b855b1@kernel.org> (raw)
In-Reply-To: <20260317083339.2811865-3-bjorn@kernel.org>
On Tue, 17 Mar 2026 09:33:35 +0100 Björn Töpel wrote:
> + if (netif_is_rxfh_configured(dev) &&
> + !ethtool_rxfh_can_resize(bp->rss_indir_tbl,
> + old_tbl_size, new_tbl_size,
> + dev->ethtool->rss_indir_user_size)) {
> + netdev_warn(dev, "RSS table resize not possible\n");
> + return -EINVAL;
> + }
Now that we know the size of the table that user has set
we can skip the netif_is_rxfh_configured(dev) and depend fully on
ethtool_rxfh_can_resize(... rss_indir_user_size) ?
Otherwise we're not making much use of dev->ethtool->rss_indir_user_size
(the one for the default context / context 0).
Regardless of the table size user provided IFF_RXFH_CONFIGURED will be
set.
Which brings me to my last point - I think you can delete
IFF_RXFH_CONFIGURED and have netif_is_rxfh_configured(dev)
operate on ..user_size ? We should probably have a new helper
for when driver lost control over rings and has to reset indir table
forgetting user config (bnxt mlx5 clearing IFF_RXFH_CONFIGURED).
Helper should clear the state and issue a Netlink notification?
next prev parent reply other threads:[~2026-03-17 22:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 8:33 [PATCH net-next v5 0/3] ethtool: Dynamic RSS context indirection table resizing Björn Töpel
2026-03-17 8:33 ` [PATCH net-next v5 1/3] ethtool: Add RSS indirection table resize helpers Björn Töpel
2026-03-17 22:46 ` Jakub Kicinski
2026-03-18 9:27 ` Björn Töpel
2026-03-17 8:33 ` [PATCH net-next v5 2/3] bnxt_en: Resize RSS contexts on channel count change Björn Töpel
2026-03-17 22:53 ` Jakub Kicinski [this message]
2026-03-18 9:28 ` Björn Töpel
2026-03-17 8:33 ` [PATCH net-next v5 3/3] selftests: rss_drv: Add RSS indirection table resize tests Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317155359.33b855b1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox