From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA80F315D51; Tue, 17 Mar 2026 23:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789285; cv=none; b=qCfSJELmj50LSjg1FBDHNT7sHw9hB5akWPrfcZKkcuuNZ5Ml4nclV/hoORs6iGx/KsnWtAKj8fVu6FDfyB14XtcJTHPMVut5rL4jiVYZ7x4iIBrh+Tb+2c3HdW9BViI2DoDJ6gSogLV3EpMw/KhFQByajXtnIQoYO7xpxnLYRb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789285; c=relaxed/simple; bh=QpJowkMc/tH4ANWfBZVgPhBoFVmc+3haVzogo5ueys8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=brDKnX+d+mVu4jV+9TIemZtbuEnH8W/Dh2UxQZkUx/DBfsKWVQEldBUSRLW2Yl77+ljEkXNulDH5GejeNzxZh/0Em/pfcJtMuxJaGOsMrRAsn3aH4NM/PYyv4dCSHsLbs/9HjdGlH2XWFkF3HbYAgK+MQZZR+rPnFaV/9RW92xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uF2cjF2u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uF2cjF2u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E11E3C4CEF7; Tue, 17 Mar 2026 23:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773789285; bh=QpJowkMc/tH4ANWfBZVgPhBoFVmc+3haVzogo5ueys8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uF2cjF2u8fzyz+bHZOVHnOqMwNcnXP7m+9NKQxv92/1tA9QRqPXoumAMOX7mpwXYR xZWIPT8dwlK74aDwsPc3bnJ9JhSrDF5AJMsAQSZjO5e2anhaVt+O0FbpQNzUOwuFsp tH5U3+FznM3fdb9mzAjdvISnyLjzmVBzYjxe/Uv6+pjP0fOrMcdiZ/QR3bUQMqLO9B RlMdoSmawHv5XO4DAnt2AYl5mo/duFufYSvuij5+anvecrnVmYbqKKFiHfLGl8I/6S iSt3V3hDsgQQpC9AhH1H/eai2OQ5yx+xczRlJF/ednuFecBNljT3X0/Zc7jQ1zuWLN kxzP5IvzfpHeQ== Date: Tue, 17 Mar 2026 16:14:43 -0700 From: Jakub Kicinski To: dqfext@gmail.com Cc: Martin Olivier , netdev@vger.kernel.org, linux-ppp@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] ppp: add IFLA_PPP_UNIT netlink attribute Message-ID: <20260317161443.01eee26a@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 14 Mar 2026 02:14:29 +0100 Martin Olivier wrote: > Currently, the PPP rtnetlink API allows creating a new network interface > with a custom ifname, but it lacks the ability to specify a custom PPP > unit id. > > Setting a specific unit id is currently only possible with the > PPPIOCNEWUNIT ioctl. If a user-space program also requires a custom > interface name, it must create the interface first with PPPIOCNEWUNIT > and then rename it. > > Resolve this by introducing the IFLA_PPP_UNIT netlink attribute. This > allows user-space programs to atomically request both a custom ifname > and a specific PPP unit id during the RTM_NEWLINK creation process, > eliminating the post-creation renaming for this use case. Qingfang Deng, you work on PPP, could you review this patch, please?