From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: linux-afs@lists.infradead.org, marc.dionne@auristor.com,
dhowells@redhat.com, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Correct rack timer warning to report unexpected mode
Date: Tue, 17 Mar 2026 16:47:53 +0000 [thread overview]
Message-ID: <20260317164753.GB1753385@horms.kernel.org> (raw)
In-Reply-To: <20260314195109.3867287-1-alok.a.tiwari@oracle.com>
On Sat, Mar 14, 2026 at 12:51:00PM -0700, Alok Tiwari wrote:
> rxrpc_rack_timer_expired() clears call->rack_timer_mode to OFF before
> the switch. The default case warning therefore always prints OFF and
> doesn't identify the unexpected timer mode.
>
> Log the saved mode value instead so the warning reports the actual
> unexpected rack timer mode.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-03-17 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 19:51 [PATCH net-next] rxrpc: Correct rack timer warning to report unexpected mode Alok Tiwari
2026-03-17 16:47 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317164753.GB1753385@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox