* [PATCH net-next] rxrpc: Correct rack timer warning to report unexpected mode
@ 2026-03-14 19:51 Alok Tiwari
2026-03-17 16:47 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Alok Tiwari @ 2026-03-14 19:51 UTC (permalink / raw)
To: linux-afs, marc.dionne, dhowells, kuba, davem, edumazet, pabeni,
horms
Cc: alok.a.tiwari, netdev
rxrpc_rack_timer_expired() clears call->rack_timer_mode to OFF before
the switch. The default case warning therefore always prints OFF and
doesn't identify the unexpected timer mode.
Log the saved mode value instead so the warning reports the actual
unexpected rack timer mode.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
net/rxrpc/input_rack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/input_rack.c b/net/rxrpc/input_rack.c
index 13c371261e0a..9eb109ffba56 100644
--- a/net/rxrpc/input_rack.c
+++ b/net/rxrpc/input_rack.c
@@ -413,6 +413,6 @@ void rxrpc_rack_timer_expired(struct rxrpc_call *call, ktime_t overran_by)
break;
//case RXRPC_CALL_RACKTIMER_ZEROWIN:
default:
- pr_warn("Unexpected rack timer %u", call->rack_timer_mode);
+ pr_warn("Unexpected rack timer %u", mode);
}
}
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] rxrpc: Correct rack timer warning to report unexpected mode
2026-03-14 19:51 [PATCH net-next] rxrpc: Correct rack timer warning to report unexpected mode Alok Tiwari
@ 2026-03-17 16:47 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2026-03-17 16:47 UTC (permalink / raw)
To: Alok Tiwari
Cc: linux-afs, marc.dionne, dhowells, kuba, davem, edumazet, pabeni,
netdev
On Sat, Mar 14, 2026 at 12:51:00PM -0700, Alok Tiwari wrote:
> rxrpc_rack_timer_expired() clears call->rack_timer_mode to OFF before
> the switch. The default case warning therefore always prints OFF and
> doesn't identify the unexpected timer mode.
>
> Log the saved mode value instead so the warning reports the actual
> unexpected rack timer mode.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-17 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-14 19:51 [PATCH net-next] rxrpc: Correct rack timer warning to report unexpected mode Alok Tiwari
2026-03-17 16:47 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox