From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C824919CC28; Wed, 18 Mar 2026 01:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773797877; cv=none; b=WiaqeZSDq7pch7EeTLP2Gx+3Jggd2MvejtxufDI7bpWEcwXPVnktMI27sie4glOIY2l7gD3w5s5mv2Qb4y/5Zqjcwmf5OavkDZFUx5KAjZfv1Xuk8LttfwGEBQ7EhWw4sLmAGd4MIzlqmunMidnDaf1RV+qcmIdq5efy/U1cT8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773797877; c=relaxed/simple; bh=8OACo2zU2/Bwj39w1bVR7n+Z35I8eMA8qJPBBV2F4rE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G3ICy4hKZN0kSyU4OLfKc+6WtvFQblfxT2tkYRbO2MrX7UhHeFjwqWKpFqhVxk2MsaaV08UFNwy89rcXn3YCx8hFZWGtc7zJh2pKMLH0zWksrHLYOabafAyeN4bgQ4FwQgSotb8prXP4Kqrsmre5x88GZNX/GmiqLUzJZ4nSDEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fIH7LB+H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fIH7LB+H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17280C4CEF7; Wed, 18 Mar 2026 01:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773797877; bh=8OACo2zU2/Bwj39w1bVR7n+Z35I8eMA8qJPBBV2F4rE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fIH7LB+HGwfHzRBOUSh0yQNEb+BJAtXcRA+jJU6u0FMryEYe4LJ4c9oH3kE7vaAKe 1cgmHkrkIYe0jcomna4SowGENOLQmnhCkc2nPvC/qv6NBsaETvu677vSmIu3EBl+8O yHK6IATc6qJH0sJWIvXMFhZ+J4gK0IFANjwavlhEmXREDlDi9R7zULMpcGo9MdRBQ7 9JBz80ZLBH37mhE3KlT8HiwX6JfQwdwFrsRfLa7AjFfUNNyDpxG+AWqTPgsFYUNZ8s 4T0n2fdrKqBzGkbRTC4MpxfeV7CD8+jMpYuUx1Ss1y+w1n/oIo/AAcBspJxOeD1IsM zMaKGlbifdaLA== Date: Tue, 17 Mar 2026 18:37:56 -0700 From: Jakub Kicinski To: Breno Leitao Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH net-next] bonding: move utsrelease.h include out of bonding_priv.h Message-ID: <20260317183756.33d67d60@kernel.org> In-Reply-To: <20260316-bond_uts-v1-1-428696ea79d5@debian.org> References: <20260316-bond_uts-v1-1-428696ea79d5@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 16 Mar 2026 05:17:45 -0700 Breno Leitao wrote: > +++ b/drivers/net/bonding/bond_procfs.c > @@ -6,8 +6,11 @@ > #include > #include > > +#include > #include "bonding_priv.h" Somewhat unfortunate placement, shouldnt it be the first include above the linux/ ones? If we were going best-effort-alphabetically? > +#define bond_version DRV_DESCRIPTION ": v" UTS_RELEASE "\n" > + > static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos) > __acquires(RCU) > { > diff --git a/drivers/net/bonding/bonding_priv.h b/drivers/net/bonding/bonding_priv.h > index fef6288c6944f..f9b327b6a494a 100644 > --- a/drivers/net/bonding/bonding_priv.h > +++ b/drivers/net/bonding/bonding_priv.h > @@ -12,11 +12,7 @@ > > #ifndef _BONDING_PRIV_H > #define _BONDING_PRIV_H > -#include > - > #define DRV_NAME "bonding" > #define DRV_DESCRIPTION "Ethernet Channel Bonding Driver" I think this entire header can go, TBH? DESCRIPTION is used only in main And DRV_NAME can be replaced by KBUILD_MODNAME where it's used. > -#define bond_version DRV_DESCRIPTION ": v" UTS_RELEASE "\n" > - > #endif