From: Jakub Kicinski <kuba@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
Christian Brauner <brauner@kernel.org>,
Tim Bird <tim.bird@sony.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/dns_resolver: clean up and simplify dns_query()
Date: Tue, 17 Mar 2026 19:19:47 -0700 [thread overview]
Message-ID: <20260317191947.40fdfc49@kernel.org> (raw)
In-Reply-To: <20260316213846.1049655-3-thorsten.blum@linux.dev>
On Mon, 16 Mar 2026 22:38:45 +0100 Thorsten Blum wrote:
> Fold the name length checks into a single early check, and use
> kmemdup_nul() for name-only descriptions and snprintf() for
would be easier to review it if it was two changes but..
> "<type>:<name>" descriptions to simplify dns_query().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> Compile-tested only.
.. we have a policy against encouraging trivial cleanups.
If you can't even test this let's not bother.
--
pw-bot: cr
prev parent reply other threads:[~2026-03-18 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 21:38 [PATCH net-next] net/dns_resolver: clean up and simplify dns_query() Thorsten Blum
2026-03-18 2:19 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317191947.40fdfc49@kernel.org \
--to=kuba@kernel.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@linux.dev \
--cc=tim.bird@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox