From: Nicolai Buchwitz <nb@tipi-net.de>
To: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
Nicolai Buchwitz <nb@tipi-net.de>,
Breno Leitao <leitao@debian.org>
Subject: [PATCH net-next] net: macb: propagate macb_open() failure in macb_set_ringparam()
Date: Tue, 17 Mar 2026 21:22:29 +0100 [thread overview]
Message-ID: <20260317202229.193375-1-nb@tipi-net.de> (raw)
macb_set_ringparam() silently ignores macb_open() failure after
closing and reopening the interface, always returning 0. Propagate
the error so callers know the interface failed to come back up.
Suggested-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 83390dcc89e9..9957f5ae1752 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3754,7 +3754,7 @@ static int macb_set_ringparam(struct net_device *netdev,
bp->tx_ring_size = new_tx_size;
if (reset)
- macb_open(bp->dev);
+ return macb_open(bp->dev);
return 0;
}
--
2.51.0
next reply other threads:[~2026-03-17 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 20:22 Nicolai Buchwitz [this message]
2026-03-18 11:19 ` [PATCH net-next] net: macb: propagate macb_open() failure in macb_set_ringparam() Breno Leitao
2026-03-19 2:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317202229.193375-1-nb@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox