Re: [net-next,v17,07/14] net: homa: create homa_interest.h and homa_interest.c

[Paolo Abeni <pabeni@redhat.com>]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: homa: create homa_interest.h and homa_interest.c

These files implement the homa_interest struct, which is used to wait for
incoming messages.

> diff --git a/net/homa/homa_interest.c b/net/homa/homa_interest.c
> new file mode 100644
> index 000000000000..6daeedd21309
> --- /dev/null
> +++ b/net/homa/homa_interest.c

[ ... ]

> diff --git a/net/homa/homa_interest.h b/net/homa/homa_interest.h
> new file mode 100644
> index 000000000000..d9f932960fd8
> --- /dev/null
> +++ b/net/homa/homa_interest.h
> @@ -0,0 +1,93 @@

[ ... ]

> +/**
> + * homa_interest_unlink_shared() - Remove an interest from the list for a
> + * socket. Note: this can race with homa_rpc_handoff, so on return it's
> + * possible that the interest is ready.
> + * @interest:    Interest to remove. Must have been initialized with
> + *               homa_interest_init_shared.
> + */
> +static inline void homa_interest_unlink_shared(struct homa_interest *interest)
> +	__must_hold(hsk->lock)
> +{
> +	list_del_init(&interest->links);
> +}

The __must_hold annotation references 'hsk->lock' but 'hsk' is not in scope.
This will cause sparse to report an error when checking with 'make C=1'.
Should this be '__must_hold(interest->hsk->lock)' to match the pattern used
in homa_interest_unlink_private?