* [PATCH 2/2] drbd: select CONFIG_NET_HANDSHAKE [not found] <20260318104858.1868731-1-arnd@kernel.org> @ 2026-03-18 10:48 ` Arnd Bergmann 2026-03-18 21:16 ` Christoph Böhmwalder 0 siblings, 1 reply; 3+ messages in thread From: Arnd Bergmann @ 2026-03-18 10:48 UTC (permalink / raw) To: Philipp Reisner, Lars Ellenberg, Christoph Böhmwalder, Jens Axboe, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni Cc: Arnd Bergmann, Simon Horman, Eric Biggers, drbd-dev, linux-block, linux-kernel, netdev From: Arnd Bergmann <arnd@arndb.de> The TLS handshake code is optional and has to be enabled for DRBD: ERROR: modpost: "tls_handshake_cancel" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! ERROR: modpost: "tls_server_hello_x509" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! ERROR: modpost: "tls_client_hello_x509" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! ERROR: modpost: "tls_get_record_type" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! ERROR: modpost: "tls_alert_recv" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! Select the option whenever DRBD is eanbled and rework the dependency in the symbol so it can be selected more easily. Fixes: fa8ef6960ebd ("drbd: add TCP transport implementation") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/block/drbd/Kconfig | 1 + net/Kconfig | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/Kconfig b/drivers/block/drbd/Kconfig index 29ec6ed84251..de9e232d6479 100644 --- a/drivers/block/drbd/Kconfig +++ b/drivers/block/drbd/Kconfig @@ -11,6 +11,7 @@ config BLK_DEV_DRBD depends on PROC_FS && INET select LRU_CACHE select CRC32 + select NET_HANDSHAKE help NOTE: In order to authenticate connections you have to select diff --git a/net/Kconfig b/net/Kconfig index 62266eaf0e95..769880113740 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -92,9 +92,7 @@ source "drivers/dibs/Kconfig" source "net/xdp/Kconfig" config NET_HANDSHAKE - bool - depends on SUNRPC || NVME_TARGET_TCP || NVME_TCP - default y + def_bool SUNRPC || NVME_TARGET_TCP || NVME_TCP config NET_HANDSHAKE_KUNIT_TEST tristate "KUnit tests for the handshake upcall mechanism" if !KUNIT_ALL_TESTS -- 2.39.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] drbd: select CONFIG_NET_HANDSHAKE 2026-03-18 10:48 ` [PATCH 2/2] drbd: select CONFIG_NET_HANDSHAKE Arnd Bergmann @ 2026-03-18 21:16 ` Christoph Böhmwalder 2026-03-18 21:20 ` Arnd Bergmann 0 siblings, 1 reply; 3+ messages in thread From: Christoph Böhmwalder @ 2026-03-18 21:16 UTC (permalink / raw) To: Arnd Bergmann, Philipp Reisner, Lars Ellenberg, Jens Axboe, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni Cc: Arnd Bergmann, Simon Horman, Eric Biggers, drbd-dev, linux-block, linux-kernel, netdev Am 18.03.26 um 11:48 schrieb Arnd Bergmann: > From: Arnd Bergmann <arnd@arndb.de> > > The TLS handshake code is optional and has to be enabled for DRBD: > > ERROR: modpost: "tls_handshake_cancel" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_server_hello_x509" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_client_hello_x509" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_get_record_type" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_alert_recv" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > > Select the option whenever DRBD is eanbled and rework the dependency in > the symbol so it can be selected more easily. > > Fixes: fa8ef6960ebd ("drbd: add TCP transport implementation") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/block/drbd/Kconfig | 1 + > net/Kconfig | 4 +--- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/drbd/Kconfig b/drivers/block/drbd/Kconfig > index 29ec6ed84251..de9e232d6479 100644 > --- a/drivers/block/drbd/Kconfig > +++ b/drivers/block/drbd/Kconfig > @@ -11,6 +11,7 @@ config BLK_DEV_DRBD > depends on PROC_FS && INET > select LRU_CACHE > select CRC32 > + select NET_HANDSHAKE > help > > NOTE: In order to authenticate connections you have to select > diff --git a/net/Kconfig b/net/Kconfig > index 62266eaf0e95..769880113740 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -92,9 +92,7 @@ source "drivers/dibs/Kconfig" > source "net/xdp/Kconfig" > > config NET_HANDSHAKE > - bool > - depends on SUNRPC || NVME_TARGET_TCP || NVME_TCP > - default y > + def_bool SUNRPC || NVME_TARGET_TCP || NVME_TCP > > config NET_HANDSHAKE_KUNIT_TEST > tristate "KUnit tests for the handshake upcall mechanism" if !KUNIT_ALL_TESTS Thanks for the fix, I applied it to our drbd-next tree (which should end up in linux-next). I would prefer to squash these kinds of fixups to keep the history in our patch series clean. Arnd, does that work for you? How do you prefer we handle attribution? Unfortunately I couldn't really find a clear precedence pattern for this, how is this usually handled? -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] drbd: select CONFIG_NET_HANDSHAKE 2026-03-18 21:16 ` Christoph Böhmwalder @ 2026-03-18 21:20 ` Arnd Bergmann 0 siblings, 0 replies; 3+ messages in thread From: Arnd Bergmann @ 2026-03-18 21:20 UTC (permalink / raw) To: Christoph Böhmwalder, Arnd Bergmann, Philipp Reisner, Lars Ellenberg, Jens Axboe, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni Cc: Simon Horman, Eric Biggers, drbd-dev, linux-block, linux-kernel, Netdev On Wed, Mar 18, 2026, at 22:16, Christoph Böhmwalder wrote: > Am 18.03.26 um 11:48 schrieb Arnd Bergmann: >> config NET_HANDSHAKE_KUNIT_TEST >> tristate "KUnit tests for the handshake upcall mechanism" if !KUNIT_ALL_TESTS > > Thanks for the fix, I applied it to our drbd-next tree (which should end > up in linux-next). > > I would prefer to squash these kinds of fixups to keep the history in > our patch series clean. > Arnd, does that work for you? How do you prefer we handle attribution? > > Unfortunately I couldn't really find a clear precedence pattern for > this, how is this usually handled? Whichever way works best for you. Some people care a lot about attribution for bugfixes, but I generally prefer a clean history myself. Arnd ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-18 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260318104858.1868731-1-arnd@kernel.org>
2026-03-18 10:48 ` [PATCH 2/2] drbd: select CONFIG_NET_HANDSHAKE Arnd Bergmann
2026-03-18 21:16 ` Christoph Böhmwalder
2026-03-18 21:20 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox