public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Agalakov Daniil <ade@amicon.ru>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Agalakov Daniil <ade@amicon.ru>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>,
	"Daniil Iskhakov" <dish@amicon.ru>, Roman Razov <rrv@amicon.ru>
Subject: [PATCH net 0/3] e1000/e1000e: fix uninitialized memory access in EEPROM write
Date: Wed, 18 Mar 2026 15:05:04 +0300	[thread overview]
Message-ID: <20260318120512.687149-1-ade@amicon.ru> (raw)

This series addresses a common issues related to uninitialized memory
access during EEPROM write operations in the e1000 and e1000e drivers.

In the e1000 driver, the return value of e1000_read_eeprom() was not
checked, and both e1000 and e1000e drivers performed endianness
conversion on the entire buffer, including uninitialized interior words.

The changes are:
 - add missing error checks for e1000_read_eeprom() in e1000;
 - limit endianness conversion to the boundary words being read,
   avoiding a loop over entire (and partially uninitialized) buffer in
   both e1000 and e1000e.

Patch 1: e1000: check return value of e1000_read_eeprom
Patch 2: e1000: fix endianness conversion of uninitialized words
Patch 3: e1000e: fix endianness conversion of uninitialized words

Co-developed-by: Iskhakov Daniil <dish@amicon.ru>
Signed-off-by: Iskhakov Daniil <dish@amicon.ru>
Signed-off-by: Agalakov Daniil <ade@amicon.ru>
---
 .../net/ethernet/intel/e1000/e1000_ethtool.c  | 18 +++++++++++++-----
 drivers/net/ethernet/intel/e1000e/ethtool.c   | 19 ++++++++++++-------
 2 files changed, 25 insertions(+), 12 deletions(-)

-- 
2.51.0


             reply	other threads:[~2026-03-18 12:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 12:05 Agalakov Daniil [this message]
2026-03-18 12:05 ` [PATCH net 1/3] e1000: check return value of e1000_read_eeprom Agalakov Daniil
2026-03-18 15:38   ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 12:05 ` [PATCH net 2/3] e1000: fix endianness conversion of uninitialized words Agalakov Daniil
2026-03-18 15:38   ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-24 23:26   ` Tony Nguyen
2026-03-25 15:19     ` Fedor Pchelkin
2026-03-25 23:01       ` Jacob Keller
2026-03-18 12:05 ` [PATCH net 3/3] e1000e: " Agalakov Daniil
2026-03-18 15:39   ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-24 23:27   ` Tony Nguyen
2026-03-25 15:02     ` [PATCH net v2] e1000: check return value of e1000_read_eeprom Agalakov Daniil
2026-03-25 15:42       ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-25 15:16     ` [PATCH net-next v2 0/2] e1000/e1000e: limit endianness conversion to boundary words Agalakov Daniil
2026-03-25 15:16       ` [PATCH net-next v2 1/2] e1000: " Agalakov Daniil
2026-03-26  7:29         ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-25 15:16       ` [PATCH net-next v2 2/2] e1000e: " Agalakov Daniil
2026-03-26  7:28         ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-25 16:00     ` [PATCH net v3] e1000: check return value of e1000_read_eeprom Agalakov Daniil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318120512.687149-1-ade@amicon.ru \
    --to=ade@amicon.ru \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dish@amicon.ru \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=rrv@amicon.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox