From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.amicon.ru (unknown [77.108.111.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3D3A3D6493; Wed, 18 Mar 2026 12:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.108.111.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773836452; cv=none; b=NV3uFhM9yu/uYwmQsSXmf5yOBNvdxlOwaRhfOxdDq+8A64Ii/98SEJp6NyMJpUBPu/OJhrP06lgf3hBgY2lVrzr1glMPB+zn9hj6SzV6DoCyek0edZHteoq/xsgxAHFttH64UBUquF/gqrfTfAgLuo5gvNCpEvSNsHKjodjwWtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773836452; c=relaxed/simple; bh=XZen40Yk+QoMIT6s4hnv4GEbtv6HyjqcTqgr8GMETfI=; h=Content-Type:From:To:CC:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version; b=sTaNS5cI7XM+uW5VyUXhphhTTdoNCjDeaRAcT8TFuRfSNd1iyyj34BCaXLGb30qWAPwc2MaN1ycgzxBeC393Tk/zYR19SmMQAfX/HERIfdOjfFUSuWe3lrIvX7v1VYmEiWah24wLU5MGGZYoPYvnYQoapmaA1oeJNzx3fIjD0Ig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amicon.ru; spf=pass smtp.mailfrom=amicon.ru; dkim=pass (2048-bit key) header.d=amicon.ru header.i=@amicon.ru header.b=KarlrZZH; arc=none smtp.client-ip=77.108.111.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amicon.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amicon.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amicon.ru header.i=@amicon.ru header.b="KarlrZZH" Content-Transfer-Encoding: 8bit Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; d=amicon.ru; s=mail; c=simple/simple; t=1773835531; h=from:subject:to:date:message-id; bh=XZen40Yk+QoMIT6s4hnv4GEbtv6HyjqcTqgr8GMETfI=; b=KarlrZZHrsoqSVRJAFH0BUR8rZgVSwlvrDy97U52GJXk15tmNkczjrtdFai1urFpF38fGgSGoLq OAnjIUpfI4Lq4gEK+D2g/C18jZ4LYIsnS7A0cnjUQlzhaSvOy4t3+yMDx/OZHAVwVMMRYVLzmGz0F 8tLGyj9tcebnFFyc402qWvT8Z0+GFFPQNcNt5yShTF7W3tWBDxOi2U9Im89o2jmGlU3FbiTVAHRmb MnXaUzgwadhBUY1Is9YVmQKTmSXWhCqBMH+/d8zCUF8EtKAKXQhIaQBtLcNgnJsnIIA1yWpZMyB1I OTK/D+yOr5uT6FYggJyw/tnJUKYjpekPAr1w== Received: from example.com (172.16.2.46) by mail.amicon.lan (192.168.0.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.27; Wed, 18 Mar 2026 15:05:31 +0300 From: Agalakov Daniil To: Tony Nguyen CC: Agalakov Daniil , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , , , , , "Daniil Iskhakov" , Roman Razov Subject: [PATCH net 3/3] e1000e: fix endianness conversion of uninitialized words Date: Wed, 18 Mar 2026 15:05:07 +0300 Message-ID: <20260318120512.687149-4-ade@amicon.ru> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260318120512.687149-1-ade@amicon.ru> References: <20260318120512.687149-1-ade@amicon.ru> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: mail.amicon.lan (192.168.0.59) To mail.amicon.lan (192.168.0.59) [Why] In e1000_set_eeprom(), the eeprom_buff is allocated to hold a range of words. However, only the boundary words (the first and the last) are populated from the EEPROM if the write request is not word-aligned. The words in the middle of the buffer remain uninitialized because they are intended to be completely overwritten by the new data via memcpy(). The previous implementation had a loop that performed le16_to_cpus() on the entire buffer. This resulted in endianness conversion being performed on uninitialized memory for all interior words. Fix this by converting the endianness only for the boundary words immediately after they are successfully read from the EEPROM. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Co-developed-by: Iskhakov Daniil Signed-off-by: Iskhakov Daniil Signed-off-by: Agalakov Daniil --- drivers/net/ethernet/intel/e1000e/ethtool.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index dbed30943ef4..a8b35ae41141 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c @@ -583,20 +583,25 @@ static int e1000_set_eeprom(struct net_device *netdev, /* need read/modify/write of first changed EEPROM word */ /* only the second byte of the word is being modified */ ret_val = e1000_read_nvm(hw, first_word, 1, &eeprom_buff[0]); + if (ret_val) + goto out; + + /* Device's eeprom is always little-endian, word addressable */ + le16_to_cpus(&eeprom_buff[0]); + ptr++; } - if (((eeprom->offset + eeprom->len) & 1) && (!ret_val)) + if ((eeprom->offset + eeprom->len) & 1) { /* need read/modify/write of last changed EEPROM word */ /* only the first byte of the word is being modified */ ret_val = e1000_read_nvm(hw, last_word, 1, &eeprom_buff[last_word - first_word]); + if (ret_val) + goto out; - if (ret_val) - goto out; - - /* Device's eeprom is always little-endian, word addressable */ - for (i = 0; i < last_word - first_word + 1; i++) - le16_to_cpus(&eeprom_buff[i]); + /* Device's eeprom is always little-endian, word addressable */ + le16_to_cpus(&eeprom_buff[last_word - first_word]); + } memcpy(ptr, bytes, eeprom->len); -- 2.51.0