From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010017.outbound.protection.outlook.com [52.101.46.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B7B83BFE40; Wed, 18 Mar 2026 12:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773835840; cv=fail; b=BUDDVGG4JLQxW0I9MmhEyEMyzuNki8PA6QDtbW50MsTLmaOmIfHAMvpdbecQ/9+TntGNKBlm9VXgwpdze9Cr4a+xKKHYEl5/yHOel2FG+0fecIlhXSWUoZ0TqGTo3fKRxlzV42Qal6bpDaL4EYFVnOEhHHlD/kJU/HuRo7nzpr8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773835840; c=relaxed/simple; bh=/hOq6Ly2egoiqJym1Nf9smAKv4cA/LTfsf2ehV+HC5M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ReSF/xsjnKYVcxqvU6JPupxx4UI5LgdwZErf8+KvlOdF2SeuCtQsm9TKQBpacVHO09rCKmsfkyfg3BFz8AxJVESn2ZOZjQaq6JXDj0M+DCsF0Isyzp6nwtksFMUT8o6oOjoTIUpxdyo3bjbuoNv0eZcSOvYw1X1wxmTOr1IBtn0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ne9X4elu; arc=fail smtp.client-ip=52.101.46.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ne9X4elu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YC1W+uU7b1QOV/luXw8Y6sqp4R1+lMG7PfIrV4pHWsQ5gzuxUXWbQze0wB5NJbMUwKFi1eGer12vXArxJPTiG25eAL0Z6x3vM3C7JbQEGj7oPscQKGeukrH5rMmMt7PGX1BoWyO2Z8AWuj2sDTGKWekeTgCaceKA0fvCshilHyoD2tbR5e7bkuNXOCP7VOwriWy+nSmFsBFkQ/IIQsBY6kwN4uKwFdHwtiKUVxmajuR1L31EvTz7CdBgXmikjnYgTWGhxcve82iX5/sX9RvJCurW2FxWH4BK9EifcAMIkHp+ovyVrS9z3rf+7SokF67JN0SVCPk0ZTyND6WIBaAXzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EVRD/6WJ4Y7LMIP7siLO5DA31yQ+4epO0WFal+6A3rw=; b=RozmgeoflwifNPiE1LfGe+3wInvSF8blqplcQMogCIglLgjWhNGPKG47xAdgBLxZHTBSxaNtlga2ZqwbVrcJEsEB0wsTWaZNnD1spq9+ZBdya3QN08/tqH5tr8btxdx86Qrz8Cm/WHWgTsxVNYwsLHXKWMG8pp0KkJCewmKhzAP1gLZdzbFZKAmCooPRE7d+6lRAXomeOjzA4UVkjNFwD9socZ251gDDrhbKhMvujd9WvvFi0QVvMkB2mhc5k3/2+RDGklnpHKStnaT5pjumf67DaHd80QwMI1rTXuonKEZPxlF2rBicYpO6/J+iAUza3B3mYTbAp0JmzetExji77A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVRD/6WJ4Y7LMIP7siLO5DA31yQ+4epO0WFal+6A3rw=; b=ne9X4elu9HHAQTWhZiJKS0F1L4lfFH492Pzqt5JBk/JEL8Kg6uXhFDGFEWqZyQX0N80R1/0JRJg2KncKDgTZYHhQ0b5kQuHNFr4lABSVD/Zlb6sF/GO4XI5R5bB0zuhh3xZqCD4Wl5Zu/bzbazCTTmAXQOxzADz9CdVRfxgZsfc= Received: from CH0PR03CA0347.namprd03.prod.outlook.com (2603:10b6:610:11a::26) by BY5PR12MB4132.namprd12.prod.outlook.com (2603:10b6:a03:209::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Wed, 18 Mar 2026 12:10:35 +0000 Received: from DS3PEPF000099DC.namprd04.prod.outlook.com (2603:10b6:610:11a:cafe::7f) by CH0PR03CA0347.outlook.office365.com (2603:10b6:610:11a::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9700.27 via Frontend Transport; Wed, 18 Mar 2026 12:10:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by DS3PEPF000099DC.mail.protection.outlook.com (10.167.17.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19 via Frontend Transport; Wed, 18 Mar 2026 12:10:34 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 18 Mar 2026 07:10:32 -0500 From: Raju Rangoju To: CC: , , , , , , "Raju Rangoju" Subject: [PATCH v2 net-next 1/3] amd-xgbe: add adaptive link status polling Date: Wed, 18 Mar 2026 17:40:04 +0530 Message-ID: <20260318121006.1565435-2-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260318121006.1565435-1-Raju.Rangoju@amd.com> References: <20260318121006.1565435-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DC:EE_|BY5PR12MB4132:EE_ X-MS-Office365-Filtering-Correlation-Id: 029eaf29-0abe-4b71-c0e3-08de84e75c01 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 9RWyrBdWGRFVd2WZjTo+7FOujdihJN9lqMy7DBsGDyEdWN4nLLf/JFdZf5Lc8XzIEtiFS8rvbtAqIJsUKKiVoT1XIqKdpUybVPJqIE2LuNDSKyT/aYiP0u+2ZXemDlsuQFbrG3WMgPwNfDVby3asxDhXQbxUp/z28GhBv4UHBKj7aOs3QpAI+HuOgc9BCUwccNbOvHE6UXKfLL/ssrnKwIw6nsixNCiPkmvMSkPoTFDuWSvcCkCh/fLvyk81myELbKAQDc5Xl6neH095h54gdxh2XunJry9ipM0E9zCh+cy5ITCBPbbhWrEKhgglCK1K15iAdj4gDYt/kySRKhgiKo1ApJboDf4g6LTMKEYEfS6YW9WOlTygH4NDBlIcVgl8IwcMcgTh/wr3t8Ghvj32kPnJIXYfHUHG8XCp29tHFL18q3U8hGquahfiFseEMTsJBQ6LekQEBMM5EOWRWGj76/m2HcIVHTYML9MO2PRwwNG9eP4sl/Lfl2FiOU9MPvr3Ezivws/Qo3ORkrrMwHeookZVZSW5fiL16ZFsFthDnXVPE53NEJUmHpWpJBv4lZ1mG6xx4O9VrQnhUyv5HeDjLKlNZbrXJOhneqCrHL5IpCjgQj+9p6zmKe7khN27Cdu8EQjToeBIMKOevKTcOMR5EH+28FnjnFdYFMIVYzS6JoK/0pDJIlz/1cgFZiRqQY6R/nC2XseraeDzfS4Qw86Pl53MgB5ae4dGQdztEqnkEayO7e0NUt3OD3qki54BFQv4HqcIg9e6RDP5bF45AlqdFw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qTBc6ee6TmiD3q2eTeUIPnUBK5n7GXli5gIiWeXKlbsC1szQ3ZTmmIZhnsNe3FX5ZI+hwqzIjxoK0UZC4YdkehQRkRYqGAa/BjCdcGQq0ZCy5gD6UiShd+UsSV7TJxrHTbEsQiuPR7x0mVFfQo6RDQN3EK1km44+xU45cgN5+Bmm71gtgCyvryrr+DtB8Hokitv3Gt/KhEB2XINgrs6Yeo1uFsnNjJhKZDs8dQ5tMf/LidLj7zvUbY6dMMp/KLzESA+C6l5uAIznu2WF8Efax0qwdLMwyenRFLf3N9xvxNQuKSxQTHYWJDCgm+ObK27Enf+6xyC9VRCQj/ddw1iaf8/3keHrfrfjYkIKR29vjLbhUFjgd2HUqXcjrPk5KN/sStHVFJZLuRCYS/DmmAlUvp5yT5a1p4975yvvyKFgssSenxA9oBWIdVRocB71uMBF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2026 12:10:34.8521 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 029eaf29-0abe-4b71-c0e3-08de84e75c01 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DC.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4132 Implement adaptive link status polling to enable fast link-down detection while conserving CPU resources during link-down periods. Currently, the driver polls link status at a fixed 1-second interval regardless of link state. This creates a trade-off: - Slow polling (1s): Misses rapid link state changes, causing delays - Fast polling: Wastes CPU when link is stable or down This enhancement introduces state-aware polling: When carrier is UP: Poll every 100ms to enable rapid link-down detection. This provides ~100-200ms response time to link failures, minimizing packet loss and enabling fast failover in link aggregation configurations. When carrier is DOWN: Poll every 1s to conserve CPU resources. Link-up detection is less time-critical since no traffic is flowing. Performance impact: - Link-down detection: 1000ms → 100-200ms (10x improvement) - CPU overhead when link up: 0.1% → 1% (acceptable for active links) - CPU overhead when link down: unchanged at 0.1% This is particularly valuable for: - Link aggregation deployments requiring sub-second failover - Environments with flaky links or cable issues - Applications sensitive to connection recovery time Signed-off-by: Raju Rangoju --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 2f39f38fecf9..6886d3b33ffe 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -607,11 +607,33 @@ static void xgbe_service_timer(struct timer_list *t) struct xgbe_prv_data *pdata = timer_container_of(pdata, t, service_timer); struct xgbe_channel *channel; + unsigned int poll_interval; unsigned int i; queue_work(pdata->dev_workqueue, &pdata->service_work); - mod_timer(&pdata->service_timer, jiffies + HZ); + /* Adaptive link status polling for fast failure detection: + * + * - When carrier is UP: poll every 100ms for rapid link-down detection + * Enables sub-second response to link failures, minimizing traffic + * loss. + * + * - When carrier is DOWN: poll every 1s to conserve CPU resources + * Link-up events are less time-critical. + * + * The 100ms active polling interval balances responsiveness with + * efficiency: + * - Provides ~100-200ms link-down detection (10x faster than 1s + * polling) + * - Minimal CPU overhead (1% vs 0.1% with 1s polling) + * - Enables fast failover in link aggregation deployments + */ + if (netif_running(pdata->netdev) && netif_carrier_ok(pdata->netdev)) + poll_interval = msecs_to_jiffies(100); /* 100ms when up */ + else + poll_interval = HZ; /* 1 second when down */ + + mod_timer(&pdata->service_timer, jiffies + poll_interval); if (!pdata->tx_usecs) return; -- 2.34.1