From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <anzaki@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
fw@strlen.de, coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next 1/2] net: treewide: pass number of pkts to dev_sw_netstats_rx_add()
Date: Wed, 18 Mar 2026 19:12:54 -0700 [thread overview]
Message-ID: <20260318191254.30d5124d@kernel.org> (raw)
In-Reply-To: <20260317234851.234466-2-anzaki@gmail.com>
On Tue, 17 Mar 2026 17:48:50 -0600 Ahmed Zaki wrote:
> Allow callers of dev_sw_netstats_rx_add() to update the netdev stats
> with multiple packets.
Please don't. If you have to change almost 30 users to add one you're
probably doing something wrong with the interface.
next prev parent reply other threads:[~2026-03-19 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 23:48 [PATCH nf-next 0/2] Update netdev stats with offloaded flows Ahmed Zaki
2026-03-17 23:48 ` [PATCH nf-next 1/2] net: treewide: pass number of pkts to dev_sw_netstats_rx_add() Ahmed Zaki
2026-03-19 2:12 ` Jakub Kicinski [this message]
2026-03-17 23:48 ` [PATCH nf-next 2/2] netfilter: flowtable: update netdev stats with HW_OFFLOAD flows Ahmed Zaki
2026-03-18 0:32 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318191254.30d5124d@kernel.org \
--to=kuba@kernel.org \
--cc=anzaki@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox