From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2DEB2C21FE; Thu, 19 Mar 2026 02:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773887689; cv=none; b=Nls2EHPmRJMsAdZz+flxe+eQRWVb1COly1tGZhmshwjEI9QmrKOdyo0qmjxBAHlWGIFJeO4fdaf/Z8zI8HbIb/gqt/Qbfqf6AMg6qsylIUx6h401y6sa/xy4gyG5e7XyzS06gdltpPXJB765H73CEtEXoruSEH5yHq5jpNVj5h0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773887689; c=relaxed/simple; bh=eegzmj5P+BS9SL9Y6oV95qoVHEvqSEWfZ+k8aCJ4XMA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ehzc+kZTElwHl3MX8S9g91Rep94Tnh5bR/gRWPe1mbtWv5bwi3FJyrLOlWOjxYsqH1ppnzk8hE+/TPR0pzNlJJWPp9PbeqICqtWL9MUpGn+XsQkLtBc82jNb91QbVMt8d8bTjNBaaukkqW7HWpLdWBqi88eiVraP4MYGMg6chsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sv6KsHCA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sv6KsHCA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23F2BC19421; Thu, 19 Mar 2026 02:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773887689; bh=eegzmj5P+BS9SL9Y6oV95qoVHEvqSEWfZ+k8aCJ4XMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sv6KsHCAZxiCykt4d3twmtjE2v7S7mafinYXRJ3Sq43m/tRoNEu2rbjmCTJynSQT6 dbjjJldsPypq/YEzk3+p4X6hQJjdTuGC0t5KgDBDQpzapEyn3sMnMaz1XwXBBVcs3Z qBq78WrCg+KyEaWx8Kl1+girzxBn41WUpqW4KCkDxJXgle/UZOCnRDYwWnDWm9LwwD 3vkPsVknrp/U+UTV5vaHgbRCGT4ilEnnkKf8f7/LotM68dadTY9zjdwyh7/IUsgLeA ZySnxXekG3wn/gthdoKL5s0j431Rhu7InrXy8Ig+BrFmkM2/RtGqcnQeWzz42YbdPi TOaJmCOXB0fAg== Date: Wed, 18 Mar 2026 19:34:47 -0700 From: Jakub Kicinski To: Tony Nguyen Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, Phani R Burra , larysa.zaremba@intel.com, przemyslaw.kitszel@intel.com, aleksander.lobakin@intel.com, sridhar.samudrala@intel.com, anjali.singhai@intel.com, michal.swiatkowski@linux.intel.com, maciej.fijalkowski@intel.com, emil.s.tantilov@intel.com, madhu.chittim@intel.com, joshua.a.hay@intel.com, jacob.e.keller@intel.com, jayaprakash.shanmugam@intel.com, natalia.wochtman@intel.com, jiri@resnulli.us, horms@kernel.org, corbet@lwn.net, richardcochran@gmail.com, linux-doc@vger.kernel.org, Bharath R , Samuel Salin Subject: Re: [PATCH net-next 06/15] libie: add bookkeeping support for control queue messages Message-ID: <20260318193447.2e7b1f4d@kernel.org> In-Reply-To: <20260317230905.847744-7-anthony.l.nguyen@intel.com> References: <20260317230905.847744-1-anthony.l.nguyen@intel.com> <20260317230905.847744-7-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 17 Mar 2026 16:08:54 -0700 Tony Nguyen wrote: > From: Phani R Burra > > All send control queue messages are allocated/freed in libie itself and > tracked with the unique transaction (Xn) ids until they receive response or > time out. Responses can be received out of order, therefore transactions > are stored in an array and tracked though a bitmap. > > Pre-allocated DMA memory is used where possible. It reduces the driver > overhead in handling memory allocation/free and message timeouts. Warning: include/linux/intel/libie/controlq.h:397 struct member 'force' not described in 'libie_ctlq_xn_clean_params' Please also look thru the AI reviews before you repost: https://netdev-ai.bots.linux.dev/ai-review.html?id=2078570c-9d93-4076-ace9-f275d8637314 and: https://sashiko.dev/#/patchset/20260317230905.847744-1-anthony.l.nguyen%40intel.com