From: Jakub Kicinski <kuba@kernel.org>
To: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com,
rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com,
Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Subject: Re: [PATCH net-next v7 06/10] bng_en: add HW stats infra and structured ethtool ops
Date: Wed, 18 Mar 2026 19:53:36 -0700 [thread overview]
Message-ID: <20260318195336.0406eaf0@kernel.org> (raw)
In-Reply-To: <20260318150149.7a8c6067@kernel.org>
On Wed, 18 Mar 2026 15:01:49 -0700 Jakub Kicinski wrote:
> On Sun, 15 Mar 2026 19:46:01 +0530 Vikas Gupta wrote:
> > + /* Per port queue IDs start from 0, 10, 20, etc */
> > + queue_idx = queue_id % 10;
> > + if (queue_idx >= BNGE_MAX_QUEUE) {
> > + bn->pri2cos_valid = false;
> > + bnge_hwrm_req_drop(bd, req_qc);
> > + return rc;
> > + }
>
> Dan C's report looks still relevant:
>
> https://lore.kernel.org/all/202603180509.nOQGZrG0-lkp@intel.com/
FWIW other than this the series LGTM
next prev parent reply other threads:[~2026-03-19 2:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 14:15 [PATCH net-next v7 00/10] bng_en: add link management and statistics support Vikas Gupta
2026-03-15 14:15 ` [PATCH net-next v7 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Vikas Gupta
2026-03-15 14:15 ` [PATCH net-next v7 02/10] bng_en: query PHY capabilities and report link status Vikas Gupta
2026-03-15 14:15 ` [PATCH net-next v7 03/10] bng_en: add ethtool link settings, get_link, and nway_reset Vikas Gupta
2026-03-15 14:15 ` [PATCH net-next v7 04/10] bng_en: implement ethtool pauseparam operations Vikas Gupta
2026-03-15 14:16 ` [PATCH net-next v7 05/10] bng_en: add support for link async events Vikas Gupta
2026-03-15 14:16 ` [PATCH net-next v7 06/10] bng_en: add HW stats infra and structured ethtool ops Vikas Gupta
2026-03-18 22:01 ` Jakub Kicinski
2026-03-19 2:53 ` Jakub Kicinski [this message]
2026-03-15 14:16 ` [PATCH net-next v7 07/10] bng_en: periodically fetch and accumulate hardware statistics Vikas Gupta
2026-03-15 14:16 ` [PATCH net-next v7 08/10] bng_en: implement ndo_get_stats64 Vikas Gupta
2026-03-15 14:16 ` [PATCH net-next v7 09/10] bng_en: implement netdev_stat_ops Vikas Gupta
2026-03-15 14:16 ` [PATCH net-next v7 10/10] bng_en: add support for ethtool -S stats display Vikas Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318195336.0406eaf0@kernel.org \
--to=kuba@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox