From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 190EA3CE4B6; Thu, 19 Mar 2026 14:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773932026; cv=none; b=sveQEa7UkEYdA1F1YytkvAYlOhbSnbS0T4Ruji0DzpiFpoWFWkGv8z15NAUETCaWkgwHZoh0OxlJFzcVQ5HeX3DdHXBD9/Xm3rvpAzIKyjOUotErIqCn4m0IGl3ZF6/BQnCwsTCRLmnQWAekaOYLSfTlBPsm8Vn/2MR/hIFNp8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773932026; c=relaxed/simple; bh=rGBzuTdV67vpKY5ZL0KiZjtu15TYhwh3ofg/+ry07r4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I384Jy50K8aNUkxbX3Wu3P+YZkFaxi3GBT5fVn858hS1hvQtNkuQmoRDGjHGapni3EI3sIypSFuxuY3KoHzuHrYNENJ7HprS2VIGjxDla7VZ7sn7729jzsiEMH/625nY4VnqcpM7PuMCzZWpVBZhy2LXnIdXaBIx9gmiPYLpnqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rlB2m3NC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rlB2m3NC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0318C19424; Thu, 19 Mar 2026 14:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773932025; bh=rGBzuTdV67vpKY5ZL0KiZjtu15TYhwh3ofg/+ry07r4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rlB2m3NCdVPh1g5yWDF9i5h1ZSib6iQ9EZ6taTsPfEygLzIhKAdbZR0z/uqh2JZbn 1ca0skbd4EtPSspf1ovEbMwBsvdxhHYVp4lpLNmYN2nxatRTT8uuABjLbwsOQFYB5i TR5kahdN1xirGg8WtclXulBY9Ot4ScAQAlEMgAYIfe7ARQA2e4IhrjXYgbQ5DgPrH3 fSa6QlhYuQoFz6ZAY2EyDKf6qNSWX6hQQOBxNlM7sbxCo4S6qRlZ7Z7Y0W9P+ojUU9 q025yGx/l4KwxWVT7ZHNM24nlHpfsiasef0kph/eLKEg2Llm/Kcng+TAvHvo0Spmvs 3/JUak+Ye7QRQ== Date: Thu, 19 Mar 2026 07:53:43 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Marek =?UTF-8?B?QmVow7pu?= , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH net-next v7 10/10] net: ethtool: Introduce ethtool command to list ports Message-ID: <20260319075343.0aa9fac8@kernel.org> In-Reply-To: <97bd2ab1-a8ff-4c0b-a328-952139f18fc8@bootlin.com> References: <20260309152747.702373-1-maxime.chevallier@bootlin.com> <20260309152747.702373-11-maxime.chevallier@bootlin.com> <20260312190705.0b3a3f78@kernel.org> <97bd2ab1-a8ff-4c0b-a328-952139f18fc8@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 19 Mar 2026 10:27:11 +0100 Maxime Chevallier wrote: > > GENL_REQ_ATTR_CHECK ? > > I guess you'll have to move it to prepare cause we don't get info > > here :( > > Sorry for my comments coming apart on your review, I'm getting this new > iteration done in-between other tasks :( > > I can't move that check to the prepare_data() step, as we need the > request->port_id field to be populated at that stage for the DUMP > op (for each port, we set request->port_id, then we call prepare_data > and so on). Not sure I get what you're saying - that it doesn't work or that it leads to "duplicated" work? Alternative is to add info to parse_request args which I suspect is useful long term anyway.