From: Francesco Dolcini <francesco@dolcini.it>
To: Buday Csaba <buday.csaba@prolan.hu>
Cc: "Wei Fang" <wei.fang@nxp.com>,
"Shenwei Wang" <shenwei.wang@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Csókás, Bence" <csokas.bence@prolan.hu>,
"Frank Li" <Frank.Li@nxp.com>,
"Francesco Dolcini" <francesco.dolcini@toradex.com>,
imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/1] net: fec: fix the PTP periodic output sysfs interface
Date: Thu, 19 Mar 2026 09:09:46 +0100 [thread overview]
Message-ID: <20260319080946.GA6892@francesco-nb> (raw)
In-Reply-To: <e2518c8f932fd9da6754b5ab5cc892ed58a0c1db.1773849293.git.buday.csaba@prolan.hu>
On Wed, Mar 18, 2026 at 04:56:15PM +0100, Buday Csaba wrote:
> The PPS channel selection was incorrectly implemented in the orginal
> commit (see fixes). The sysfs interface uses a logical channel index,
> and rejects channel numbers greater than zero (n_per_out is 1).
> See: period_store() in drivers/ptp/ptp_sysfs.c
>
> On the other hand, the FEC PTP driver was expecting the hardware
> channel number, making the periodic output unusable from the sysfs
> interface, with the exception of channel 0.
>
> Fix the FEC PTP driver to match the logical channel number of the
> sysfs interface.
>
> Fixes: bf8ca67e2167 ("net: fec: refactor PPS channel configuration")
The commit you mention as fixes, it was just a refactor. The behavior
before/after that commit was supposed to be the same.
That commit never implemented "PPS channel selection", as you wrongly
state here.
Francesco
prev parent reply other threads:[~2026-03-19 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 15:56 [PATCH net 1/1] net: fec: fix the PTP periodic output sysfs interface Buday Csaba
2026-03-18 22:52 ` Frank Li
2026-03-18 23:32 ` Jakub Kicinski
2026-03-19 3:35 ` Wei Fang
2026-03-19 8:04 ` Buday Csaba
2026-03-19 8:40 ` Wei Fang
2026-03-19 8:09 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319080946.GA6892@francesco-nb \
--to=francesco@dolcini.it \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=buday.csaba@prolan.hu \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox