From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2028623EAB3; Thu, 19 Mar 2026 08:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907794; cv=none; b=jCQFD1V5cZ//ovgk+be3gNy6Z/GKTg0AulPQIjXw8zH9ZeMKXKfzMIyLwZmv9BuwtzvePDxJbUH/vcOsr3LU5yAjxMrXV2rEKnTzsxyeNavB/1vy+PRWSEk0zG8NpPDjuBjuLNEociG5Z5J5Y5NadUy2FRuceX+PUX2gtzLgu/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907794; c=relaxed/simple; bh=/eoynW+sJF2PZIxRo6AnYTGNfHvzdyYKKp2Ao3jzLcc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FepU4Dd3k19n+6uh3UoKljhnXZh4UiFocLzbLt3BvqkFzWhLRzmgT9dMDgZYBoTEx55BizHf28v0VyyXYibgWt1W2I00vZSdFIZtChbaO5cOBC08uybu0ukkTFFY6RFMmBI2NSe7BEWHzFwkECfBCz56IGS5LPH0uNQOJ3BE3gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=zrlJ1VvD; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="zrlJ1VvD" Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 6D2581F940; Thu, 19 Mar 2026 09:09:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1773907790; bh=dJ9657zYwrukRzdvCzFf1VnhYPLd6Qfy7rR+2FHT8ck=; h=From:To:Subject; b=zrlJ1VvDSl/dduMYyCDLgrB7+m47+yT9EQy2Z/dfvbJiPRQ+4UowtlKFZ/2yZiJa5 mCg78FxTuaxcyPnIothacTLB5C04LPofi+mdhywb/uuAWlbl+V+wbV0MIwKZP/6nE6 2PA1I2fCfn8nvARH3MO9jO5UCQSnxTmGHPkj6seqRMqJxGXxni78Pt1a3fobRbKnQg KOVB16Fauyszexxxrp675EKp/DfyhS1kioD/7RgeRVzUSeoZS6HKyEe8OYTuVfBitj D0Sbdj9ykSFlz3M6oRepiEXNSUb4aQZVZB3xPQviKtg+mUoul+oYRm5RxJumDaaTvk rWYi1dnJSxvJQ== Date: Thu, 19 Mar 2026 09:09:46 +0100 From: Francesco Dolcini To: Buday Csaba Cc: Wei Fang , Shenwei Wang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , =?iso-8859-1?B?Q3Pza+FzLA==?= Bence , Frank Li , Francesco Dolcini , imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/1] net: fec: fix the PTP periodic output sysfs interface Message-ID: <20260319080946.GA6892@francesco-nb> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 18, 2026 at 04:56:15PM +0100, Buday Csaba wrote: > The PPS channel selection was incorrectly implemented in the orginal > commit (see fixes). The sysfs interface uses a logical channel index, > and rejects channel numbers greater than zero (n_per_out is 1). > See: period_store() in drivers/ptp/ptp_sysfs.c > > On the other hand, the FEC PTP driver was expecting the hardware > channel number, making the periodic output unusable from the sysfs > interface, with the exception of channel 0. > > Fix the FEC PTP driver to match the logical channel number of the > sysfs interface. > > Fixes: bf8ca67e2167 ("net: fec: refactor PPS channel configuration") The commit you mention as fixes, it was just a refactor. The behavior before/after that commit was supposed to be the same. That commit never implemented "PPS channel selection", as you wrongly state here. Francesco