From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
donald.hunter@gmail.com, shuah@kernel.org, matttbe@kernel.org,
chuck.lever@oracle.com, hawk@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink
Date: Thu, 19 Mar 2026 13:18:43 -0700 [thread overview]
Message-ID: <20260319131843.65de0c2d@kernel.org> (raw)
In-Reply-To: <2e4a7b45-8029-425e-8b86-9f3031bd081e@bootlin.com>
On Thu, 19 Mar 2026 20:56:46 +0100 Maxime Chevallier wrote:
> > for_each_netdev_dump(net, netdev, state->ifindex) {
> > + /* Either the provided ifindex doesn't exist or done dumping */
> > + if (ifindex_attr &&
> > + netdev->ifindex != nla_get_u32(ifindex_attr))
> > + break;
>
> If the passed ifindex doesn't exist, isn't netdev NULL here ?
The for_each will give us the next netdev after or not enter the loop
at all. (the selftest in patch 2 does cover this case FWIW)
next prev parent reply other threads:[~2026-03-19 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 3:56 [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink Jakub Kicinski
2026-03-19 3:56 ` [PATCH net-next 2/2] selftests: net: add tests for filtered dumps of page pool Jakub Kicinski
2026-03-19 14:14 ` Paolo Abeni
2026-03-19 19:56 ` [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink Maxime Chevallier
2026-03-19 20:18 ` Jakub Kicinski [this message]
2026-03-19 21:04 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319131843.65de0c2d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox