[PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink

[PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink

[Jakub Kicinski]

NIPA tries to make sure that HW tests don't modify system state.
It saves the state of page pools, too. Now that I write this commit
message I realize that this is impractical since page pool IDs and
state will get legitimately changed by the tests. But I already
spent a couple of hours implementing the filtering, so..

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 Documentation/netlink/specs/netdev.yaml |  6 ++++
 net/core/netdev-genl-gen.c              | 30 ++++++++++++----
 net/core/page_pool_user.c               | 47 +++++++++++++++++++++++--
 3 files changed, 74 insertions(+), 9 deletions(-)

diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index 596c306ce52b..f998cc64323c 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -620,6 +620,9 @@ doc: >-
             - dmabuf
             - io-uring
       dump:
+        request:
+          attributes:
+            - ifindex
         reply: *pp-reply
       config-cond: page-pool
     -
@@ -663,6 +666,9 @@ doc: >-
             - recycle-ring-full
             - recycle-released-refcnt
       dump:
+        request:
+          attributes:
+            - info
         reply: *pp-stats-reply
       config-cond: page-pool-stats
     -
diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c
index ba673e81716f..22cbbdc40c6a 100644
--- a/net/core/netdev-genl-gen.c
+++ b/net/core/netdev-genl-gen.c
@@ -48,6 +48,11 @@ static const struct nla_policy netdev_dev_get_nl_policy[NETDEV_A_DEV_IFINDEX + 1
 static const struct nla_policy netdev_page_pool_get_nl_policy[NETDEV_A_PAGE_POOL_ID + 1] = {
 	[NETDEV_A_PAGE_POOL_ID] = NLA_POLICY_FULL_RANGE(NLA_UINT, &netdev_a_page_pool_id_range),
 };
+
+/* NETDEV_CMD_PAGE_POOL_GET - dump */
+static const struct nla_policy netdev_page_pool_get_dump_nl_policy[NETDEV_A_PAGE_POOL_IFINDEX + 1] = {
+	[NETDEV_A_PAGE_POOL_IFINDEX] = NLA_POLICY_FULL_RANGE(NLA_U32, &netdev_a_page_pool_ifindex_range),
+};
 #endif /* CONFIG_PAGE_POOL */
 
 /* NETDEV_CMD_PAGE_POOL_STATS_GET - do */
@@ -55,6 +60,15 @@ static const struct nla_policy netdev_page_pool_get_nl_policy[NETDEV_A_PAGE_POOL
 static const struct nla_policy netdev_page_pool_stats_get_nl_policy[NETDEV_A_PAGE_POOL_STATS_INFO + 1] = {
 	[NETDEV_A_PAGE_POOL_STATS_INFO] = NLA_POLICY_NESTED(netdev_page_pool_info_nl_policy),
 };
+
+/* NETDEV_CMD_PAGE_POOL_STATS_GET - dump */
+static const struct nla_policy netdev_page_pool_stats_get_dump_info_nl_policy[NETDEV_A_PAGE_POOL_IFINDEX + 1] = {
+	[NETDEV_A_PAGE_POOL_IFINDEX] = NLA_POLICY_FULL_RANGE(NLA_U32, &netdev_a_page_pool_ifindex_range),
+};
+
+static const struct nla_policy netdev_page_pool_stats_get_dump_nl_policy[NETDEV_A_PAGE_POOL_STATS_INFO + 1] = {
+	[NETDEV_A_PAGE_POOL_STATS_INFO] = NLA_POLICY_NESTED(netdev_page_pool_stats_get_dump_info_nl_policy),
+};
 #endif /* CONFIG_PAGE_POOL_STATS */
 
 /* NETDEV_CMD_QUEUE_GET - do */
@@ -130,9 +144,11 @@ static const struct genl_split_ops netdev_nl_ops[] = {
 		.flags		= GENL_CMD_CAP_DO,
 	},
 	{
-		.cmd	= NETDEV_CMD_PAGE_POOL_GET,
-		.dumpit	= netdev_nl_page_pool_get_dumpit,
-		.flags	= GENL_CMD_CAP_DUMP,
+		.cmd		= NETDEV_CMD_PAGE_POOL_GET,
+		.dumpit		= netdev_nl_page_pool_get_dumpit,
+		.policy		= netdev_page_pool_get_dump_nl_policy,
+		.maxattr	= NETDEV_A_PAGE_POOL_IFINDEX,
+		.flags		= GENL_CMD_CAP_DUMP,
 	},
 #endif /* CONFIG_PAGE_POOL */
 #ifdef CONFIG_PAGE_POOL_STATS
@@ -144,9 +160,11 @@ static const struct genl_split_ops netdev_nl_ops[] = {
 		.flags		= GENL_CMD_CAP_DO,
 	},
 	{
-		.cmd	= NETDEV_CMD_PAGE_POOL_STATS_GET,
-		.dumpit	= netdev_nl_page_pool_stats_get_dumpit,
-		.flags	= GENL_CMD_CAP_DUMP,
+		.cmd		= NETDEV_CMD_PAGE_POOL_STATS_GET,
+		.dumpit		= netdev_nl_page_pool_stats_get_dumpit,
+		.policy		= netdev_page_pool_stats_get_dump_nl_policy,
+		.maxattr	= NETDEV_A_PAGE_POOL_STATS_INFO,
+		.flags		= GENL_CMD_CAP_DUMP,
 	},
 #endif /* CONFIG_PAGE_POOL_STATS */
 	{
diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c
index ee5060d8eec0..01509d1b3cba 100644
--- a/net/core/page_pool_user.c
+++ b/net/core/page_pool_user.c
@@ -79,7 +79,7 @@ struct page_pool_dump_cb {
 
 static int
 netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb,
-			     pp_nl_fill_cb fill)
+			     pp_nl_fill_cb fill, struct nlattr *ifindex_attr)
 {
 	struct page_pool_dump_cb *state = (void *)cb->ctx;
 	const struct genl_info *info = genl_info_dump(cb);
@@ -88,9 +88,17 @@ netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb,
 	struct page_pool *pool;
 	int err = 0;
 
+	if (ifindex_attr)
+		state->ifindex = nla_get_u32(ifindex_attr);
+
 	rtnl_lock();
 	mutex_lock(&page_pools_lock);
 	for_each_netdev_dump(net, netdev, state->ifindex) {
+		/* Either the provided ifindex doesn't exist or done dumping */
+		if (ifindex_attr &&
+		    netdev->ifindex != nla_get_u32(ifindex_attr))
+			break;
+
 		hlist_for_each_entry(pool, &netdev->page_pools, user.list) {
 			if (state->pp_id && state->pp_id < pool->user.id)
 				continue;
@@ -206,10 +214,40 @@ int netdev_nl_page_pool_stats_get_doit(struct sk_buff *skb,
 	return netdev_nl_page_pool_get_do(info, id, page_pool_nl_stats_fill);
 }
 
+static const struct netlink_range_validation page_pool_ifindex_range = {
+	.min	= 1ULL,
+	.max	= S32_MAX,
+};
+
+static const struct nla_policy
+page_pool_stat_info_policy[NETDEV_A_PAGE_POOL_IFINDEX + 1] = {
+	[NETDEV_A_PAGE_POOL_IFINDEX] =
+		NLA_POLICY_FULL_RANGE(NLA_U32, &page_pool_ifindex_range),
+};
+
 int netdev_nl_page_pool_stats_get_dumpit(struct sk_buff *skb,
 					 struct netlink_callback *cb)
 {
-	return netdev_nl_page_pool_get_dump(skb, cb, page_pool_nl_stats_fill);
+	struct nlattr *tb[ARRAY_SIZE(page_pool_stat_info_policy)];
+	const struct genl_info *info = genl_info_dump(cb);
+	struct nlattr *ifindex_attr = NULL;
+
+	if (info->attrs[NETDEV_A_PAGE_POOL_STATS_INFO]) {
+		struct nlattr *nest;
+		int err;
+
+		nest = info->attrs[NETDEV_A_PAGE_POOL_STATS_INFO];
+		err = nla_parse_nested(tb, ARRAY_SIZE(tb) - 1, nest,
+				       page_pool_stat_info_policy,
+				       info->extack);
+		if (err)
+			return err;
+
+		ifindex_attr = tb[NETDEV_A_PAGE_POOL_IFINDEX];
+	}
+
+	return netdev_nl_page_pool_get_dump(skb, cb, page_pool_nl_stats_fill,
+					    ifindex_attr);
 }
 
 static int
@@ -305,7 +343,10 @@ int netdev_nl_page_pool_get_doit(struct sk_buff *skb, struct genl_info *info)
 int netdev_nl_page_pool_get_dumpit(struct sk_buff *skb,
 				   struct netlink_callback *cb)
 {
-	return netdev_nl_page_pool_get_dump(skb, cb, page_pool_nl_fill);
+	const struct genl_info *info = genl_info_dump(cb);
+
+	return netdev_nl_page_pool_get_dump(skb, cb, page_pool_nl_fill,
+					    info->attrs[NETDEV_A_PAGE_POOL_IFINDEX]);
 }
 
 int page_pool_list(struct page_pool *pool)
-- 
2.53.0

[PATCH net-next 2/2] selftests: net: add tests for filtered dumps of page pool

[Jakub Kicinski]

Add tests for page pool dumps of a specific ifindex.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 tools/testing/selftests/net/nl_netdev.py | 119 ++++++++++++++++++++++-
 1 file changed, 117 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/nl_netdev.py b/tools/testing/selftests/net/nl_netdev.py
index eff55c64a012..ceb44c8e1fec 100755
--- a/tools/testing/selftests/net/nl_netdev.py
+++ b/tools/testing/selftests/net/nl_netdev.py
@@ -9,7 +9,7 @@ import errno
 from os import system
 from lib.py import ksft_run, ksft_exit
 from lib.py import ksft_eq, ksft_ge, ksft_ne, ksft_raises, ksft_busy_wait
-from lib.py import NetdevFamily, NetdevSimDev, NlError, ip
+from lib.py import NetdevFamily, NetdevSimDev, NlError, defer, ip
 
 
 def empty_check(nf) -> None:
@@ -255,6 +255,117 @@ from lib.py import NetdevFamily, NetdevSimDev, NlError, ip
         nsim.dfs_write("pp_hold", "y")
 
 
+def page_pool_dump_ifindex(nf) -> None:
+    """Test page pool dump filtering by ifindex."""
+    nsimdev1 = NetdevSimDev(queue_count=3)
+    rm_nsim1 = defer(nsimdev1.remove)
+    nsimdev2 = NetdevSimDev(queue_count=5)
+    defer(nsimdev2.remove)
+
+    nsim1 = nsimdev1.nsims[0]
+    nsim2 = nsimdev2.nsims[0]
+
+    ip(f"link set dev {nsim1.ifname} up")
+    ip(f"link set dev {nsim2.ifname} up")
+
+    # Unfiltered dump should have pools from both devices
+    all_pp = nf.page_pool_get({}, dump=True)
+    pp1_all = [pp for pp in all_pp
+               if pp.get("ifindex") == nsim1.ifindex]
+    pp2_all = [pp for pp in all_pp
+               if pp.get("ifindex") == nsim2.ifindex]
+    ksft_ge(len(pp1_all), 1)
+    ksft_ge(len(pp2_all), 1)
+
+    # Filtered dump should only return pools for that device
+    pp1_flt = nf.page_pool_get({'ifindex': nsim1.ifindex}, dump=True)
+    ksft_eq(pp1_flt, pp1_all)
+
+    pp2_flt = nf.page_pool_get({'ifindex': nsim2.ifindex}, dump=True)
+    ksft_eq(pp2_flt, pp2_all)
+
+    # Non-existent ifindex should return empty dump
+    pp_none = nf.page_pool_get({'ifindex': 12345678}, dump=True)
+    ksft_eq(len(pp_none), 0)
+
+    # Device down - no pools for that ifindex
+    ip(f"link set dev {nsim1.ifname} down")
+    pp1_down = nf.page_pool_get({'ifindex': nsim1.ifindex}, dump=True)
+    ksft_eq(len(pp1_down), 0)
+
+    # Remove device, dump by its old ifindex should return empty
+    old_ifindex = nsim1.ifindex
+    rm_nsim1.exec()
+    pp1_gone = nf.page_pool_get({'ifindex': old_ifindex}, dump=True)
+    ksft_eq(len(pp1_gone), 0)
+
+
+def page_pool_ifindex_leak_check(nf) -> None:
+    """Test that zombie page pools don't show up under the original ifindex."""
+    nsimdev = NetdevSimDev()
+    rm_nsim = defer(nsimdev.remove)
+    nsim = nsimdev.nsims[0]
+
+    ip(f"link set dev {nsim.ifname} up")
+    nsim.dfs_write("pp_hold", "y")
+
+    pp_up = nf.page_pool_get({'ifindex': nsim.ifindex}, dump=True)
+    ksft_ge(len(pp_up), 1)
+
+    # Remove device with leaked page - pool becomes zombie (orphaned to lo)
+    old_ifindex = nsim.ifindex
+    rm_nsim.exec()
+
+    # Zombie pool should NOT appear under the original device
+    pp_down = nf.page_pool_get({'ifindex': old_ifindex}, dump=True)
+    ksft_eq(len(pp_down), 0)
+
+    # But it should appear in an unfiltered dump (under loopback)
+    pp_all = nf.page_pool_get({}, dump=True)
+    orphans = [pp for pp in pp_all
+               if "detach-time" in pp and "ifindex" not in pp]
+    ksft_ge(len(orphans), 1)
+
+
+def page_pool_stats_ifindex_check(nf) -> None:
+    """Test page pool stats dump filtering by ifindex."""
+    nsimdev1 = NetdevSimDev(queue_count=3)
+    defer(nsimdev1.remove)
+    nsimdev2 = NetdevSimDev(queue_count=5)
+    defer(nsimdev2.remove)
+
+    nsim1 = nsimdev1.nsims[0]
+    nsim2 = nsimdev2.nsims[0]
+
+    ip(f"link set dev {nsim1.ifname} up")
+    ip(f"link set dev {nsim2.ifname} up")
+
+    # Unfiltered stats dump
+    all_stats = nf.page_pool_stats_get({}, dump=True)
+    s1_all = [s for s in all_stats
+              if s.get("info", {}).get("ifindex") == nsim1.ifindex]
+    s2_all = [s for s in all_stats
+              if s.get("info", {}).get("ifindex") == nsim2.ifindex]
+    ksft_ge(len(s1_all), 1)
+    ksft_ge(len(s2_all), 1)
+
+    # Filtered stats dump
+    s1_flt = nf.page_pool_stats_get({'info': {'ifindex': nsim1.ifindex}},
+                                    dump=True)
+    ksft_eq(s1_flt, s1_all)
+
+    # Non-existent ifindex should return empty
+    s_none = nf.page_pool_stats_get({'info': {'ifindex': 12345678}}, dump=True)
+    ksft_eq(len(s_none), 0)
+
+    # info.id should be rejected for stats dump
+    with ksft_raises(NlError) as cm:
+        nf.page_pool_stats_get({'info': {'id': s1_all[0]['info']['id']}},
+                               dump=True)
+    ksft_eq(cm.exception.nl_msg.error, -errno.EINVAL)
+    ksft_eq(cm.exception.nl_msg.extack['bad-attr'], '.info.id')
+
+
 def main() -> None:
     """ Ksft boiler plate main """
     nf = NetdevFamily()
@@ -265,7 +376,11 @@ from lib.py import NetdevFamily, NetdevSimDev, NlError, ip
               napi_set_threaded,
               dev_set_threaded,
               nsim_rxq_reset_down,
-              page_pool_check],
+              page_pool_check,
+              page_pool_dump_ifindex,
+              page_pool_ifindex_leak_check,
+              page_pool_stats_ifindex_check
+              ],
              args=(nf, ))
     ksft_exit()
 
-- 
2.53.0

Re: [PATCH net-next 2/2] selftests: net: add tests for filtered dumps of page pool

[Paolo Abeni]

On 3/19/26 4:56 AM, Jakub Kicinski wrote:
> Add tests for page pool dumps of a specific ifindex.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  tools/testing/selftests/net/nl_netdev.py | 119 ++++++++++++++++++++++-
>  1 file changed, 117 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/nl_netdev.py b/tools/testing/selftests/net/nl_netdev.py
> index eff55c64a012..ceb44c8e1fec 100755
> --- a/tools/testing/selftests/net/nl_netdev.py
> +++ b/tools/testing/selftests/net/nl_netdev.py
> @@ -9,7 +9,7 @@ import errno
>  from os import system
>  from lib.py import ksft_run, ksft_exit
>  from lib.py import ksft_eq, ksft_ge, ksft_ne, ksft_raises, ksft_busy_wait
> -from lib.py import NetdevFamily, NetdevSimDev, NlError, ip
> +from lib.py import NetdevFamily, NetdevSimDev, NlError, defer, ip
>  
>  
>  def empty_check(nf) -> None:
> @@ -255,6 +255,117 @@ from lib.py import NetdevFamily, NetdevSimDev, NlError, ip
>          nsim.dfs_write("pp_hold", "y")
>  
>  
> +def page_pool_dump_ifindex(nf) -> None:
> +    """Test page pool dump filtering by ifindex."""
> +    nsimdev1 = NetdevSimDev(queue_count=3)
> +    rm_nsim1 = defer(nsimdev1.remove)
> +    nsimdev2 = NetdevSimDev(queue_count=5)
> +    defer(nsimdev2.remove)
> +
> +    nsim1 = nsimdev1.nsims[0]
> +    nsim2 = nsimdev2.nsims[0]
> +
> +    ip(f"link set dev {nsim1.ifname} up")
> +    ip(f"link set dev {nsim2.ifname} up")
> +
> +    # Unfiltered dump should have pools from both devices
> +    all_pp = nf.page_pool_get({}, dump=True)
> +    pp1_all = [pp for pp in all_pp
> +               if pp.get("ifindex") == nsim1.ifindex]
> +    pp2_all = [pp for pp in all_pp
> +               if pp.get("ifindex") == nsim2.ifindex]
> +    ksft_ge(len(pp1_all), 1)
> +    ksft_ge(len(pp2_all), 1)
> +
> +    # Filtered dump should only return pools for that device
> +    pp1_flt = nf.page_pool_get({'ifindex': nsim1.ifindex}, dump=True)
> +    ksft_eq(pp1_flt, pp1_all)
> +
> +    pp2_flt = nf.page_pool_get({'ifindex': nsim2.ifindex}, dump=True)
> +    ksft_eq(pp2_flt, pp2_all)
> +
> +    # Non-existent ifindex should return empty dump
> +    pp_none = nf.page_pool_get({'ifindex': 12345678}, dump=True)
> +    ksft_eq(len(pp_none), 0)
> +
> +    # Device down - no pools for that ifindex
> +    ip(f"link set dev {nsim1.ifname} down")
> +    pp1_down = nf.page_pool_get({'ifindex': nsim1.ifindex}, dump=True)
> +    ksft_eq(len(pp1_down), 0)
> +
> +    # Remove device, dump by its old ifindex should return empty
> +    old_ifindex = nsim1.ifindex
> +    rm_nsim1.exec()
> +    pp1_gone = nf.page_pool_get({'ifindex': old_ifindex}, dump=True)
> +    ksft_eq(len(pp1_gone), 0)
> +
> +
> +def page_pool_ifindex_leak_check(nf) -> None:
> +    """Test that zombie page pools don't show up under the original ifindex."""
> +    nsimdev = NetdevSimDev()
> +    rm_nsim = defer(nsimdev.remove)
> +    nsim = nsimdev.nsims[0]
> +
> +    ip(f"link set dev {nsim.ifname} up")
> +    nsim.dfs_write("pp_hold", "y")
> +
> +    pp_up = nf.page_pool_get({'ifindex': nsim.ifindex}, dump=True)
> +    ksft_ge(len(pp_up), 1)
> +
> +    # Remove device with leaked page - pool becomes zombie (orphaned to lo)
> +    old_ifindex = nsim.ifindex
> +    rm_nsim.exec()
> +
> +    # Zombie pool should NOT appear under the original device
> +    pp_down = nf.page_pool_get({'ifindex': old_ifindex}, dump=True)
> +    ksft_eq(len(pp_down), 0)
> +
> +    # But it should appear in an unfiltered dump (under loopback)
> +    pp_all = nf.page_pool_get({}, dump=True)
> +    orphans = [pp for pp in pp_all
> +               if "detach-time" in pp and "ifindex" not in pp]
> +    ksft_ge(len(orphans), 1)
> +
> +
> +def page_pool_stats_ifindex_check(nf) -> None:
> +    """Test page pool stats dump filtering by ifindex."""
> +    nsimdev1 = NetdevSimDev(queue_count=3)
> +    defer(nsimdev1.remove)
> +    nsimdev2 = NetdevSimDev(queue_count=5)
> +    defer(nsimdev2.remove)
> +
> +    nsim1 = nsimdev1.nsims[0]
> +    nsim2 = nsimdev2.nsims[0]
> +
> +    ip(f"link set dev {nsim1.ifname} up")
> +    ip(f"link set dev {nsim2.ifname} up")
> +
> +    # Unfiltered stats dump
> +    all_stats = nf.page_pool_stats_get({}, dump=True)
> +    s1_all = [s for s in all_stats
> +              if s.get("info", {}).get("ifindex") == nsim1.ifindex]
> +    s2_all = [s for s in all_stats
> +              if s.get("info", {}).get("ifindex") == nsim2.ifindex]
> +    ksft_ge(len(s1_all), 1)
> +    ksft_ge(len(s2_all), 1)
> +
> +    # Filtered stats dump
> +    s1_flt = nf.page_pool_stats_get({'info': {'ifindex': nsim1.ifindex}},
> +                                    dump=True)
> +    ksft_eq(s1_flt, s1_all)
> +
> +    # Non-existent ifindex should return empty
> +    s_none = nf.page_pool_stats_get({'info': {'ifindex': 12345678}}, dump=True)
> +    ksft_eq(len(s_none), 0)
> +
> +    # info.id should be rejected for stats dump
> +    with ksft_raises(NlError) as cm:
> +        nf.page_pool_stats_get({'info': {'id': s1_all[0]['info']['id']}},
> +                               dump=True)
> +    ksft_eq(cm.exception.nl_msg.error, -errno.EINVAL)
> +    ksft_eq(cm.exception.nl_msg.extack['bad-attr'], '.info.id')
> +
> +
>  def main() -> None:
>      """ Ksft boiler plate main """
>      nf = NetdevFamily()
> @@ -265,7 +376,11 @@ from lib.py import NetdevFamily, NetdevSimDev, NlError, ip
>                napi_set_threaded,
>                dev_set_threaded,
>                nsim_rxq_reset_down,
> -              page_pool_check],
> +              page_pool_check,
> +              page_pool_dump_ifindex,
> +              page_pool_ifindex_leak_check,
> +              page_pool_stats_ifindex_check

It looks like the new selftests are consistently failing?!?

# 5.79 [+0.24] ok 10 nl_netdev.page_pool_ifindex_leak_check
# 6.21 [+0.42] # Exception| Traceback (most recent call last):
# 6.22 [+0.00] # Exception|   File
"/srv/vmksft/testing/wt-2/tools/testing/selftests/net/lib/py/ksft.py",
line 338, in ksft_run
# 6.23 [+0.01] # Exception|     func(*args)
# 6.23 [+0.00] # Exception|     ~~~~^^^^^^^
# 6.23 [+0.00] # Exception|   File
"/srv/vmksft/testing/wt-2/tools/testing/selftests/net/./nl_netdev.py",
line 344, in page_pool_stats_ifindex_check
# 6.25 [+0.02] # Exception|     all_stats = nf.page_pool_stats_get({},
dump=True)
# 6.25 [+0.00] # Exception|   File
"/srv/vmksft/testing/wt-2/tools/net/ynl/pyynl/lib/ynl.py", line 1385, in _op
# 6.26 [+0.01] # Exception|     return self._ops(ops)[0]
# 6.26 [+0.00] # Exception|            ~~~~~~~~~^^^^^
# 6.26 [+0.00] # Exception|   File
"/srv/vmksft/testing/wt-2/tools/net/ynl/pyynl/lib/ynl.py", line 1342, in
_ops
# 6.27 [+0.01] # Exception|     raise NlError(nl_msg)
# 6.27 [+0.00] # Exception| net.ynl.pyynl.lib.ynl.NlError: Netlink
error: Operation not supported
# 6.28 [+0.01] # Exception|
# 6.32 [+0.04] not ok 11 nl_netdev.page_pool_stats_ifindex_check
# 6.32 [+0.00] # Totals: pass:10 fail:1 xfail:0 xpass:0 skip:0 error:0
not ok 1 selftests: net: nl_netdev.py # exit=1

Re: [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink

[Maxime Chevallier]

Hi Jakub,

On 19/03/2026 04:56, Jakub Kicinski wrote:
> NIPA tries to make sure that HW tests don't modify system state.
> It saves the state of page pools, too. Now that I write this commit
> message I realize that this is impractical since page pool IDs and
> state will get legitimately changed by the tests. But I already
> spent a couple of hours implementing the filtering, so..
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

[...]

> diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c
> index ee5060d8eec0..01509d1b3cba 100644
> --- a/net/core/page_pool_user.c
> +++ b/net/core/page_pool_user.c
> @@ -79,7 +79,7 @@ struct page_pool_dump_cb {
>  
>  static int
>  netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb,
> -			     pp_nl_fill_cb fill)
> +			     pp_nl_fill_cb fill, struct nlattr *ifindex_attr)
>  {
>  	struct page_pool_dump_cb *state = (void *)cb->ctx;
>  	const struct genl_info *info = genl_info_dump(cb);
> @@ -88,9 +88,17 @@ netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb,
>  	struct page_pool *pool;
>  	int err = 0;
>  
> +	if (ifindex_attr)
> +		state->ifindex = nla_get_u32(ifindex_attr);
> +
>  	rtnl_lock();
>  	mutex_lock(&page_pools_lock);
>  	for_each_netdev_dump(net, netdev, state->ifindex) {
> +		/* Either the provided ifindex doesn't exist or done dumping */
> +		if (ifindex_attr &&
> +		    netdev->ifindex != nla_get_u32(ifindex_attr))
> +			break;

If the passed ifindex doesn't exist, isn't netdev NULL here ?

Maxime

Re: [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink

[Jakub Kicinski]

On Thu, 19 Mar 2026 20:56:46 +0100 Maxime Chevallier wrote:
> >  	for_each_netdev_dump(net, netdev, state->ifindex) {
> > +		/* Either the provided ifindex doesn't exist or done dumping */
> > +		if (ifindex_attr &&
> > +		    netdev->ifindex != nla_get_u32(ifindex_attr))
> > +			break;  
> 
> If the passed ifindex doesn't exist, isn't netdev NULL here ?

The for_each will give us the next netdev after or not enter the loop
at all. (the selftest in patch 2 does cover this case FWIW)

Re: [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink

[Maxime Chevallier]

On 19/03/2026 21:18, Jakub Kicinski wrote:
> On Thu, 19 Mar 2026 20:56:46 +0100 Maxime Chevallier wrote:
>>>  	for_each_netdev_dump(net, netdev, state->ifindex) {
>>> +		/* Either the provided ifindex doesn't exist or done dumping */
>>> +		if (ifindex_attr &&
>>> +		    netdev->ifindex != nla_get_u32(ifindex_attr))
>>> +			break;  
>>
>> If the passed ifindex doesn't exist, isn't netdev NULL here ?
> 
> The for_each will give us the next netdev after or not enter the loop
> at all. (the selftest in patch 2 does cover this case FWIW)

Ah I missed the loop skipping step. I like that construct then, wish I'd
thought of that with the ethnl phy dumpit stuff, I may take inspiration
here as it avoids treating filtered and non-filtered dumps differently.

Sorry for the noise then,

Maxime