From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E06683815CD for ; Thu, 19 Mar 2026 13:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773927629; cv=none; b=WeutoacU0hvvoqb6ydy0HWjb2tYb0nZHCIry5rp2W2wjfPo+u0zc23Q3IqCGCUeWgOrDpLPtQyWrKprnKom3ApqY/GUOIs6qz0D8MMsV+BIDKwI1yHVlD23+PHeSykcKl1Ia07V4Ka4E6PG7C4mtUut+pQNCrMYk+CsuzG2vF7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773927629; c=relaxed/simple; bh=9RFlBLdsLvwTMSO52ss9gXIOFrdI16jqMnmaf5txACo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lHzYskloGWAhq5Q7kk3bsTbfhHP5ivYDTDfRBD9M5QMBpngtYAw1baHdlknnjdiEVttSasK+qhvFQsTjbwMd7dxk9vXx3PfT0A9+rxkNaVWqjZkztCRz7b4blrNxWRF4bH9bbtTsIQ97FrNsWdCNwIrn/DWW8nZOpULl3Y2lW1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K5S/awp5; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K5S/awp5" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82995242934so963747b3a.0 for ; Thu, 19 Mar 2026 06:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773927627; x=1774532427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fk/YPao5MB3kYudLAhqn3ZbQm43GFyzl9r3q1s3aJCk=; b=K5S/awp5K6nOIoo1/YymCrJux18cUBrHcli/tPYdTjh7LRibzvxxV+NyezQxZUtXgU oQZW0C6FOwr/p0pkN/lo//TmVPZOz2D7oNNJi4XlDdalpO/+4+XQAiSfcLpjgDA0IBM+ ith3q5HE2mAI61M41lp2RJuTq70P7+oV4ZfyBxOxS4CTsG4Gn1ztJmtMBF05/7wCpYGi 2qQ+0D65bmeXW/kiZFjZHzi6hzUQKMNHPOSp+N7H+ZOJXVvs9NQlADnHBJk5rQuEWqNN yxH5FCJw+K0TdimqXm82F0AFJkrzbXM2TSQ3NDswF15N6ICQOVhQ52+3PS2Yh7tUEJKa WRbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773927627; x=1774532427; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fk/YPao5MB3kYudLAhqn3ZbQm43GFyzl9r3q1s3aJCk=; b=c3C1pTpGVxzKXaAY6RVbLxA7VMvmsI9PlEvTsalx0HU9AFoHJIMU8gBzVuTprUdUr7 OVs4cFX0ojSRFTj+4Q578bxMuvlnUGRmmNswhsQZcvMF091Mbn4xTCOL7ltZhb7i8f2k xr63YZVcMFph+lKAYjQz5BLBW7d4obDL6dtQ5QEbmCGf7XMXw2LiJ3uAB4f6n5C2oDEk I6nXlAgDwPzlwpp2D1ncbXsAzYcGM9/20bBM8cXFGkEBsoVKy8FbWFX/t7pFPc29aYLd 0myRKtlI++YP7N+b4BIUfPVpNDlbouCX4hyHXEy3eD3TMbFeD/dtYoF71w9UFQud33m5 kO7g== X-Forwarded-Encrypted: i=1; AJvYcCUU3NqoTupet6rkNxvSsdIHjarhQFB9Lo3Di5Gw88cTlbqcoPeNMszTLYYyOq1R4eIhztuVLQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxTizWDojaV6J9x57BP0ocA5QNVOv6bU1iznitm3BZx1xu9DjY/ m8a8oYzsT6j0k2617WJgdN4ro3tHJ1B9IBjDn8B9z9/ckbN21GkohMHv X-Gm-Gg: ATEYQzyIDpb8TYf7o91LtGD4IHad+Zj3iXvXDVi0YkI4Vvkv+epiAooTex3XaCjQYnx kG5n3owcUAVfUdvrUHf/5FmqS0iQTEwssndEVpWWSkoRWXoSHz5SY0L5Ax+brBUcwpwqRXO7tOr 6cmeGYDBM1lKlVjDYkxbZxPLJA7xSVIWPPjv0W2tKKnLME5gDIlyN9AI74fWJD+aVje38+hhYkz AAhevwQelvKIk31RoMRzm3+wIN6pa+ZiGewHij9j9Aq4amPluhpWcLt8LWtpT6UOXCLsyyasy2m KWhM1CQdkAT50+8IXwIhig2bb8FPhjNEUVSep8WIE8eltsaoTaCT/mISIxxdFY7ljzplHJACGFH xITgJicLY7NcWW8Z4JApHd7lGMJhHJRlr+B/aGsxjgfRyWiilW5R3MjHO7KKzTB4NcELYww/kle odOnGsSiOdV+MVWg== X-Received: by 2002:a05:6a00:1256:b0:81f:5a94:dc2f with SMTP id d2e1a72fcca58-82a7a9827c9mr2712844b3a.35.1773927627233; Thu, 19 Mar 2026 06:40:27 -0700 (PDT) Received: from lgs.. ([103.86.77.131]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bee89d5sm6007465b3a.51.2026.03.19.06.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 06:40:26 -0700 (PDT) From: Guangshuo Li To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Madhu Chittim , Joshua Hay , Tatyana Nikolova , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org, Paul Menzel , Aleksandr Loktionov Subject: [PATCH v2] idpf: fix UAF and double free in idpf_plug_core_aux_dev() error path Date: Thu, 19 Mar 2026 21:40:10 +0800 Message-ID: <20260319134010.684107-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If auxiliary_device_add() fails, idpf_plug_core_aux_dev() calls auxiliary_device_uninit(adev), whose release callback idpf_core_adev_release() frees the containing struct iidc_rdma_core_auxiliary_dev. The current error path then accesses adev->id and later frees iadev again, which may lead to a use-after-free and double free. Fix it by storing the allocated auxiliary device id in a local variable and avoiding direct freeing of iadev after auxiliary_device_uninit(). Fixes: f4312e6bfa2a ("idpf: implement core RDMA auxiliary dev create, init, and destroy") Cc: stable@vger.kernel.org Reviewed-by: Paul Menzel Reviewed-by: Aleksandr Loktionov Signed-off-by: Guangshuo Li --- v2: - Rename id to adev_id as suggested by Paul drivers/net/ethernet/intel/idpf/idpf_idc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c index 6dad0593f7f2..3152f4530347 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c @@ -197,6 +197,7 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core_dev_info *cdev_info) char name[IDPF_IDC_MAX_ADEV_NAME_LEN]; struct auxiliary_device *adev; int ret; + int adev_id; iadev = kzalloc(sizeof(*iadev), GFP_KERNEL); if (!iadev) @@ -211,11 +212,15 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core_dev_info *cdev_info) pr_err("failed to allocate unique device ID for Auxiliary driver\n"); goto err_ida_alloc; } - adev->id = ret; + adev_id = ret; + adev->id = adev_id; + adev->dev.release = idpf_core_adev_release; adev->dev.parent = &cdev_info->pdev->dev; sprintf(name, "%04x.rdma.core", cdev_info->pdev->vendor); adev->name = name; + /* iadev is owned by the auxiliary device */ + iadev = NULL; ret = auxiliary_device_init(adev); if (ret) @@ -230,7 +235,7 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core_dev_info *cdev_info) err_aux_dev_add: auxiliary_device_uninit(adev); err_aux_dev_init: - ida_free(&idpf_idc_ida, adev->id); + ida_free(&idpf_idc_ida, adev_id); err_ida_alloc: cdev_info->adev = NULL; kfree(iadev); -- 2.43.0