From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F848361645 for ; Thu, 19 Mar 2026 14:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929943; cv=none; b=R7zbLsbJ3wKDA8wCmlnULL4Ady7Sc/R0LD/+bqZoTQJHnJ6wp8HoRPgbCpQKhYDmG36UudkSMcCjuHDk6RPTlqA6+biv8XX08fXtKr6PlpAxgEfCjYPPA9v7zS6xZQXqv2dF5oOrfVJF+s8uW1kIiy7J3qsK8raN7VNQjd0Ok9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929943; c=relaxed/simple; bh=Bj04iTXB7MhKSrOnlUvWs1/LZRy/U40aj1lrebnr4kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pH1FCRQgbpTYQ5f7Eg17HXz8RmM7mtqJpPGt0rjJox2Pi0v4c4ymBbPnHdei8O07u1AgrHzS+7FfEADfw6uFzcsPmbul/iIWi1XUBxKzAfGwUL8EuByBrmqjRHXrqatjoQ4DvB6XBWTNxRG5FYUwgLCwgSs00xsCJj2fJbry9/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R81D17Cd; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R81D17Cd" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3591cc98871so347731a91.3 for ; Thu, 19 Mar 2026 07:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773929942; x=1774534742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=R81D17CdNHfsMNlMgTTSiDVNzGT4uUxmExPFqk3TUP6Y9NUw9Mv1LvneXLDnPsaefG nh1FpnsAMLu+Oq1wqTiVQgbkdwnH/TD2afQEMBNo/qAUhz1J2gT3bcZcmUedPXBveMzU MVxeZ8QYAH5G4Z+NlY/mnZK6D6xbQyYRQW9F0XTZVodLh95X7VJJP3TKh7QlUvMDvmBJ 5Q1VairZ1Jruodd++GeGk3A9f+XvBGe/bm5Eh+bj1uj3p9sKKZ5OLQOYjnkFeeLBSWon WNBGr9wN4F6YvR2YhIVMML9R62jjECS+T+xoQ2qdqmDx8XmPVjKcwj7sGlQDwPoNuo0J vxgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773929942; x=1774534742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=f3zyNCnwAdPjBFEqCQhiQ3qe7sATOV0jHy5vWo+U6C9PKVz/4TogMsSRdRuTy4kkG0 74Xgkyjg/lGXLXPuoeeyWOAi8nBAsbB7X+ohBNmyS6Urc59YL6rfkhwD59cAQqTWOI2c LZ36njz7pI/m8uhCQ2ajqF08qmhUf9gkoNm+4CYy/tmk4PzpHmZ2pnBOKSFNOCCIJFQA lNsBxg/N/ZVm6gHo2SHmityNWIhuCPiwH6NJKztk6+e13yJ26q41iq24/35jcpPh19d0 dyae3Q3nY365t+E39VU7GzvXH0EUJ1Lp21Z0vQReT7KIJAYBwOt6lRyPG7jwXFZp95CA mWjA== X-Gm-Message-State: AOJu0YzNrVZitNZJHTVkPdnU9b3FKPxwPRkWboJb4rI5mMHleGiEVaBg zzBKkHdr23xpS29hSgE4VwK72tJtkU+Or9XtWctgSZQxeFqt7OdUqb21 X-Gm-Gg: ATEYQzyo858JgJHAskVr5UfgjTZjDR4jZhAaOrMVFAXF9PEuxCImJmUc+R+gUakGQQl gYL3F1uNGBhBMxGEOJYqjfYb2wQMaNwlJgkbCjS/X8u7/KXPajWGajsCdYI5TNEw06ZZE0w8i8A E/zAT6nax1MW84jsuAKvGJfyfp+SGr5Lt3IcpYlXptQK3NkREJMHcT9K3aNrN/o8TY+cX+crT0v 2d5v4PA9+lUXoH50ltDU97TCynuvoJmNrM8TWPO1OMZNwDzW+WThByGR1fEmMU4D3lFJtuyIaBA 9XqhTcjjLALvNlCe5ybuth8qvjja3eHPeHjK7MytEoXCQA/pB1yb0Ny39TSadbnIfwk4O3Sw4oH xjVZ+Ym5KVXys7LADlxt8v/VTHCH32VAhoEN9Z40VZ7bCasJXXBdIN1nSsSeb3C2oNcuX7j/nKF UBPSKAHfTDal/6Ufph5xdQLHI0Ji0y+kxYdVOAUfebntvS8qoVePWTJ+JeIJmB/7LyuKK8+nPWm HB/q4mdAQ== X-Received: by 2002:a17:90a:d604:b0:35a:24f3:2c88 with SMTP id 98e67ed59e1d1-35bb9e579c5mr6654313a91.8.1773929941824; Thu, 19 Mar 2026 07:19:01 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bc63286ebsm2695321a91.17.2026.03.19.07.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 07:19:01 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v3 2/3] svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Date: Thu, 19 Mar 2026 22:18:45 +0800 Message-Id: <20260319141846.78222-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260319141846.78222-1-seanwascoding@gmail.com> References: <20260319141846.78222-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards in svc_rdma_accept(). Since dprintk() already evaluates to a no-op (via no_printk) when debugging is disabled, these explicit guards are unnecessary. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like 'sap' in this case) are declared outside of #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within dprintk(). Signed-off-by: Sean Chang --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 25 +++++++++++------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index f2d72181a6fe..0759444bda50 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -413,6 +413,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) struct rpcrdma_connect_private pmsg; struct ib_qp_init_attr qp_attr; struct ib_device *dev; + struct sockaddr *sap; int ret = 0; listen_rdma = container_of(xprt, struct svcxprt_rdma, sc_xprt); @@ -559,20 +560,16 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) goto errout; } - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - struct sockaddr *sap; - - dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); - sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; - dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); - sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; - dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); - dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); - dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); - dprintk(" rdma_rw_ctxs : %d\n", ctxts); - dprintk(" max_requests : %d\n", newxprt->sc_max_requests); - dprintk(" ord : %d\n", conn_param.initiator_depth); - } + dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); + sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; + dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); + sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; + dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); + dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); + dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); + dprintk(" rdma_rw_ctxs : %d\n", ctxts); + dprintk(" max_requests : %d\n", newxprt->sc_max_requests); + dprintk(" ord : %d\n", conn_param.initiator_depth); return &newxprt->sc_xprt; -- 2.34.1