From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
Alok Tiwari <alok.a.tiwari@oracle.com>,
Simon Horman <horms@kernel.org>,
Jeffrey Altman <jaltman@auristor.com>,
stable@kernel.org
Subject: [PATCH net 3/5] rxrpc: Fix rack timer warning to report unexpected mode
Date: Thu, 19 Mar 2026 15:01:43 +0000 [thread overview]
Message-ID: <20260319150150.4189381-4-dhowells@redhat.com> (raw)
In-Reply-To: <20260319150150.4189381-1-dhowells@redhat.com>
From: Alok Tiwari <alok.a.tiwari@oracle.com>
rxrpc_rack_timer_expired() clears call->rack_timer_mode to OFF before
the switch. The default case warning therefore always prints OFF and
doesn't identify the unexpected timer mode.
Log the saved mode value instead so the warning reports the actual
unexpected rack timer mode.
Fixes: 7c482665931b ("rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Eric Dumazet <edumazet@google.com>
cc: "David S. Miller" <davem@davemloft.net>
cc: Jakub Kicinski <kuba@kernel.org>
cc: Paolo Abeni <pabeni@redhat.com>
cc: linux-afs@lists.infradead.org
cc: netdev@vger.kernel.org
cc: stable@kernel.org
---
net/rxrpc/input_rack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/input_rack.c b/net/rxrpc/input_rack.c
index 13c371261e0a..9eb109ffba56 100644
--- a/net/rxrpc/input_rack.c
+++ b/net/rxrpc/input_rack.c
@@ -413,6 +413,6 @@ void rxrpc_rack_timer_expired(struct rxrpc_call *call, ktime_t overran_by)
break;
//case RXRPC_CALL_RACKTIMER_ZEROWIN:
default:
- pr_warn("Unexpected rack timer %u", call->rack_timer_mode);
+ pr_warn("Unexpected rack timer %u", mode);
}
}
next prev parent reply other threads:[~2026-03-19 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 15:01 [PATCH net 0/5] rxrpc: Miscellaneous fixes David Howells
2026-03-19 15:01 ` [PATCH net 1/5] rxrpc: Fix RxGK token loading to check bounds David Howells
2026-03-19 15:01 ` [PATCH net 2/5] rxrpc: Fix use of wrong skb when comparing queued RESP challenge serial David Howells
2026-03-21 1:45 ` Jakub Kicinski
2026-03-21 8:15 ` David Howells
2026-03-23 21:45 ` Jakub Kicinski
2026-03-23 21:51 ` David Howells
2026-03-23 22:11 ` Jakub Kicinski
2026-03-19 15:01 ` David Howells [this message]
2026-03-19 15:01 ` [PATCH net 4/5] rxrpc: Fix keyring reference count leak in rxrpc_setsockopt() David Howells
2026-03-19 15:01 ` [PATCH net 5/5] rxrpc: Fix key reference count leak from call->key David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319150150.4189381-4-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jaltman@auristor.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox