From: Jakub Kicinski <kuba@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [PATCH net] rtnetlink: fix leak of SRCU struct in rtnl_link_register
Date: Thu, 19 Mar 2026 17:05:41 -0700 [thread overview]
Message-ID: <20260319170541.27c75eac@kernel.org> (raw)
In-Reply-To: <5ed5489ecdd05c43bd551804f3bd020ae349f3ca.1773849195.git.sd@queasysnail.net>
On Wed, 18 Mar 2026 17:15:15 +0100 Sabrina Dubroca wrote:
> list_add_tail_rcu(&ops->list, &link_ops);
> unlock:
> + if (err)
> + cleanup_srcu_struct(&ops->srcu);
> +
> mutex_unlock(&link_ops_mutex);
Does the cleanup have to be under the lock?
next prev parent reply other threads:[~2026-03-20 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 16:15 [PATCH net] rtnetlink: fix leak of SRCU struct in rtnl_link_register Sabrina Dubroca
2026-03-19 4:15 ` Kuniyuki Iwashima
2026-03-20 0:04 ` Jakub Kicinski
2026-03-20 0:05 ` Jakub Kicinski [this message]
2026-03-20 7:23 ` Sabrina Dubroca
2026-03-21 0:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319170541.27c75eac@kernel.org \
--to=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox