* [PATCH] net: b44: always select CONFIG_FIXED_PHY
@ 2026-03-20 15:49 Arnd Bergmann
2026-03-24 0:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-03-20 15:49 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Heiner Kallweit
Cc: Arnd Bergmann, Vikas Gupta, Bhargava Marreddy,
Rajashekar Hudumula, Eric Biggers, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When CONFIG_FIXED_PHY=m but CONFIG_B44=y, the kernel fails to link:
ld.lld: error: undefined symbol: fixed_phy_unregister
>>> referenced by b44.c
>>> drivers/net/ethernet/broadcom/b44.o:(b44_remove_one) in archive vmlinux.a
ld.lld: error: undefined symbol: fixed_phy_register_100fd
>>> referenced by b44.c
>>> drivers/net/ethernet/broadcom/b44.o:(b44_register_phy_one) in archive vmlinux.a
The fixed phy support is small enough that just always enabling it
for b44 is the simplest solution, and it avoids adding ugly #ifdef
checks.
Fixes: 10d2f15afba2 ("net: b44: register a fixed phy using fixed_phy_register_100fd if needed")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index a8021008eb51..35d68dd99086 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -27,7 +27,7 @@ config B44
select SSB
select MII
select PHYLIB
- select FIXED_PHY if BCM47XX
+ select FIXED_PHY
help
If you have a network (Ethernet) controller of this type, say Y
or M here.
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: b44: always select CONFIG_FIXED_PHY
2026-03-20 15:49 [PATCH] net: b44: always select CONFIG_FIXED_PHY Arnd Bergmann
@ 2026-03-24 0:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-24 0:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, hkallweit1, arnd,
vikas.gupta, bhargava.marreddy, rajashekar.hudumula, ebiggers,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 20 Mar 2026 16:49:19 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_FIXED_PHY=m but CONFIG_B44=y, the kernel fails to link:
>
> ld.lld: error: undefined symbol: fixed_phy_unregister
> >>> referenced by b44.c
> >>> drivers/net/ethernet/broadcom/b44.o:(b44_remove_one) in archive vmlinux.a
>
> [...]
Here is the summary with links:
- net: b44: always select CONFIG_FIXED_PHY
https://git.kernel.org/netdev/net/c/3f0f591b44b0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-24 0:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-20 15:49 [PATCH] net: b44: always select CONFIG_FIXED_PHY Arnd Bergmann
2026-03-24 0:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox