From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 898EA3CE48A; Fri, 20 Mar 2026 15:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774021773; cv=none; b=c8Cnt2yqAI3etiH94gZSxl3PN5l7hAeGVNTgEY/70MNrJ7wadI5JCINF2C9/u+OpypztIxvhKlCkVGhYeSprAQTsPFcHxDpwDhzENCablWV2KIdniI8pokkrOz4ia0RIXZdtGbSAAiOxRp/i6xE0yEQa79XJIKB82j0OSVQKrX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774021773; c=relaxed/simple; bh=yxsTqlTDLYz3NvilL7JWiv29ZhfMWZjhsNqrO5yO2MQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rAUqkGJIlOz5QP5HbiDzMfvOnIro9kebsTNWJHJx46j8bDN0e1Vtgs3wyQKM2si/qsANLXpCP+hrWHJcrOS/NKmJwMPPO8La/84jUiOH2O0w2tl7uYkkWdVS85dhL0u5wctLXMy6ApDeVYbk3P36bv1z1Qpl6JdsxMR9J2rbZ+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DienXy3Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DienXy3Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39398C2BC87; Fri, 20 Mar 2026 15:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774021773; bh=yxsTqlTDLYz3NvilL7JWiv29ZhfMWZjhsNqrO5yO2MQ=; h=From:To:Cc:Subject:Date:From; b=DienXy3QtlutpKjRqy4j2ztPJ+4fyeaXtMWmRxhNI7W41YBNE69GGnZPz1btgrodl zM7EVvmRGdv0p/1fwPMGJdGyavNrhHZmo5YYUoru3H98ZDMTqYZGZ7ooMdYsyvm1UR M/9lQAtttyOsnSHodic74axvlaA7ENdOCJaYp8h7OOCUjDRehGZf90d5IU/EnuZzGr JP/rQov1tc7IjXSHYWC/vzGleoSIoDpEwJbtDa+ASCimkPKIHwEIm0TwAQp3R3s1BX UD+MFwvj8rK97DIeD8yiMRtCOVAaxS+ULv0igwTUt8ENwOxabCm5v65DMoea+x3M2b ZZ5jWlnypaKyg== From: Arnd Bergmann To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit Cc: Arnd Bergmann , Vikas Gupta , Bhargava Marreddy , Rajashekar Hudumula , Eric Biggers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: b44: always select CONFIG_FIXED_PHY Date: Fri, 20 Mar 2026 16:49:19 +0100 Message-Id: <20260320154927.674555-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann When CONFIG_FIXED_PHY=m but CONFIG_B44=y, the kernel fails to link: ld.lld: error: undefined symbol: fixed_phy_unregister >>> referenced by b44.c >>> drivers/net/ethernet/broadcom/b44.o:(b44_remove_one) in archive vmlinux.a ld.lld: error: undefined symbol: fixed_phy_register_100fd >>> referenced by b44.c >>> drivers/net/ethernet/broadcom/b44.o:(b44_register_phy_one) in archive vmlinux.a The fixed phy support is small enough that just always enabling it for b44 is the simplest solution, and it avoids adding ugly #ifdef checks. Fixes: 10d2f15afba2 ("net: b44: register a fixed phy using fixed_phy_register_100fd if needed") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index a8021008eb51..35d68dd99086 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -27,7 +27,7 @@ config B44 select SSB select MII select PHYLIB - select FIXED_PHY if BCM47XX + select FIXED_PHY help If you have a network (Ethernet) controller of this type, say Y or M here. -- 2.39.5