From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53F53B19C0; Fri, 20 Mar 2026 17:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774028690; cv=none; b=VLOsd+SDE8SvCBU6yEs+77nPCeA2YAY9QDdWrAwGceK3rCDM6o3WjD4EBtYT4f0Bg61WKb4I3cszIlJVcagzSozO3TxLj89V9jemNjL/tULDWWDDUNR0c4p8TKNOieyUQu2OGp9bcy4jU6L9FamXL/+LblHegkm7/fxo92rb6no= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774028690; c=relaxed/simple; bh=XxiZwm/TFIYNgDW+Y1dURY6wVeoypsqYZQcwhGZGH5w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GJdU4OGcvZ3nFBd34AyuuogfsR1PLKbMwarOHIK2JVivgJYAU7Lj76cZ8K4IrsS1MARTr2E/nWy4FV94iItRULk+sKkSvI0jV2qzHB+HZoEQ+3s6HPsmnj4XKyCaHMAMu/ppzn6+NnDjX1rwLwISb38d+1n+DLsU5BlI9OrCFmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MFhELuc9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MFhELuc9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1970EC19425; Fri, 20 Mar 2026 17:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774028690; bh=XxiZwm/TFIYNgDW+Y1dURY6wVeoypsqYZQcwhGZGH5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFhELuc9ptp/tfiGUeWB6IpIvB2CclNpsrcYG5Jd6RCH9+YxhvpMoiu+hW/QwVkqM WaOt7W4WZ9f7YfdzbnHqBEVpkbbGmR2Rx9LTgV14zJLYlsmvXFnFrj/QwbgdgMrkUf rql+xKm9WEAOW4BpZmpChMzU4iWBRauphaOB3HFVAKVwFz6Y6vdAHNBPLDxEeYrlCH yKv6BzAFaariZVvsyojoYj9bT9YSMWXMShRcTqoseKWI+xd4EfK0f7kWduG07Vt+vE nZZSME1iivJjvz4A6e11jXkml66qwlRntV3nbqQ1K01oJkJWtGW3wYq2jJvKgHDYL0 MljJL8ta8uADg== Date: Fri, 20 Mar 2026 17:44:44 +0000 From: Simon Horman To: Yury Norov Cc: Jakub Kicinski , Paolo Abeni , "David S. Miller" , Eric Dumazet , Andrew Lunn , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , Subbaraya Sundeep , Stanislav Fomichev , Kuniyuki Iwashima , Christian Brauner , Yajun Deng , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Yury Norov Subject: Re: [PATCH v2 0/2] net: cleanup bitmaps printing Message-ID: <20260320174444.GG74886@horms.kernel.org> References: <20260319201713.941956-1-ynorov@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319201713.941956-1-ynorov@nvidia.com> On Thu, Mar 19, 2026 at 04:17:09PM -0400, Yury Norov wrote: > Bitmap API has a bitmap_print_to_pagebuf() function that is intended to > print bitmap into a human readable format, making sure that the output > string will not get big enough to cross the current page limit. > > Some drivers use this function immediately before passing the result to > scnprintf() with no modification. This is useless because scnprintf(), > and helpers based on it like seq_pritf() and sysfs_emit(), take care of > not overflowing the buffer by itself, and perfectly print bitmaps with > "%*pb[l]". > > v1: https://lore.kernel.org/all/20260219181407.290201-1-ynorov@nvidia.com/ > v2: > - fix copy-paste error in print_npa_qsize() (Simon); > - fix typo in #1 subject (Jakub). Thanks for the updates. Reviewed-by: Simon Horman