From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org,
Katarzyna Wieczerzycka <katarzyna.wieczerzycka@intel.com>
Subject: Re: [PATCH] ice: add missing reset of the mac header
Date: Fri, 20 Mar 2026 18:04:54 +0000 [thread overview]
Message-ID: <20260320180410.GA151863@horms.kernel.org> (raw)
In-Reply-To: <20260320050518.422303-1-aleksandr.loktionov@intel.com>
On Fri, Mar 20, 2026 at 06:05:18AM +0100, Aleksandr Loktionov wrote:
> From: Katarzyna Wieczerzycka <katarzyna.wieczerzycka@intel.com>
>
> By default skb->mac_header is not set, so reset prevents access to an
> invalid pointer.
>
> Call skb_reset_mac_header() before accessing the mac header from skb.
>
> Signed-off-by: Katarzyna Wieczerzycka <katarzyna.wieczerzycka@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Hi Katarzyna and Aleksandr,
I am curious:
Is this a bug? If so then it should probably have a fixes tag and
a bit more of a description around how this can happen.
If it is not a bug, then is this defensive? And if so, is it really necessary?
...
next prev parent reply other threads:[~2026-03-20 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 5:05 [PATCH] ice: add missing reset of the mac header Aleksandr Loktionov
2026-03-20 18:04 ` Simon Horman [this message]
2026-03-20 19:53 ` Loktionov, Aleksandr
2026-03-21 9:14 ` Simon Horman
2026-03-26 14:14 ` Loktionov, Aleksandr
2026-03-24 18:02 ` [Intel-wired-lan] " Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320180410.GA151863@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=katarzyna.wieczerzycka@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox