From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 3/3] net: dpaa2-mac: export standard statistics
Date: Fri, 20 Mar 2026 19:19:43 -0700 [thread overview]
Message-ID: <20260320191943.2325cf38@kernel.org> (raw)
In-Reply-To: <20260319142346.2483232-4-ioana.ciornei@nxp.com>
On Thu, 19 Mar 2026 16:23:46 +0200 Ioana Ciornei wrote:
> + DPMAC_RMON_COUNTER(DPMAC_CNT_EGR_UNDERSIZED, undersize_pkts),
> + DPMAC_RMON_COUNTER(DPMAC_CNT_ING_OVERSIZED, oversize_pkts),
AI says:
According to the RMON standard (RFC 2819), the etherStatsUndersizePkts
counter tracks the number of undersized packets received. Should this map
to an ingress counter rather than the egress counter DPMAC_CNT_EGR_UNDERSIZED
used here?
https://sashiko.dev/#/patchset/20260319142346.2483232-1-ioana.ciornei%40nxp.com
prev parent reply other threads:[~2026-03-21 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 14:23 [PATCH net-next v4 0/3] net: dpaa2-mac: export standard statistics Ioana Ciornei
2026-03-19 14:23 ` [PATCH net-next v4 1/3] net: dpaa2-mac: extend APIs related to statistics Ioana Ciornei
2026-03-19 14:23 ` [PATCH net-next v4 2/3] net: dpaa2-mac: retrieve MAC statistics in one firmware command Ioana Ciornei
2026-03-19 14:23 ` [PATCH net-next v4 3/3] net: dpaa2-mac: export standard statistics Ioana Ciornei
2026-03-21 2:19 ` Jakub Kicinski
2026-03-21 2:19 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320191943.2325cf38@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox