From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74BCC1684A4; Sat, 21 Mar 2026 02:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774059585; cv=none; b=BnNxz103u3IdyF0jxQQH7jJkPYnlO1DSPuJa2E8h1MljJp86cY0FaizRANmlDDOwf/tSHtMkW4OhA+M9Z1vj0FFoAofam+oLc3tK3qMU3QOvsxKcxd2hDgCAUEfS2AimHS+8chqX93f6R7nmBDecPjhFXf39ccqv/ZMbjVthyJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774059585; c=relaxed/simple; bh=B46boP4KQH0aUYCmWrqmyddQC4iUSf3MZC1uLrDcju4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QApsi03f6fMqiDXBOKF2mhM5tkt24rZ542n2LA5kByybrxpNL4RZOaKG8pT3k+X12BsZaOHHc+1SAkFY96N0oJUHfVQ+z2kJOmcdE5uj+uk+LXfXIcck3B4+4MWLRqSlP7nzmOsZoEBcMANjXUAjGIzFhmvcN9W0/PK7P4MlaQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=odH6QzqE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="odH6QzqE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2E2AC4CEF7; Sat, 21 Mar 2026 02:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774059585; bh=B46boP4KQH0aUYCmWrqmyddQC4iUSf3MZC1uLrDcju4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=odH6QzqEi9bJOy75ecffMuMrZKHkC1dvIMPN++qCChgSxTTkNl3p57vg9OrtkkTBO SGd4OArKu76mmCLUZ1RfAFduNkQTDOCy3R1i5O9w6o+xYpajmA67O6s6wlh/n3LlWa dZM3GEeZtERI7WlqEGfTS6hZ0kSkzNqSUbh38Zk6braO71wygiu3oxso4BbxwEeYyM Wj9c25AiKONR1dw6FWdicX6NyGN39PYQCrhGyAnntybzuDdsU9JSTHkMGJxgCQeHJY fzU2H8V07IuKLqWMwwfvzXVGtyM3HwyollrYdygydBJYVz7oKwdgz70OU/x4es7zRF aeSG5W3lVznyg== Date: Fri, 20 Mar 2026 19:19:43 -0700 From: Jakub Kicinski To: Ioana Ciornei Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 3/3] net: dpaa2-mac: export standard statistics Message-ID: <20260320191943.2325cf38@kernel.org> In-Reply-To: <20260319142346.2483232-4-ioana.ciornei@nxp.com> References: <20260319142346.2483232-1-ioana.ciornei@nxp.com> <20260319142346.2483232-4-ioana.ciornei@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 19 Mar 2026 16:23:46 +0200 Ioana Ciornei wrote: > + DPMAC_RMON_COUNTER(DPMAC_CNT_EGR_UNDERSIZED, undersize_pkts), > + DPMAC_RMON_COUNTER(DPMAC_CNT_ING_OVERSIZED, oversize_pkts), AI says: According to the RMON standard (RFC 2819), the etherStatsUndersizePkts counter tracks the number of undersized packets received. Should this map to an ingress counter rather than the egress counter DPMAC_CNT_EGR_UNDERSIZED used here? https://sashiko.dev/#/patchset/20260319142346.2483232-1-ioana.ciornei%40nxp.com