From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DAF3359A88 for ; Fri, 20 Mar 2026 19:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774036395; cv=none; b=ZcVpsZJfCKgVvt0kKm3GRvFruF31UiyJmWO0qAQGwELlkUVYb/7/fx0UK/j0Qte3k8cqVbi+buUPU5MpeLPA8azwuGoP6VtvDxBWUST0dXd/FB9ErtNO0qxmfE5luLxevJ0v6dOiMQNsKTkufOs93rjugmAg4NZaTgPYxOKm+0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774036395; c=relaxed/simple; bh=yOlwrnfApgSr2V+5A7pE8Ew2hiOEjPzACHrqChYg0ng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q+yb4rc4jyKDVmgd1mR4U5hiM+4ZKqiH9FPK0R11PONld7s7/ryQmfLrjythQlYtoNwqh+iyJps9p+uHWMAY6mr+IObjq2AJwxtqhLAvaLwUhEp+U+Vn+6KysLCMARvLp/8+24Rvkws3wXbE/+lH4Rt/4A43wmPjG1VfBVrfx24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ojiZCEL4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ojiZCEL4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9506BC19425; Fri, 20 Mar 2026 19:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774036394; bh=yOlwrnfApgSr2V+5A7pE8Ew2hiOEjPzACHrqChYg0ng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ojiZCEL4DYXNLde91ANXhlXkvVIodJ9nQVyh0mL6mvlhYb++J1Dx2Jb+v/LwSu3c0 i9XTCgoc4/7q06a0yIwC8LWoqowP9qsDN27ib/VOj7w49P6RG31wv01p5TW05oa1h2 cIfz+hOxDFiuqx5cWQiESIfq2TVrB+q14vK0MM6cjQsRHR9io/o/K73C384TC7L9Sk Zfk7QdhNZXPBlMx9ngO6as3bPtNUvd0Nqu9uahQ9VnA9ztGC0Zr4C5iMlwApLtzLt5 uF+Y4r1hfkV7HoAu0LvofsAZANRWQR7kNyJF7vwTAbevewN1DvmBJN2a/+utzZHSKE vH5Pb6ztbJHPg== Date: Fri, 20 Mar 2026 19:53:11 +0000 From: Simon Horman To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, Jakub Staniszewski Subject: Re: [PATCH iwl-next] ice: fix FDB deletion Message-ID: <20260320195311.GK74886@horms.kernel.org> References: <20260320050533.422475-1-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260320050533.422475-1-aleksandr.loktionov@intel.com> On Fri, Mar 20, 2026 at 06:05:33AM +0100, Aleksandr Loktionov wrote: > From: Jakub Staniszewski > > Correct the logic in ndo_fdb_del() to align with other drivers in > upstream. The condition was inverted — it was rejecting permanent > (NUD_PERMANENT) MAC addresses while allowing non-permanent ones to be > deleted, which is the opposite of the intended behavior. > > The correct logic is to reject deletion of non-permanent entries, > mirroring the fix applied to ndo_dflt_fdb_del() in commit 645359930231 > ("rtnetlink: Fix inverted check in ndo_dflt_fdb_del()"). > > Fixes: e94d4478669357cd ("ice: Implement filter sync, NDO operations and bump version") > Signed-off-by: Jakub Staniszewski > Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman