From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B104C34EF06 for ; Fri, 20 Mar 2026 20:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774036836; cv=none; b=BqUH3Nhr34bZChuKLaNR24jhcgb2QrKifXoN4kWuFbD8JYfRrg20SG6hwJ4eyS1uFWCfUXCG1gAUjCZZ7xwdLd3MPRaMM1ZDxa8R3NqG+dX4z5RUGd8E+BOJNquZ2BW5rs0MMWw2t+tDFNuytW4S9rARSJJHePvLQIgTXGAC++k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774036836; c=relaxed/simple; bh=7RWcsTU2360ka8mJ0tGJAWGE66My1KMl+jpt2ccA72c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R3s/74s63DN9NAvW6JKMcS4NOakKK95HpFF83q1/9pigO0YgWWrgC9nE2PWxtpSQfDFK55TNLDyb7g3SCE5nBkbGcUB9OTZpPKd3VhGgj9ij9OrZxHqOHBh74vXwa+6KLexe9eKiiI7x8L15ExjHlsOj31tYigGEOsh+5eYrAQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jLA/Z9cF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jLA/Z9cF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16507C4CEF7; Fri, 20 Mar 2026 20:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774036836; bh=7RWcsTU2360ka8mJ0tGJAWGE66My1KMl+jpt2ccA72c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jLA/Z9cFRVCNKBAonUR//Mbeb74tF+SBIDFDw39IgBxMUhtdwsFWunm/r2YWVexV4 o/8Nc8i2Jpvp4fiBrZeodAYZ7g9MxvhjwFqnV24S2JpM2uvr3e/ZycZjA/uvacjDRS UP6mAnSQX3fxQ/1SXXsEe6efG3o+QR/11lpUvxrC8zaZc7Sx/VfiI/l81ulgQ7EN7J x3sxIdBgc4wHRlL6wl82wovWUJP0953DjU/S4NkCnepy3hJOQKaVAHOt4gZL/v0rdz 3TNC8RUMdtKN088TH57nBYjCfa33SZksYHXzJ6VVIlQ526LtV9cUTkdGTNgQg5CrtA 4XHjhM2DtuDbQ== Date: Fri, 20 Mar 2026 20:00:32 +0000 From: Simon Horman To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, Marcin Szycik , Martyna Szapar-Mudlaw Subject: Re: [PATCH iwl-next] ice: use ice_fill_eth_hdr() in ice_fill_sw_rule() Message-ID: <20260320200032.GM74886@horms.kernel.org> References: <20260320050556.422762-1-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260320050556.422762-1-aleksandr.loktionov@intel.com> On Fri, Mar 20, 2026 at 06:05:56AM +0100, Aleksandr Loktionov wrote: > From: Marcin Szycik > > Use the already existing helper function to fill Ethernet header. Also > replace sizeof with a (also existing) macro to reduce the number of > variables. > > Suggested-by: Martyna Szapar-Mudlaw > Signed-off-by: Marcin Szycik > Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman