From: Sean Chang <seanwascoding@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
Anna Schumaker <anna@kernel.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sean Chang <seanwascoding@gmail.com>
Subject: [PATCH v5 0/5] sunrpc/nfs: cleanup redundant debug checks and refactor macros
Date: Sat, 21 Mar 2026 22:15:05 +0800 [thread overview]
Message-ID: <20260321141510.68214-1-seanwascoding@gmail.com> (raw)
This series cleans up redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards
across sunrpc, nfsd, and lockd, as these checks are already handled
within the dprintk macros.
Additionally, it refactors the nfs_errorf() macros into a safer
do-while(0) pattern and removes unused nfs_warnf() macros to improve
code maintainability.
v5:
- Reformat the cleanup of __maybe_unused into a formal 'Revert' patch as requested.
- Update the macro refactoring commit message to include historical context
(commit ce8866f0913f) and use backticks for `git grep`.
v4:
- Add a missing patch to include/linux/sunrpc/debug.h to ensure dprintk()
properly handles variable referencing via no_printk().
- Remove obsolete __maybe_unused from fs/nfsd/export.c (revert ebae102897e7)
as suggested by Andy Shevchenko.
- Add Reviewed-by and Tested-by tags from Andy Shevchenko.
v3:
- Added nfs_errorf refactoring and removed unused nfs_warnf macros.
- Split sunrpc and nfsd changes for better clarity.
v2:
- Follow reversed xmas tree order for variables in svc_rdma_transport.c
as requested by Andy Shevchenko.
- Polish commit message: use dprintk() and remove redundant file list.
- Correct the technical claim about dprintk() type checking.
Sean Chang (5):
sunrpc: Fix dprintk type mismatch using do-while(0)
nfsd/lockd: Remove redundant debug checks
svcrdma: Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards
nfs: Refactor nfs_errorf macros and remove unused ones
Revert "nfsd: Mark variable __maybe_unused to avoid W=1 build break"
fs/lockd/svclock.c | 7 ------
fs/nfs/internal.h | 28 +++++++++++-------------
fs/nfsd/export.c | 2 +-
fs/nfsd/nfsfh.c | 8 +++----
include/linux/sunrpc/debug.h | 8 ++-----
net/sunrpc/xprtrdma/svc_rdma_transport.c | 25 ++++++++++-----------
6 files changed, 30 insertions(+), 48 deletions(-)
--
2.34.1
next reply other threads:[~2026-03-21 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 14:15 Sean Chang [this message]
2026-03-21 14:15 ` [PATCH v5 1/5] sunrpc: Fix dprintk type mismatch using do-while(0) Sean Chang
2026-03-21 16:37 ` Chuck Lever
2026-03-25 15:49 ` Sean Chang
2026-03-21 14:15 ` [PATCH v5 2/5] nfsd/lockd: Remove redundant debug checks Sean Chang
2026-03-21 14:15 ` [PATCH v5 3/5] svcrdma: Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Sean Chang
2026-03-21 14:15 ` [PATCH v5 4/5] nfs: Refactor nfs_errorf macros and remove unused ones Sean Chang
2026-03-21 16:38 ` Chuck Lever
2026-03-25 16:11 ` Sean Chang
2026-03-21 14:15 ` [PATCH v5 5/5] Revert "nfsd: Mark variable __maybe_unused to avoid W=1 build break" Sean Chang
2026-03-21 16:38 ` Chuck Lever
2026-03-25 16:39 ` Sean Chang
2026-03-23 13:25 ` [PATCH v5 0/5] sunrpc/nfs: cleanup redundant debug checks and refactor macros Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321141510.68214-1-seanwascoding@gmail.com \
--to=seanwascoding@gmail.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox