From: Conor Dooley <conor@kernel.org>
To: Charles Perry <charles.perry@microchip.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: document Microchip PIC64-HPSC/HX MDIO controller
Date: Mon, 23 Mar 2026 19:35:41 +0000 [thread overview]
Message-ID: <20260323-numbness-murky-6ad25f9ac5d7@spud> (raw)
In-Reply-To: <acFCPnia+riDwvJJ@bby-cbu-swbuild03.eng.microchip.com>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Mon, Mar 23, 2026 at 06:38:06AM -0700, Charles Perry wrote:
> On Thu, Mar 19, 2026 at 01:35:52AM +0000, Conor Dooley wrote:
> > On Wed, Mar 18, 2026 at 02:23:23PM -0700, Charles Perry wrote:
> > > > > +
> > > > > + clock-frequency: true
> > > >
> > > > Does this genuinely have no constraints?
> > >
> > > It's going to divide the input frequency by 2 to 512 (the prescaler is 8
> > > bit long), so assuming an input clock of 156.25 MHz, the bounds are 305KHz
> > > to 78MHz. The standard is 2.5MHz.
> > >
> > > I can add a maximum and minimum here since I do have some validation on
> > > this in the driver which will bail out if this is out of bound.
>
> Hello Conor,
>
> I have second doubt about this. The minimum and maximum depend on the input
> clock frequency which might change if someone uses a different crystal or
> clock config. So for that reason, I thinks it's better to not specify the
> bounds, because there's no way to know for sure what they when building the
> device tree.
Okay, sure.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-23 19:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 18:46 [PATCH net-next 0/2] Add support for PIC64-HPSC/HX MDIO controller Charles Perry
2026-03-17 18:46 ` [PATCH net-next 1/2] dt-bindings: net: document Microchip " Charles Perry
2026-03-18 17:48 ` Conor Dooley
2026-03-18 21:23 ` Charles Perry
2026-03-19 1:35 ` Conor Dooley
2026-03-23 13:38 ` Charles Perry
2026-03-23 19:35 ` Conor Dooley [this message]
2026-03-19 16:47 ` Andrew Lunn
2026-03-19 16:59 ` Andrew Lunn
2026-03-19 19:36 ` Charles Perry
2026-03-17 18:46 ` [PATCH net-next 2/2] net: mdio: add a driver for " Charles Perry
2026-03-18 9:52 ` Maxime Chevallier
2026-03-18 21:25 ` Charles Perry
2026-03-19 16:55 ` Andrew Lunn
2026-03-19 19:26 ` Charles Perry
2026-03-19 19:53 ` Andrew Lunn
2026-03-19 21:38 ` Charles Perry
2026-03-19 16:56 ` Andrew Lunn
2026-03-19 19:31 ` Charles Perry
2026-03-19 17:03 ` Andrew Lunn
2026-03-19 19:33 ` Charles Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323-numbness-murky-6ad25f9ac5d7@spud \
--to=conor@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=charles.perry@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox