public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
	Jeffrey Altman <jaltman@auristor.com>,
	Simon Horman <horms@kernel.org>,
	stable@kernel.org
Subject: [PATCH net v2 02/10] rxrpc: Fix key parsing memleak
Date: Mon, 23 Mar 2026 15:04:53 +0000	[thread overview]
Message-ID: <20260323150505.3513839-3-dhowells@redhat.com> (raw)
In-Reply-To: <20260323150505.3513839-1-dhowells@redhat.com>

In rxrpc_preparse_xdr_yfs_rxgk(), the memory attached to token->rxgk can be
leaked in a few error paths after it's allocated.

Fix this by freeing it in the "reject_token:" case.

Fixes: 0ca100ff4df6 ("rxrpc: Add YFS RxGK (GSSAPI) security class")
Closes: https://sashiko.dev/#/patchset/20260319150150.4189381-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Jeffrey Altman <jaltman@auristor.com>
cc: Eric Dumazet <edumazet@google.com>
cc: "David S. Miller" <davem@davemloft.net>
cc: Jakub Kicinski <kuba@kernel.org>
cc: Paolo Abeni <pabeni@redhat.com>
cc: Simon Horman <horms@kernel.org>
cc: linux-afs@lists.infradead.org
cc: netdev@vger.kernel.org
cc: stable@kernel.org
---
 net/rxrpc/key.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index af403f0ccab5..26d4336a4a02 100644
--- a/net/rxrpc/key.c
+++ b/net/rxrpc/key.c
@@ -274,6 +274,7 @@ static int rxrpc_preparse_xdr_yfs_rxgk(struct key_preparsed_payload *prep,
 nomem:
 	return -ENOMEM;
 reject_token:
+	kfree(token->rxgk);
 	kfree(token);
 reject:
 	return -EKEYREJECTED;


  parent reply	other threads:[~2026-03-23 15:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 15:04 [PATCH net v2 00/10] rxrpc: Miscellaneous fixes David Howells
2026-03-23 15:04 ` [PATCH net v2 01/10] rxrpc: Fix key quota calculation for multitoken keys David Howells
2026-03-23 15:04 ` David Howells [this message]
2026-03-23 15:04 ` [PATCH net v2 03/10] rxrpc: Fix anonymous key handling David Howells
2026-03-23 15:04 ` [PATCH net v2 04/10] list: Move on_list_rcu() to list.h and add on_list() also David Howells
2026-03-23 22:44   ` kernel test robot
2026-03-23 22:55   ` kernel test robot
2026-03-23 15:04 ` [PATCH net v2 05/10] rxrpc: Fix call removal to use RCU safe deletion David Howells
2026-03-23 15:04 ` [PATCH net v2 06/10] rxrpc: Fix RxGK token loading to check bounds David Howells
2026-03-23 15:04 ` [PATCH net v2 07/10] rxrpc: Fix use of wrong skb when comparing queued RESP challenge serial David Howells
2026-03-23 15:04 ` [PATCH net v2 08/10] rxrpc: Fix rack timer warning to report unexpected mode David Howells
2026-03-23 15:05 ` [PATCH net v2 09/10] rxrpc: Fix keyring reference count leak in rxrpc_setsockopt() David Howells
2026-03-23 15:05 ` [PATCH net v2 10/10] rxrpc: Fix key reference count leak from call->key David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323150505.3513839-3-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jaltman@auristor.com \
    --cc=kuba@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox