From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD7F23AC0C9 for ; Mon, 23 Mar 2026 16:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774284676; cv=none; b=WxM9Tok7xXMIcE6Wvh1cHvDjQmDpvGqFP9JONzt0UR2BxlpJxn3YaKejZDckKxIL4pO/9RUZ9JfhLwmskxERm+3BvjIaYOU4hVNva7qcbimlN/JyMR+OLXgR0YaD1WY/m1F7hyKwuxSgauNqM/DyTObUNwrDlWQP612PutNrT80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774284676; c=relaxed/simple; bh=WdjcxPTcT4Y1PoQE6XWTl+XVkmHgqj7rjddA4gBZ+fs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D49deEtybsWbpWpKpXo/7c32+iN4tzDMi4zMzPVx9Tz71aykFBmswQtIueriieK6piN6GOy81tlq0RS8upsoZnEyUfiK7C2iu0CDfJ+saoq0kTbDNltSpCd/pVVoYZ5pu/38fXptvkFsy2cary+bFYzTNnJwwM18ka1Ra1HJGUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oYBaKdSK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oYBaKdSK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BF57C4CEF7; Mon, 23 Mar 2026 16:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774284676; bh=WdjcxPTcT4Y1PoQE6XWTl+XVkmHgqj7rjddA4gBZ+fs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oYBaKdSK6Rwh8nA7QIeDktYYeXxlL+ZSi7aXvMooTqNgyaRLPpymvsOHWKiHf+8EY LRYBHuC6zk6xNtVsgPwaKNNjxKmfo9a9fZID0sbEKqJqMf3HYrS02XiAzeed6vGHff NxE84qFs61x5Zu3CaiOGwx2MKU2F691PpHUOs+k6MYqbEGYMJW2tXakmoLAPurQDM3 WSNZqr94++bGnXOGE5wWPlcmObWMgio4pm8LnQMGfjNV2K7dx0wvvcPPOLuwI3w0+J MhklBAuGx2qCp0o1w6kGDDOWqH279aIalL0YZsJNVXjLQlzprSSj9ML4Lnvc8YzJCR p93PZUE0SnVHQ== Date: Mon, 23 Mar 2026 16:51:12 +0000 From: Simon Horman To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2] net: airoha: Rework the code flow in airoha_remove() and in airoha_probe() error path Message-ID: <20260323165112.GA137813@horms.kernel.org> References: <20260321-airoha-remove-rework-v2-1-16c7bade5fe5@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260321-airoha-remove-rework-v2-1-16c7bade5fe5@kernel.org> On Sat, Mar 21, 2026 at 03:41:44PM +0100, Lorenzo Bianconi wrote: > As suggested by Simon in [0], rework the code flow in airoha_remove() > and in the airoha_probe() error path in order to rely on a more common > approach un-registering configured net-devices first and destroying the > hw resources at the end of the code. > Introduce airoha_qdma_cleanup routine to release QDMA resources. > > [0] https://lore.kernel.org/netdev/20251214-airoha-fix-dev-registration-v1-1-860e027ad4c6@kernel.org/ > > Suggested-by: Simon Horman > Signed-off-by: Lorenzo Bianconi > --- > Changes in v2: > - Fix eth->napi_dev leak if airoha_hw_init() fails in airoha_probe() > - Link to v1: https://lore.kernel.org/r/20260320-airoha-remove-rework-v1-1-adeef7e3c01f@kernel.org Thanks for the update. Reviewed-by: Simon Horman