From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570F03C343B for ; Mon, 23 Mar 2026 16:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774285091; cv=none; b=f3qtitSbyMHLqsnyvf/jgrm/dxYYcI3wnxCRqhLiYpy7CD/6sVyhDbXULqad+ohqV3m7szoel8EwVcnrnRT7YeQz9KreJnTT6FPOuso2K9p7eiGfpWaETGUG+CyQxU+c0YJdNXxgSXOyMRuG7WoC0QEAnOfcV6x7bFEfC37kRBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774285091; c=relaxed/simple; bh=1R5QoRjpryjEmRKSu+GecPhvfAVUv2rQ3tJZWgcI/Fs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t/cyXf3mFW001S6sbXCHM6DDAKFXnm4YH01PRBcBeLD/RlzHqTiBwGwQumeJXCzjCNX6PfIqmzXUubDHtrQwUWc8wWhvuU/LdwsgicnReB9V6AuGAHW9Alv7HzTNDRAawAAm33Ijl/SmvrqQ3mwpLG/H4We4WAfDIwd7CQlGTiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WokUWn77; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WokUWn77" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48558d6ef83so29124125e9.3 for ; Mon, 23 Mar 2026 09:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774285089; x=1774889889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B00FySKCwug1nr/4nnc+9QuABBXvC6ZmF4Hl8lqc1Mc=; b=WokUWn77bNg4m3RJZ2v3v+14q9Ar4NcJTUCza8vlgLp0hb4ri1Iol4gwrKxlNvWm0n b1SNdbw3CpEgWhPQpe9YHixU/Ys3li5gahv7zM6dUBVqGblXrq+TGQ1kFqdmPHb1q34U JPahDYQeml6xVMVsde8T+YXfKNM/Hyv/6b7QP0cwo/MxaCM8VgLPjzBEQbnTMtPeZuy5 b/wYD1o7IQAbLdvYVjSBct6jUzXtTPDOIzNtWbuRgu8OtaQNhwh77uT8v5s6zS8indEj uZALbpK0C2XCDrrnVx4bymsJ2pNs9qaXf8E7hvDUe//VT7OVFOd6Y/k35L3KEe2TdWcf zvxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774285089; x=1774889889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B00FySKCwug1nr/4nnc+9QuABBXvC6ZmF4Hl8lqc1Mc=; b=k+p2j15wBueaVFZAOKJUDb3WcxV+X5oeAGQym5MjlHsa2sdeoB3tmUH031tyi0G10D MxWIR/vVqDws9OtxPMKaPp7uRfr1bIkkWoN57IDCKaq9nbLoyZVB8MMDI5IknlQRjs67 vb9+JplvCyQh555xlP2YPFVjmBphlmz6omC3NF4C737gLEeI0SWFkHER0Z1Ie9rohF92 +9kgWHGMyHuwPkUbx1dEY+mBNwFcJZ3ywxPgvC09CtToEIj9toWeiaXQNH8l/3Cf8dYi cP14csQD+5qn9I3eHL22H6tjMmT1EVu1Fr3SxMU3veewO6vyHimZmhXiPRSZEUzn4B+M vURQ== X-Forwarded-Encrypted: i=1; AJvYcCXalmNfFs5bSGVkk/8AJJa7+hnwXy0db5keGh/eC+eRQVQMSimft6bPzRc50v9bzAah4px77Ps=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5arHVCxrjhClMt0Lx+CuJfyBuNuj6jtqrrBUgwYWfJxmpWRoM nME6JWSlUUGAR5KBbTW8MlUnr41Yob9CLGJEqkt1hJ3AmO6mEAxNRFMG X-Gm-Gg: ATEYQzx6lxnUaUEZX+QjiaCfBxy3/vLHgNOBYTZQCvyJgO+X3QXSy73fBzqxL2jtDAI Xb0hLhp6fmJEyhN5uKJo18fnpbyPfgSbrqblKSifig3Q+iJcaNO/4LJOC0x7NEXX6G76Yl5GDrY IErVxnCCIGtNOoLt3sUHukc1wJx3oAj6NDAZEA847kJ0efqrGp8f3rhqfRoGSlzsR4KiRzu8/DO NlB3SZOiH1M/3PbKNq2alRuMlfE/b5YpWYuM0bVUupCECswe/vLb3jVeUyx7tVQjSz12/+TF58A eHOcZzpos+7LjUsfce1eKKoG3Q8ifOCxmbblv5vucLmXQW8V3QJSnaD5vc9WjZXCbVrynYDbb3R FsUpLKK0S7l+ei491CNq2g5f2+YuttJ4IPMFV5vc1Wym3GEQBC2E5CFqHkeyx9iT8x51Dzu3NQI H1zbJOTsipTFe60VPXo+FzFYBXcmgH4xq6a7A6Xev53Hxd/zOW X-Received: by 2002:a05:600c:45c5:b0:477:7ae0:cd6e with SMTP id 5b1f17b1804b1-486febbc74dmr180324395e9.5.1774285088614; Mon, 23 Mar 2026 09:58:08 -0700 (PDT) Received: from localhost (ip87-106-108-193.pbiaas.com. [87.106.108.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487004e7bc4sm120537085e9.2.2026.03.23.09.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:58:08 -0700 (PDT) From: =?UTF-8?q?G=C3=BCnther=20Noack?= To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , "John Johansen" , "Paul Moore" , James Morris , "Serge E . Hallyn" Cc: =?UTF-8?q?G=C3=BCnther=20Noack?= , Tingmao Wang , Justin Suess , linux-security-module@vger.kernel.org, "Samasth Norway Ananda" , "Matthieu Buffet" , "Mikhail Ivanov" , konstantin.meskhidze@huawei.com, "Demi Marie Obenour" , "Alyssa Ross" , "Jann Horn" , "Tahera Fahimi" , Sebastian Andrzej Siewior , "Kuniyuki Iwashima" , Simon Horman , netdev@vger.kernel.org, Alexander Viro , Christian Brauner Subject: [PATCH v7 01/11] lsm: Add LSM hook security_unix_find Date: Mon, 23 Mar 2026 17:56:43 +0100 Message-ID: <20260323165654.193957-2-gnoack3000@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323165654.193957-1-gnoack3000@gmail.com> References: <20260323165654.193957-1-gnoack3000@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Justin Suess Add an LSM hook security_unix_find. This hook is called to check the path of a named UNIX socket before a connection is initiated. The peer socket may be inspected as well. Why existing hooks are unsuitable: Existing socket hooks, security_unix_stream_connect(), security_unix_may_send(), and security_socket_connect() don't provide TOCTOU-free / namespace independent access to the paths of sockets. (1) We cannot resolve the path from the struct sockaddr in existing hooks. This requires another path lookup. A change in the path between the two lookups will cause a TOCTOU bug. (2) We cannot use the struct path from the listening socket, because it may be bound to a path in a different namespace than the caller, resulting in a path that cannot be referenced at policy creation time. Consumers of the hook wishing to reference @other are responsible for acquiring the unix_state_lock and checking for the SOCK_DEAD flag therein, ensuring the socket hasn't died since lookup. Cc: Günther Noack Cc: Tingmao Wang Cc: Mickaël Salaün Cc: Paul Moore Signed-off-by: Justin Suess Signed-off-by: Günther Noack --- include/linux/lsm_hook_defs.h | 5 +++++ include/linux/security.h | 11 +++++++++++ net/unix/af_unix.c | 10 +++++++--- security/security.c | 20 ++++++++++++++++++++ 4 files changed, 43 insertions(+), 3 deletions(-) diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h index 8c42b4bde09c..7a0fd3dbfa29 100644 --- a/include/linux/lsm_hook_defs.h +++ b/include/linux/lsm_hook_defs.h @@ -317,6 +317,11 @@ LSM_HOOK(int, 0, post_notification, const struct cred *w_cred, LSM_HOOK(int, 0, watch_key, struct key *key) #endif /* CONFIG_SECURITY && CONFIG_KEY_NOTIFICATIONS */ +#if defined(CONFIG_SECURITY_NETWORK) && defined(CONFIG_SECURITY_PATH) +LSM_HOOK(int, 0, unix_find, const struct path *path, struct sock *other, + int flags) +#endif /* CONFIG_SECURITY_NETWORK && CONFIG_SECURITY_PATH */ + #ifdef CONFIG_SECURITY_NETWORK LSM_HOOK(int, 0, unix_stream_connect, struct sock *sock, struct sock *other, struct sock *newsk) diff --git a/include/linux/security.h b/include/linux/security.h index 83a646d72f6f..99a33d8eb28d 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -1931,6 +1931,17 @@ static inline int security_mptcp_add_subflow(struct sock *sk, struct sock *ssk) } #endif /* CONFIG_SECURITY_NETWORK */ +#if defined(CONFIG_SECURITY_NETWORK) && defined(CONFIG_SECURITY_PATH) + +int security_unix_find(const struct path *path, struct sock *other, int flags); + +#else /* CONFIG_SECURITY_NETWORK && CONFIG_SECURITY_PATH */ +static inline int security_unix_find(const struct path *path, struct sock *other, int flags) +{ + return 0; +} +#endif /* CONFIG_SECURITY_NETWORK && CONFIG_SECURITY_PATH */ + #ifdef CONFIG_SECURITY_INFINIBAND int security_ib_pkey_access(void *sec, u64 subnet_prefix, u16 pkey); int security_ib_endport_manage_subnet(void *sec, const char *name, u8 port_num); diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 3756a93dc63a..5ef3c2e31757 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -1231,11 +1231,15 @@ static struct sock *unix_find_bsd(struct sockaddr_un *sunaddr, int addr_len, goto path_put; err = -EPROTOTYPE; - if (sk->sk_type == type) - touch_atime(&path); - else + if (sk->sk_type != type) goto sock_put; + err = security_unix_find(&path, sk, flags); + if (err) + goto sock_put; + + touch_atime(&path); + path_put(&path); return sk; diff --git a/security/security.c b/security/security.c index 67af9228c4e9..28ccea205874 100644 --- a/security/security.c +++ b/security/security.c @@ -4731,6 +4731,26 @@ int security_mptcp_add_subflow(struct sock *sk, struct sock *ssk) #endif /* CONFIG_SECURITY_NETWORK */ +#if defined(CONFIG_SECURITY_NETWORK) && defined(CONFIG_SECURITY_PATH) +/** + * security_unix_find() - Check if a named AF_UNIX socket can connect + * @path: path of the socket being connected to + * @other: peer sock + * @flags: flags associated with the socket + * + * This hook is called to check permissions before connecting to a named + * AF_UNIX socket. The caller does not hold any locks on @other. + * + * Return: Returns 0 if permission is granted. + */ +int security_unix_find(const struct path *path, struct sock *other, int flags) +{ + return call_int_hook(unix_find, path, other, flags); +} +EXPORT_SYMBOL(security_unix_find); + +#endif /* CONFIG_SECURITY_NETWORK && CONFIG_SECURITY_PATH */ + #ifdef CONFIG_SECURITY_INFINIBAND /** * security_ib_pkey_access() - Check if access to an IB pkey is allowed -- 2.53.0