From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: gongfan1@huawei.com, cai.huoqing@linux.dev,
andrew+netdev@lunn.ch, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
alok.a.tiwarilinux@gmail.com
Subject: Re: [PATCH net-next 1/2] net: huawei: hinic: correct IPv6 version check in TX checksum path
Date: Mon, 23 Mar 2026 17:11:49 +0000 [thread overview]
Message-ID: <20260323171149.GA111839@horms.kernel.org> (raw)
In-Reply-To: <20260321165238.647948-1-alok.a.tiwari@oracle.com>
On Sat, Mar 21, 2026 at 09:52:33AM -0700, Alok Tiwari wrote:
> The TX checksum/offload code determines whether the network header is
> IPv4 or IPv6 by checking the version field. The IPv6 case incorrectly
> checked ip->v4->version for a value of 6. Use ip->v6->version instead to
> match the header type being parsed.
>
> Use ip->v6->version in the IPv6 case to match intent and improve
> readability.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Hi,
I see where you are going with this.
But I discovered sashiko.dev a bit earlier today and it's AI generated
review of this patch-set points out that the same pattern also exists in
offload_tso and offload_csum in this file.
And likewise, for patch 2/2, the pattern exists in get_inner_l3_l4_type()
as well as where you updated it in hinic3_tx_csum().
--
pw-bot: changes-requested
next prev parent reply other threads:[~2026-03-23 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 16:52 [PATCH net-next 1/2] net: huawei: hinic: correct IPv6 version check in TX checksum path Alok Tiwari
2026-03-21 16:52 ` [PATCH net-next 2/2] net: huawei: hinic3: " Alok Tiwari
2026-03-23 17:11 ` Simon Horman [this message]
2026-03-23 19:10 ` [PATCH net-next 1/2] net: huawei: hinic: " ALOK TIWARI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323171149.GA111839@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox