From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69B231C3BEB; Tue, 24 Mar 2026 00:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774312124; cv=none; b=A/I9jaJ7V1fFtpv+4sOseTm9dT0Vg82Ay0AgTR73sl0o4774rM8xWfZTzl7nsA+YIycXvBsLyUo7H+kEEt1lwqyKc9EhEswQA1PFgpzpLgrqAkKfynfoUe3tmkO0XnyBN4qBW6IGaArHw6NVoyzrrKRxwUNVkZQ7PrWQ6Ej9kAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774312124; c=relaxed/simple; bh=9herclzyLSdDJPAvj1pF7VT6VknWU1hHfB//c6M6wX0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Fme/8VzGCR5wasqVpynFZIzfHDL8qrzDSiX98wopfmSjbpI+KM52vlcmY5pVXngZsEp2Nl6jP6dBSY7g21tDEliDbK2ccwxUs3X99KH8aslMTf8W8utw4mfCTv0Y0U6lMB/0AkaxTD4sA3uaPipCKQTaRs0Y19KiyF1MfSIGNSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ql+gcM9T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ql+gcM9T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B84C4C2BC9E; Tue, 24 Mar 2026 00:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774312124; bh=9herclzyLSdDJPAvj1pF7VT6VknWU1hHfB//c6M6wX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ql+gcM9TQ7MjumZcWjxzu6dYO5NKwG4kpPAYCu7fmHZR9hMKDCHLcYWIsf9pAphJj DIjL8fgtJWlfJS/emvVfgnufD+XLcPZygCtxjni6DCmnB3tsxOdbWeQvSGR9w+ODxB Y+CyThvnfZ2OQfFSWbCBC1KW8MnrlifwGqqXr03rx7AfIJ6CJQ+2SJcNIvRvNFDam2 v0OodSHlORij7iAVfMmS9w+J1IchVXTrLlWUDvIlgAIAbQWKx1VKJE4LmMzGZMieGl Dp7sHacrvam0w9UZtpQUNxpeGKesiN9Jf7GjxXPMP4UfAJXC+v9xL+FnYCptIMpQQp wmn3OQXbdJ/zA== Date: Mon, 23 Mar 2026 17:28:42 -0700 From: Jakub Kicinski To: Wei Fang Cc: Buday Csaba , Frank Li , Shenwei Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Bence =?UTF-8?B?Q3PDs2vDoXM=?= , Francesco Dolcini , "imx@lists.linux.dev" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net v2 1/1] net: fec: fix the PTP periodic output sysfs interface Message-ID: <20260323172842.7a62979d@kernel.org> In-Reply-To: References: <7012fbf90b844083d5fa7d764ed6372fe0288157.1773928309.git.buday.csaba@prolan.hu> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 23 Mar 2026 12:54:46 +0000 Wei Fang wrote: > > When the PPS channel configuration was implemented, the number of > > supported periodic outputs (`n_per_out`) was left at 1. > > > > This prohibits using channels 1..3 from the sysfs interface, since > > period_store() rejects channel numbers greater than `n_per_out`. > > > > Fix by increasing `n_per_out` to the number of channels supported > > by the hardware. > > > > Fixes: 566c2d83887f ("net: fec: make PPS channel configurable") > > Signed-off-by: Buday Csaba > > --- > > drivers/net/ethernet/freescale/fec_ptp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/freescale/fec_ptp.c > > b/drivers/net/ethernet/freescale/fec_ptp.c > > index 4b7bad9a485d..1a7aa280e7f6 100644 > > --- a/drivers/net/ethernet/freescale/fec_ptp.c > > +++ b/drivers/net/ethernet/freescale/fec_ptp.c > > @@ -756,7 +756,7 @@ void fec_ptp_init(struct platform_device *pdev, int > > irq_idx) > > fep->ptp_caps.max_adj = 250000000; > > fep->ptp_caps.n_alarm = 0; > > fep->ptp_caps.n_ext_ts = 0; > > - fep->ptp_caps.n_per_out = 1; > > + fep->ptp_caps.n_per_out = 4; > > fep->ptp_caps.n_pins = 0; > > fep->ptp_caps.pps = 1; > > fep->ptp_caps.adjfine = fec_ptp_adjfine; > > > Reviewed-by: Wei Fang I don't understand why you think that we should be exposing 4 channels to the user when they can only use one. And have the user guess which one should be programmed. Please explain (and Buday will have to update the commit message), to me v1 looked like a much better fix. -- pw-bot: cr