From: kernel test robot <lkp@intel.com>
To: Daniel Golle <daniel@makrotopia.org>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, Frank Wunderlich <frankwu@gmx.de>,
Chad Monroe <chad@monroe.io>,
Cezary Wilmanski <cezary.wilmanski@adtran.com>,
Liang Xu <lxu@maxlinear.com>,
"Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
Jose Maria Verdu Munoz <jverdu@maxlinear.com>,
Avinash Jayaraman <ajayaraman@maxlinear.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper
Date: Mon, 23 Mar 2026 18:39:49 +0800 [thread overview]
Message-ID: <202603231807.3CRfrjTg-lkp@intel.com> (raw)
In-Reply-To: <ff936ce4ad3044102c367c55e7a455ab0020e4b7.1774136876.git.daniel@makrotopia.org>
Hi Daniel,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/net-dsa-add-driver-private-pointer-to-struct-dsa_bridge/20260323-041502
base: net-next/main
patch link: https://lore.kernel.org/r/ff936ce4ad3044102c367c55e7a455ab0020e4b7.1774136876.git.daniel%40makrotopia.org
patch subject: [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper
config: arm-randconfig-002-20260323 (https://download.01.org/0day-ci/archive/20260323/202603231807.3CRfrjTg-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project c911b8492374942bf4cfe35411e90a35d3837f6a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260323/202603231807.3CRfrjTg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603231807.3CRfrjTg-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/dsa/yt921x.c:2158:1: error: conflicting types for 'dsa_bridge_ports'
2158 | dsa_bridge_ports(struct dsa_switch *ds, const struct net_device *bdev)
| ^
include/net/dsa.h:845:19: note: previous definition is here
845 | static inline u32 dsa_bridge_ports(struct dsa_switch *ds,
| ^
>> drivers/net/dsa/yt921x.c:2213:38: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'const struct dsa_bridge *' [-Wincompatible-pointer-types]
2213 | ports_mask = dsa_bridge_ports(ds, bdev);
| ^~~~
include/net/dsa.h:846:33: note: passing argument to parameter 'bridge' here
846 | const struct dsa_bridge *bridge)
| ^
drivers/net/dsa/yt921x.c:2285:36: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'const struct dsa_bridge *' [-Wincompatible-pointer-types]
2285 | ports_mask = dsa_bridge_ports(ds, bridge.dev);
| ^~~~~~~~~~
include/net/dsa.h:846:33: note: passing argument to parameter 'bridge' here
846 | const struct dsa_bridge *bridge)
| ^
3 errors generated.
vim +/dsa_bridge_ports +2158 drivers/net/dsa/yt921x.c
186623f4aa724c David Yang 2025-10-17 2156
186623f4aa724c David Yang 2025-10-17 2157 static u32
186623f4aa724c David Yang 2025-10-17 @2158 dsa_bridge_ports(struct dsa_switch *ds, const struct net_device *bdev)
186623f4aa724c David Yang 2025-10-17 2159 {
186623f4aa724c David Yang 2025-10-17 2160 struct dsa_port *dp;
186623f4aa724c David Yang 2025-10-17 2161 u32 mask = 0;
186623f4aa724c David Yang 2025-10-17 2162
186623f4aa724c David Yang 2025-10-17 2163 dsa_switch_for_each_user_port(dp, ds)
186623f4aa724c David Yang 2025-10-17 2164 if (dsa_port_offloads_bridge_dev(dp, bdev))
186623f4aa724c David Yang 2025-10-17 2165 mask |= BIT(dp->index);
186623f4aa724c David Yang 2025-10-17 2166
186623f4aa724c David Yang 2025-10-17 2167 return mask;
186623f4aa724c David Yang 2025-10-17 2168 }
186623f4aa724c David Yang 2025-10-17 2169
186623f4aa724c David Yang 2025-10-17 2170 static int
186623f4aa724c David Yang 2025-10-17 2171 yt921x_bridge_flags(struct yt921x_priv *priv, int port,
186623f4aa724c David Yang 2025-10-17 2172 struct switchdev_brport_flags flags)
186623f4aa724c David Yang 2025-10-17 2173 {
186623f4aa724c David Yang 2025-10-17 2174 struct yt921x_port *pp = &priv->ports[port];
186623f4aa724c David Yang 2025-10-17 2175 bool do_flush;
186623f4aa724c David Yang 2025-10-17 2176 u32 mask;
186623f4aa724c David Yang 2025-10-17 2177 int res;
186623f4aa724c David Yang 2025-10-17 2178
186623f4aa724c David Yang 2025-10-17 2179 if (flags.mask & BR_LEARNING) {
186623f4aa724c David Yang 2025-10-17 2180 bool learning = flags.val & BR_LEARNING;
186623f4aa724c David Yang 2025-10-17 2181
186623f4aa724c David Yang 2025-10-17 2182 mask = YT921X_PORT_LEARN_DIS;
186623f4aa724c David Yang 2025-10-17 2183 res = yt921x_reg_toggle_bits(priv, YT921X_PORTn_LEARN(port),
186623f4aa724c David Yang 2025-10-17 2184 mask, !learning);
186623f4aa724c David Yang 2025-10-17 2185 if (res)
186623f4aa724c David Yang 2025-10-17 2186 return res;
186623f4aa724c David Yang 2025-10-17 2187 }
186623f4aa724c David Yang 2025-10-17 2188
186623f4aa724c David Yang 2025-10-17 2189 /* BR_FLOOD, BR_MCAST_FLOOD: see the comment where ACT_UNK_ACTn_TRAP
186623f4aa724c David Yang 2025-10-17 2190 * is set
186623f4aa724c David Yang 2025-10-17 2191 */
186623f4aa724c David Yang 2025-10-17 2192
186623f4aa724c David Yang 2025-10-17 2193 /* BR_BCAST_FLOOD: we can filter bcast, but cannot trap them */
186623f4aa724c David Yang 2025-10-17 2194
186623f4aa724c David Yang 2025-10-17 2195 do_flush = false;
186623f4aa724c David Yang 2025-10-17 2196 if (flags.mask & BR_HAIRPIN_MODE) {
186623f4aa724c David Yang 2025-10-17 2197 pp->hairpin = flags.val & BR_HAIRPIN_MODE;
186623f4aa724c David Yang 2025-10-17 2198 do_flush = true;
186623f4aa724c David Yang 2025-10-17 2199 }
186623f4aa724c David Yang 2025-10-17 2200 if (flags.mask & BR_ISOLATED) {
186623f4aa724c David Yang 2025-10-17 2201 pp->isolated = flags.val & BR_ISOLATED;
186623f4aa724c David Yang 2025-10-17 2202 do_flush = true;
186623f4aa724c David Yang 2025-10-17 2203 }
186623f4aa724c David Yang 2025-10-17 2204 if (do_flush) {
186623f4aa724c David Yang 2025-10-17 2205 struct dsa_switch *ds = &priv->ds;
186623f4aa724c David Yang 2025-10-17 2206 struct dsa_port *dp = dsa_to_port(ds, port);
186623f4aa724c David Yang 2025-10-17 2207 struct net_device *bdev;
186623f4aa724c David Yang 2025-10-17 2208
186623f4aa724c David Yang 2025-10-17 2209 bdev = dsa_port_bridge_dev_get(dp);
186623f4aa724c David Yang 2025-10-17 2210 if (bdev) {
186623f4aa724c David Yang 2025-10-17 2211 u32 ports_mask;
186623f4aa724c David Yang 2025-10-17 2212
186623f4aa724c David Yang 2025-10-17 @2213 ports_mask = dsa_bridge_ports(ds, bdev);
186623f4aa724c David Yang 2025-10-17 2214 ports_mask |= priv->cpu_ports_mask;
186623f4aa724c David Yang 2025-10-17 2215 res = yt921x_bridge(priv, ports_mask);
186623f4aa724c David Yang 2025-10-17 2216 if (res)
186623f4aa724c David Yang 2025-10-17 2217 return res;
186623f4aa724c David Yang 2025-10-17 2218 }
186623f4aa724c David Yang 2025-10-17 2219 }
186623f4aa724c David Yang 2025-10-17 2220
186623f4aa724c David Yang 2025-10-17 2221 return 0;
186623f4aa724c David Yang 2025-10-17 2222 }
186623f4aa724c David Yang 2025-10-17 2223
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-03-23 10:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 0:18 [PATCH net-next v6 0/4] net: dsa: mxl862xx: add support for bridge offloading Daniel Golle
2026-03-22 0:18 ` [PATCH net-next v6 1/4] net: dsa: add driver-private pointer to struct dsa_bridge Daniel Golle
2026-03-23 16:12 ` Vladimir Oltean
2026-03-22 0:19 ` [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper Daniel Golle
2026-03-23 2:29 ` Daniel Golle
2026-03-23 16:31 ` Vladimir Oltean
2026-03-23 16:45 ` Daniel Golle
2026-03-23 21:15 ` Vladimir Oltean
2026-03-23 21:47 ` Daniel Golle
2026-03-24 23:31 ` Daniel Golle
2026-03-25 8:34 ` Vladimir Oltean
2026-03-25 10:43 ` Daniel Golle
2026-03-23 10:39 ` kernel test robot [this message]
2026-03-24 20:58 ` kernel test robot
2026-03-22 0:19 ` [PATCH net-next v6 3/4] dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark() Daniel Golle
2026-03-22 0:19 ` [PATCH net-next v6 4/4] net: dsa: mxl862xx: implement bridge offloading Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603231807.3CRfrjTg-lkp@intel.com \
--to=lkp@intel.com \
--cc=ajayaraman@maxlinear.com \
--cc=andrew@lunn.ch \
--cc=cezary.wilmanski@adtran.com \
--cc=chad@monroe.io \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frankwu@gmx.de \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=jverdu@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox