From: Joe Damato <joe@dama.to>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: horms@kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org,
leon@kernel.org, Joe Damato <joe@dama.to>
Subject: [net-next v5 11/12] net: netdevsim: Add support for SW USO
Date: Mon, 23 Mar 2026 11:38:36 -0700 [thread overview]
Message-ID: <20260323183844.3146982-12-joe@dama.to> (raw)
In-Reply-To: <20260323183844.3146982-1-joe@dama.to>
Add support for UDP Segmentation Offloading in software (SW USO). This
is helpful for testing when real hardware is not available. A test which
uses this codepath will be added in a following commit.
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Joe Damato <joe@dama.to>
---
v5:
- Added Pavan's Reviewed-by. No functional changes.
v4:
- Added parentheses around the gso_type check for clarity. No functional
change.
rfcv2:
- new in rfcv2
drivers/net/netdevsim/netdev.c | 100 ++++++++++++++++++++++++++++++++-
1 file changed, 99 insertions(+), 1 deletion(-)
diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c
index c71b8d116f18..f228bcf3d190 100644
--- a/drivers/net/netdevsim/netdev.c
+++ b/drivers/net/netdevsim/netdev.c
@@ -30,6 +30,7 @@
#include <net/rtnetlink.h>
#include <net/udp_tunnel.h>
#include <net/busy_poll.h>
+#include <net/tso.h>
#include "netdevsim.h"
@@ -120,6 +121,98 @@ static int nsim_forward_skb(struct net_device *tx_dev,
return nsim_napi_rx(tx_dev, rx_dev, rq, skb);
}
+static netdev_tx_t nsim_uso_segment_xmit(struct net_device *dev,
+ struct sk_buff *skb)
+{
+ unsigned int hdr_len, mss, total_payload, num_segs;
+ struct netdevsim *ns = netdev_priv(dev);
+ struct net_device *peer_dev;
+ unsigned int total_len = 0;
+ struct netdevsim *peer_ns;
+ struct nsim_rq *rq;
+ struct tso_t tso;
+ int i, rxq;
+
+ hdr_len = tso_start(skb, &tso);
+ mss = skb_shinfo(skb)->gso_size;
+ total_payload = skb->len - hdr_len;
+ num_segs = DIV_ROUND_UP(total_payload, mss);
+
+ udp_hdr(skb)->check = 0;
+ if (!tso.ipv6)
+ ip_hdr(skb)->check = 0;
+
+ rcu_read_lock();
+ peer_ns = rcu_dereference(ns->peer);
+ if (!peer_ns)
+ goto out_drop_free;
+
+ peer_dev = peer_ns->netdev;
+ rxq = skb_get_queue_mapping(skb);
+ if (rxq >= peer_dev->num_rx_queues)
+ rxq = rxq % peer_dev->num_rx_queues;
+ rq = peer_ns->rq[rxq];
+
+ for (i = 0; i < num_segs; i++) {
+ unsigned int seg_payload = min_t(unsigned int, mss,
+ total_payload);
+ bool last = (i == num_segs - 1);
+ unsigned int seg_remaining;
+ struct sk_buff *seg;
+
+ seg = alloc_skb(hdr_len + seg_payload, GFP_ATOMIC);
+ if (!seg)
+ break;
+
+ seg->dev = dev;
+
+ tso_build_hdr(skb, skb_put(seg, hdr_len), &tso,
+ seg_payload, last);
+
+ if (!tso.ipv6) {
+ unsigned int nh_off = skb_network_offset(skb);
+ struct iphdr *iph;
+
+ iph = (struct iphdr *)(seg->data + nh_off);
+ iph->check = ip_fast_csum(iph, iph->ihl);
+ }
+
+ seg_remaining = seg_payload;
+ while (seg_remaining > 0) {
+ unsigned int chunk = min_t(unsigned int, tso.size,
+ seg_remaining);
+
+ memcpy(skb_put(seg, chunk), tso.data, chunk);
+ tso_build_data(skb, &tso, chunk);
+ seg_remaining -= chunk;
+ }
+
+ total_payload -= seg_payload;
+
+ seg->ip_summed = CHECKSUM_UNNECESSARY;
+
+ if (nsim_forward_skb(dev, peer_dev, seg, rq, NULL) == NET_RX_DROP)
+ continue;
+
+ total_len += hdr_len + seg_payload;
+ }
+
+ if (!hrtimer_active(&rq->napi_timer))
+ hrtimer_start(&rq->napi_timer, us_to_ktime(5),
+ HRTIMER_MODE_REL);
+
+ rcu_read_unlock();
+ dev_kfree_skb(skb);
+ dev_dstats_tx_add(dev, total_len);
+ return NETDEV_TX_OK;
+
+out_drop_free:
+ dev_kfree_skb(skb);
+ rcu_read_unlock();
+ dev_dstats_tx_dropped(dev);
+ return NETDEV_TX_OK;
+}
+
static netdev_tx_t nsim_start_xmit(struct sk_buff *skb, struct net_device *dev)
{
struct netdevsim *ns = netdev_priv(dev);
@@ -132,6 +225,10 @@ static netdev_tx_t nsim_start_xmit(struct sk_buff *skb, struct net_device *dev)
int rxq;
int dr;
+ if (skb_is_gso(skb) &&
+ skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
+ return nsim_uso_segment_xmit(dev, skb);
+
rcu_read_lock();
if (!nsim_ipsec_tx(ns, skb))
goto out_drop_any;
@@ -938,7 +1035,8 @@ static void nsim_setup(struct net_device *dev)
NETIF_F_HW_CSUM |
NETIF_F_LRO |
NETIF_F_TSO |
- NETIF_F_LOOPBACK;
+ NETIF_F_LOOPBACK |
+ NETIF_F_GSO_UDP_L4;
dev->pcpu_stat_type = NETDEV_PCPU_STAT_DSTATS;
dev->max_mtu = ETH_MAX_MTU;
dev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_HW_OFFLOAD;
--
2.52.0
next prev parent reply other threads:[~2026-03-23 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 18:38 [net-next v5 00/12] Add TSO map-once DMA helpers and bnxt SW USO support Joe Damato
2026-03-23 18:38 ` [net-next v5 01/12] net: tso: Introduce tso_dma_map Joe Damato
2026-03-23 18:38 ` [net-next v5 02/12] net: tso: Add tso_dma_map helpers Joe Damato
2026-03-23 18:38 ` [net-next v5 03/12] net: bnxt: Export bnxt_xmit_get_cfa_action Joe Damato
2026-03-23 18:38 ` [net-next v5 04/12] net: bnxt: Add a helper for tx_bd_ext Joe Damato
2026-03-23 18:38 ` [net-next v5 05/12] net: bnxt: Use dma_unmap_len for TX completion unmapping Joe Damato
2026-03-23 18:38 ` [net-next v5 06/12] net: bnxt: Add TX inline buffer infrastructure Joe Damato
2026-03-23 18:38 ` [net-next v5 07/12] net: bnxt: Add boilerplate GSO code Joe Damato
2026-03-23 18:38 ` [net-next v5 08/12] net: bnxt: Implement software USO Joe Damato
2026-03-23 18:38 ` [net-next v5 09/12] net: bnxt: Add SW GSO completion and teardown support Joe Damato
2026-03-26 12:39 ` Paolo Abeni
2026-03-23 18:38 ` [net-next v5 10/12] net: bnxt: Dispatch to SW USO Joe Damato
2026-03-23 18:38 ` Joe Damato [this message]
2026-03-23 18:38 ` [net-next v5 12/12] selftests: drv-net: Add USO test Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323183844.3146982-12-joe@dama.to \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox