From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 988E631327F for ; Mon, 23 Mar 2026 18:39:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774291158; cv=none; b=OLkblx3sYMynsWeHV/CB7ix19J/iUJ+eF8XxW1HpLbWZpbQWM0ylIXxYAhV2j3ZGhwo5ybP1lfxDQNUBtr08aRfGJK9CutC6XVpaTFZe98NZqffQidKuQFlz/9iOmLb8XRIyTSq5UIYvRuJz7YNbIPEhCGlHXFbB7u63TAdUlvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774291158; c=relaxed/simple; bh=HtDcextZUR/YPcgIMnOZtvtxd0jwbtm6Ak5Sth33ogo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L3rT5T/O0Lb55GB5EsguB/4xnC+URd3dRrwrCot6rspIEQ2t+Yj68wZz2tnyk3wbUJSAuj703T6TXDCJDFKPvdYlRQQOwtAtW/+e4lTWHGqEhXG8NPilS8pNXVlDBVtvfW2N2vHw/pTnFlysUcVpjrHiYO5oqYjvspgvVF6KgUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=tiBDfMKm; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="tiBDfMKm" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82418b0178cso280140b3a.1 for ; Mon, 23 Mar 2026 11:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774291153; x=1774895953; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sgC2gqkZaDT8s1RV7I0kqk405vgv8rZzFFbIUkMM2/c=; b=tiBDfMKmyfrYt9k3v5e8JPzhNyUVaDpWtN2BupizXi/FKg5LS+DrU8u0nGMtwqDHdB umnYhgpJOt04JlXfw3uAeoNieMfzUtNf9lWUow6Hi4uljRPOxdMr0vyE+0ujYL6KfNKq D9gjI/bz1otOSEoyT1OD5T8BCkyDoy5B94upPo/NZC7DqJzttVSuhKGujryKUbdpq4kl 0K2PxG4mH4LIgqmZNYZztPqhPZsv2KepeoXwuvXKSdQyKATsmP/8RijeBZuardZZ4klf YrYtedjsyzVpC4HrS8f8c8/Eh6DZfq0Tvjv+mV4wj2K5Wlceu3zu30TGT7bMkyyp7vA+ 8zGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774291153; x=1774895953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sgC2gqkZaDT8s1RV7I0kqk405vgv8rZzFFbIUkMM2/c=; b=mhK0i1orRcVwV0copnSlghPLD2OxKRT3cPV4Onhp1Ohof5pdpWvkXrPYIUXZL5o/9+ frg2CyupkfPn2DcZSllROlaxfESENXInIrZbo8Q+T271+ZBS2nkqD8vhvX9DfzgZq2+j ISFzZilsZlHOgTHMZMnIK1pnfq5rGN6nNZKnvIEv5toV0bSgLokSGPd+rNBXc5rz7q9I CHQKXYlQ20zEuEnwvXYmymk1hQjEVeSwj0TLMey/hr9BUweVoBPrqJAAVe6SAXkAy1nw 69v1z+AZ74HaoPXquY6aBjF/rVf143uA4JDmC6WXvQQnSH6W1sQj8tUhTG2DwhGOKCWo R5ww== X-Gm-Message-State: AOJu0YzWTEiBettMfCfRdhT/AG1hPdQiIqZzFkzPNuZph79FmbBn41su JMcb8Hdl5aMKbgG6g6Mn4tCNv8pHSKws1KLdioNhV2oilWMLx/zA+ocLmEUdy2EMy7fEojH/Ji6 uOCkX4tQ= X-Gm-Gg: ATEYQzwqRUhiQnHPZQjR163Gpdc+aFszgT7BCRaKGjfrYCrGmrPBz0qPJhlSsowP00T ea3PfYT010Lm0RKBWx3FizDtTqn1cc9vet3+tNl0lyZxr7ygJEEkFYMe8d4DM2Ve+r//Mr0LK0G 695sfyiGzENHlOIFH+1Jusnh9XlJF2bztN25Upv3f4Z3+y/b4GkwvrbE8l9LpE15BO4rUXObxHh wyK8iXeQYr1gobd9fx0Cx9RLCrfCEFCEQ7bWzzuAd0mHo1gDcjZJqtQ4YPb7xTuIZRE2R2k3AHY LJzQi9Yq9BZd0WjkHY63KWGvkR163thWnRLG4KNrhcL6SHeo1VqRa+wwIdFOgikXWYj48UbnoRD RKjslvPr0VDgtAC1ZtF+Mj0pYkbwkSjJa4ldMo/5HITOWxjc7TlZlDEHa46qgepAQRPDxkwLskt XQCrPtJX550HKDaA== X-Received: by 2002:a05:6a00:91a6:b0:82a:e3de:27c2 with SMTP id d2e1a72fcca58-82ae3de2ff0mr8957916b3a.41.1774291153012; Mon, 23 Mar 2026 11:39:13 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:4::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b03aaabdesm10375094b3a.5.2026.03.23.11.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 11:39:12 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato , bpf@vger.kernel.org Subject: [net-next v5 07/12] net: bnxt: Add boilerplate GSO code Date: Mon, 23 Mar 2026 11:38:32 -0700 Message-ID: <20260323183844.3146982-8-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260323183844.3146982-1-joe@dama.to> References: <20260323183844.3146982-1-joe@dama.to> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add bnxt_gso.c and bnxt_gso.h with a stub bnxt_sw_udp_gso_xmit() function, SW USO constants (BNXT_SW_USO_MAX_SEGS, BNXT_SW_USO_MAX_DESCS), and the is_sw_gso field in bnxt_sw_tx_bd with BNXT_SW_GSO_MID/LAST markers. The full SW USO implementation will be added in a future commit. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v5: - Added Pavan's Reviewed-by. No functional changes. drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c | 30 ++++++++++++++++++ drivers/net/ethernet/broadcom/bnxt/bnxt_gso.h | 31 +++++++++++++++++++ 4 files changed, 66 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_gso.h diff --git a/drivers/net/ethernet/broadcom/bnxt/Makefile b/drivers/net/ethernet/broadcom/bnxt/Makefile index ba6c239d52fa..debef78c8b6d 100644 --- a/drivers/net/ethernet/broadcom/bnxt/Makefile +++ b/drivers/net/ethernet/broadcom/bnxt/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only obj-$(CONFIG_BNXT) += bnxt_en.o -bnxt_en-y := bnxt.o bnxt_hwrm.o bnxt_sriov.o bnxt_ethtool.o bnxt_dcb.o bnxt_ulp.o bnxt_xdp.o bnxt_ptp.o bnxt_vfr.o bnxt_devlink.o bnxt_dim.o bnxt_coredump.o +bnxt_en-y := bnxt.o bnxt_hwrm.o bnxt_sriov.o bnxt_ethtool.o bnxt_dcb.o bnxt_ulp.o bnxt_xdp.o bnxt_ptp.o bnxt_vfr.o bnxt_devlink.o bnxt_dim.o bnxt_coredump.o bnxt_gso.o bnxt_en-$(CONFIG_BNXT_FLOWER_OFFLOAD) += bnxt_tc.o bnxt_en-$(CONFIG_DEBUG_FS) += bnxt_debugfs.o bnxt_en-$(CONFIG_BNXT_HWMON) += bnxt_hwmon.o diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h index 751dbc055fdd..18b08789b3a4 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -891,6 +891,7 @@ struct bnxt_sw_tx_bd { u8 is_ts_pkt; u8 is_push; u8 action; + u8 is_sw_gso; unsigned short nr_frags; union { u16 rx_prod; @@ -898,6 +899,9 @@ struct bnxt_sw_tx_bd { }; }; +#define BNXT_SW_GSO_MID 1 +#define BNXT_SW_GSO_LAST 2 + struct bnxt_sw_rx_bd { void *data; u8 *data_ptr; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c new file mode 100644 index 000000000000..b296769ee4fe --- /dev/null +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* Broadcom NetXtreme-C/E network driver. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "bnxt.h" +#include "bnxt_gso.h" + +netdev_tx_t bnxt_sw_udp_gso_xmit(struct bnxt *bp, + struct bnxt_tx_ring_info *txr, + struct netdev_queue *txq, + struct sk_buff *skb) +{ + dev_kfree_skb_any(skb); + dev_core_stats_tx_dropped_inc(bp->dev); + return NETDEV_TX_OK; +} diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.h new file mode 100644 index 000000000000..f01e8102dcd7 --- /dev/null +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.h @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Broadcom NetXtreme-C/E network driver. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation. + */ + +#ifndef BNXT_GSO_H +#define BNXT_GSO_H + +/* Maximum segments the stack may send in a single SW USO skb. + * This caps gso_max_segs for NICs without HW USO support. + */ +#define BNXT_SW_USO_MAX_SEGS 64 + +/* Worst-case TX descriptors consumed by one SW USO packet: + * Each segment: 1 long BD + 1 ext BD + payload BDs. + * Total payload BDs across all segs <= num_segs + nr_frags (each frag + * boundary crossing adds at most 1 extra BD). + * So: 3 * max_segs + MAX_SKB_FRAGS + 1 = 3 * 64 + 17 + 1 = 210. + */ +#define BNXT_SW_USO_MAX_DESCS (3 * BNXT_SW_USO_MAX_SEGS + MAX_SKB_FRAGS + 1) + +netdev_tx_t bnxt_sw_udp_gso_xmit(struct bnxt *bp, + struct bnxt_tx_ring_info *txr, + struct netdev_queue *txq, + struct sk_buff *skb); + +#endif -- 2.52.0