* [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
@ 2026-03-13 13:06 Biju
2026-03-19 0:05 ` Jakub Kicinski
2026-03-23 19:48 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Biju @ 2026-03-13 13:06 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiner Kallweit, Niklas Söderlund, Geert Uytterhoeven,
Magnus Damm
Cc: Biju Das, Russell King, Paul Barker, Neil Armstrong,
Florian Fainelli, Lad Prabhakar, Sergei Shtylyov, netdev,
devicetree, linux-kernel, linux-renesas-soc, Biju Das
From: Biju Das <biju.das.jz@bp.renesas.com>
Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet PHY
bindings and their examples. The c22 fallback is implicitly assumed for
PHY ID-based compatible strings and does not need to be stated explicitly,
unlike c45 which requires opt-in.
Remove the c22 pattern from the ethernet-phy.yaml schema and update
examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
and renesas,etheravb bindings accordingly.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
.../devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml | 3 +--
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 3 ---
Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml | 3 +--
Documentation/devicetree/bindings/net/renesas,ether.yaml | 3 +--
Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 3 +--
5 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml b/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml
index ec5c038ce6a0..e9e575fab62c 100644
--- a/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml
+++ b/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml
@@ -69,8 +69,7 @@ examples:
#size-cells = <0>;
ethernet-phy@8 {
- compatible = "ethernet-phy-id0180.3301",
- "ethernet-phy-ieee802.3-c22";
+ compatible = "ethernet-phy-id0180.3301";
interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
reg = <8>;
max-speed = <100>;
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 58634fee9fc4..d622e73a89ff 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -47,9 +47,6 @@ properties:
second group of digits is the Phy Identifier 2 register,
this is the chip vendor OUI bits 19:24, followed by 10
bits of a vendor specific ID.
- - items:
- - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
- - const: ethernet-phy-ieee802.3-c22
- items:
- pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
- const: ethernet-phy-ieee802.3-c45
diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
index 0afbd0ff126f..5e5dea7987e7 100644
--- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
+++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
@@ -32,7 +32,6 @@ properties:
- enum:
- ethernet-phy-id0007.0570 # VSC8531
- ethernet-phy-id0007.0772 # VSC8541
- - const: ethernet-phy-ieee802.3-c22
vsc8531,vddmac:
$ref: /schemas/types.yaml#/definitions/uint32
@@ -120,7 +119,7 @@ examples:
#size-cells = <0>;
ethernet-phy@0 {
- compatible = "ethernet-phy-id0007.0772", "ethernet-phy-ieee802.3-c22";
+ compatible = "ethernet-phy-id0007.0772";
reg = <0>;
vsc8531,vddmac = <3300>;
vsc8531,edge-slowdown = <7>;
diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml
index f0a52f47f95a..dd7187f12a67 100644
--- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
@@ -121,8 +121,7 @@ examples:
#size-cells = <0>;
phy1: ethernet-phy@1 {
- compatible = "ethernet-phy-id0022.1537",
- "ethernet-phy-ieee802.3-c22";
+ compatible = "ethernet-phy-id0022.1537";
reg = <1>;
interrupt-parent = <&irqc0>;
interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
index 1e00ef5b3acd..6aea1acaaa59 100644
--- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
@@ -364,8 +364,7 @@ examples:
#size-cells = <0>;
phy0: ethernet-phy@0 {
- compatible = "ethernet-phy-id0022.1622",
- "ethernet-phy-ieee802.3-c22";
+ compatible = "ethernet-phy-id0022.1622";
rxc-skew-ps = <1500>;
reg = <0>;
interrupt-parent = <&gpio2>;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
2026-03-13 13:06 [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback Biju
@ 2026-03-19 0:05 ` Jakub Kicinski
2026-03-19 14:38 ` Biju Das
2026-03-23 19:48 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2026-03-19 0:05 UTC (permalink / raw)
To: Biju
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiner Kallweit,
Niklas Söderlund, Geert Uytterhoeven, Magnus Damm, Biju Das,
Russell King, Paul Barker, Neil Armstrong, Florian Fainelli,
Lad Prabhakar, Sergei Shtylyov, netdev, devicetree, linux-kernel,
linux-renesas-soc
On Fri, 13 Mar 2026 13:06:21 +0000 Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet PHY
> bindings and their examples. The c22 fallback is implicitly assumed for
> PHY ID-based compatible strings and does not need to be stated explicitly,
> unlike c45 which requires opt-in.
>
> Remove the c22 pattern from the ethernet-phy.yaml schema and update
> examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
> and renesas,etheravb bindings accordingly.
Maybe a noob question but why are you not updating all the other ones?
$ git grep --files-with-matches 'ethernet-phy-ieee802.3-c22' -- \
Documentation/devicetree/bindings/net/ | \
wc -l
16
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
2026-03-19 0:05 ` Jakub Kicinski
@ 2026-03-19 14:38 ` Biju Das
2026-03-19 14:50 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Biju Das @ 2026-03-19 14:38 UTC (permalink / raw)
To: Jakub Kicinski, Rob Herring
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiner Kallweit,
niklas.soderlund, Geert Uytterhoeven, magnus.damm, Russell King,
Paul Barker, Neil Armstrong, Florian Fainelli,
Prabhakar Mahadev Lad, Sergei Shtylyov, netdev@vger.kernel.org,
devicetree@vger.kernel.org, biju.das.au,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Hi Jakub Kicinski,
Thanks for the feedback.
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 19 March 2026 00:05
> Subject: Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
>
> On Fri, 13 Mar 2026 13:06:21 +0000 Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet
> > PHY bindings and their examples. The c22 fallback is implicitly
> > assumed for PHY ID-based compatible strings and does not need to be
> > stated explicitly, unlike c45 which requires opt-in.
> >
> > Remove the c22 pattern from the ethernet-phy.yaml schema and update
> > examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
> > and renesas,etheravb bindings accordingly.
>
> Maybe a noob question but why are you not updating all the other ones?
>
> $ git grep --files-with-matches 'ethernet-phy-ieee802.3-c22' -- \
> Documentation/devicetree/bindings/net/ | \
> wc -l
> 16
The other files have only 'compatible = "ethernet-phy-ieee802.3-c22"'
Whereas this patch removes the fallback pattern based on
Rob's suggestion [1]
compatible = "ethernet-phy-id0022.1622",
"ethernet-phy-ieee802.3-c22";
Please let me know, should I drop all 'ethernet-phy-ieee802.3-c22' compatibles?
[1] https://lore.kernel.org/all/CAL_JsqJK3brXxSeD-U42PBCeHoxUhWJYho3ZWj__t5C1LL-n-Q@mail.gmail.com/
Cheers,
Biju
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
2026-03-19 14:38 ` Biju Das
@ 2026-03-19 14:50 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2026-03-19 14:50 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Andrew Lunn, David S. Miller, Eric Dumazet,
Paolo Abeni, Krzysztof Kozlowski, Conor Dooley, Heiner Kallweit,
niklas.soderlund, Geert Uytterhoeven, magnus.damm, Russell King,
Paul Barker, Neil Armstrong, Florian Fainelli,
Prabhakar Mahadev Lad, Sergei Shtylyov, netdev@vger.kernel.org,
devicetree@vger.kernel.org, biju.das.au,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
On Thu, 19 Mar 2026 14:38:37 +0000 Biju Das wrote:
> > Maybe a noob question but why are you not updating all the other ones?
> >
> > $ git grep --files-with-matches 'ethernet-phy-ieee802.3-c22' -- \
> > Documentation/devicetree/bindings/net/ | \
> > wc -l
> > 16
>
> The other files have only 'compatible = "ethernet-phy-ieee802.3-c22"'
>
> Whereas this patch removes the fallback pattern based on
> Rob's suggestion [1]
>
> compatible = "ethernet-phy-id0022.1622",
> "ethernet-phy-ieee802.3-c22";
Got it
> Please let me know, should I drop all 'ethernet-phy-ieee802.3-c22' compatibles?
No, let's wait for DT maintainers' review.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
2026-03-13 13:06 [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback Biju
2026-03-19 0:05 ` Jakub Kicinski
@ 2026-03-23 19:48 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2026-03-23 19:48 UTC (permalink / raw)
To: Biju
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Krzysztof Kozlowski, Conor Dooley, Heiner Kallweit,
Niklas Söderlund, Geert Uytterhoeven, Magnus Damm, Biju Das,
Russell King, Paul Barker, Neil Armstrong, Florian Fainelli,
Lad Prabhakar, Sergei Shtylyov, netdev, devicetree, linux-kernel,
linux-renesas-soc
On Fri, Mar 13, 2026 at 01:06:21PM +0000, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet PHY
> bindings and their examples. The c22 fallback is implicitly assumed for
> PHY ID-based compatible strings and does not need to be stated explicitly,
> unlike c45 which requires opt-in.
>
> Remove the c22 pattern from the ethernet-phy.yaml schema and update
> examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
> and renesas,etheravb bindings accordingly.
This will introduce a ton of warnings in .dts files which I don't think
anyone wants to go fix.
While I think it's redundant to have the c22 (or c45) fallback as it
isn't really useful on its own, I think we are too far down that path.
You need a custom 'select' in all the schemas that have a c22
compatible to exclude it from matching.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-23 19:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 13:06 [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback Biju
2026-03-19 0:05 ` Jakub Kicinski
2026-03-19 14:38 ` Biju Das
2026-03-19 14:50 ` Jakub Kicinski
2026-03-23 19:48 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox