From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08070382378; Tue, 24 Mar 2026 03:26:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774322765; cv=none; b=U7/hf1CTgioQa2I3sINnk8YR/X2whR2vBKm1fVAvVgfSVDVOMJlhEo2ejnMObDI1E642tt78gaqgL0NC6zJ+VOTDo+ZUvaMUx1pX5hwAKjuWlTsMABukz+fPhxW9h6Tsajw5l3iOADk5tFabnckL/UlWRxbm3dMIct0mwzKBIAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774322765; c=relaxed/simple; bh=dM8xcvzdCwGP0xEYUTAqBoCTq5vz7t0JFOfYavbXA0M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YvnNtuLLOOLO1Onw7Z1NVEPW6mQQAueQ/lmgewaSNzh77E90EnwMakuOyrNnsbT6pnmdo4hNuxSUPd76hDnqdxDn1gHWk7WnwaTYu/gZvKjG3T/F1aBTHDAvRkxtoS7xv2a5zx1HU0GpjW0gdaC9uBtZTv5Y8z4QMCT4oaFN3iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cto8vUuM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cto8vUuM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12008C19424; Tue, 24 Mar 2026 03:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774322764; bh=dM8xcvzdCwGP0xEYUTAqBoCTq5vz7t0JFOfYavbXA0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cto8vUuMLqYBM/NA3AfRulMTa8ydKlDxXVJVkojPdMuQKJRPnyp4LS5p4qPD6AY8p CLTWh1YY605CylZHdPLpvKUC5nzVkvSq26p95ojrZjxorSvyjeQd11po/kVF8iy/12 wA52DtZM9RJ8+DbJScg6WOF1pXg8v4tdUWYzirDureRZC1pV8igDx2U0W/pcPO6lVV EiLk3RHbYft/dbNlGf9BtJVSZ3MZybXCUWCO5bPjPj+2kudt1g4YTwcEFlpDi81fCE 9kEBfT8CAOemmTfKfTBnZaK4Ivypkki4vOwm32cTCPnI6wc0QjlCEoj4Py1ZOEkrgs fKzzcJ1nBgg3Q== Date: Mon, 23 Mar 2026 20:26:03 -0700 From: Jakub Kicinski To: Wei Fang Cc: Richard Cochran , Buday Csaba , Frank Li , Shenwei Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Bence =?UTF-8?B?Q3PDs2vDoXM=?= , Francesco Dolcini , "imx@lists.linux.dev" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net v2 1/1] net: fec: fix the PTP periodic output sysfs interface Message-ID: <20260323202603.2897abf4@kernel.org> In-Reply-To: References: <7012fbf90b844083d5fa7d764ed6372fe0288157.1773928309.git.buday.csaba@prolan.hu> <20260323172842.7a62979d@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 24 Mar 2026 02:36:55 +0000 Wei Fang wrote: > > > Reviewed-by: Wei Fang > > > > I don't understand why you think that we should be exposing 4 channels > > to the user when they can only use one. And have the user guess which > > one should be programmed. Please explain (and Buday will have to update > > the commit message), to me v1 looked like a much better fix. > > As I explained in v1, I think the "channel index" parameter of > "/sys/class/ptp/ptp/period" refers to the hardware channel number, > rather than the software mapping to the hardware channel. Can you cite any documentation or examples? What would be the benefit of exposing the ID within the MAC IP (not even the board) to the user? As I said the benefit of having just 1 is that user doesn't have to poke around to find out which one works. > Although the current driver only supports one channel for output, > the channel index should specify the correct hardware channel instead > of a fixed 0. Perhaps Richard could share his thoughts on the channel > index parameter.