public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] netdevsim: fix build if SKB_EXTENSIONS=n
@ 2026-03-24 14:08 Qingfang Deng
  2026-03-27  3:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Qingfang Deng @ 2026-03-24 14:08 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Wesley Atwell, Daniel Zahka, netdev, linux-kernel

__skb_ext_put() is not declared if SKB_EXTENSIONS is not enabled, which
causes a build error:

drivers/net/netdevsim/netdev.c: In function 'nsim_forward_skb':
drivers/net/netdevsim/netdev.c:114:25: error: implicit declaration of function '__skb_ext_put'; did you mean 'skb_ext_put'? [-Werror=implicit-function-declaration]
  114 |                         __skb_ext_put(psp_ext);
      |                         ^~~~~~~~~~~~~
      |                         skb_ext_put
cc1: some warnings being treated as errors

Add a stub to fix the build.

Fixes: 7d9351435ebb ("netdevsim: drop PSP ext ref on forward failure")
Signed-off-by: Qingfang Deng <dqfext@gmail.com>
---
 include/linux/skbuff.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 9cc98f850f1d..fbfa9852e82a 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -5106,6 +5106,7 @@ static inline bool skb_has_extensions(struct sk_buff *skb)
 	return unlikely(skb->active_extensions);
 }
 #else
+static inline void __skb_ext_put(struct skb_ext *ext) {}
 static inline void skb_ext_put(struct sk_buff *skb) {}
 static inline void skb_ext_reset(struct sk_buff *skb) {}
 static inline void skb_ext_del(struct sk_buff *skb, int unused) {}
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] netdevsim: fix build if SKB_EXTENSIONS=n
  2026-03-24 14:08 [PATCH net] netdevsim: fix build if SKB_EXTENSIONS=n Qingfang Deng
@ 2026-03-27  3:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-27  3:20 UTC (permalink / raw)
  To: Qingfang Deng
  Cc: davem, edumazet, kuba, pabeni, horms, atwellwea, daniel.zahka,
	netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 24 Mar 2026 22:08:56 +0800 you wrote:
> __skb_ext_put() is not declared if SKB_EXTENSIONS is not enabled, which
> causes a build error:
> 
> drivers/net/netdevsim/netdev.c: In function 'nsim_forward_skb':
> drivers/net/netdevsim/netdev.c:114:25: error: implicit declaration of function '__skb_ext_put'; did you mean 'skb_ext_put'? [-Werror=implicit-function-declaration]
>   114 |                         __skb_ext_put(psp_ext);
>       |                         ^~~~~~~~~~~~~
>       |                         skb_ext_put
> cc1: some warnings being treated as errors
> 
> [...]

Here is the summary with links:
  - [net] netdevsim: fix build if SKB_EXTENSIONS=n
    https://git.kernel.org/netdev/net/c/57a04a13aac1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-27  3:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-24 14:08 [PATCH net] netdevsim: fix build if SKB_EXTENSIONS=n Qingfang Deng
2026-03-27  3:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox