public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: luka.gejak@linux.dev
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org
Cc: horms@kernel.org, fmaurer@redhat.com, liuhangbin@gmail.com,
	linux-kernel@vger.kernel.org, Luka Gejak <luka.gejak@linux.dev>
Subject: [PATCH net-next v1 2/7] net: hsr: replace fallthrough comments with fallthrough macro
Date: Tue, 24 Mar 2026 15:46:25 +0100	[thread overview]
Message-ID: <20260324144630.189094-3-luka.gejak@linux.dev> (raw)
In-Reply-To: <20260324144630.189094-1-luka.gejak@linux.dev>

From: Luka Gejak <luka.gejak@linux.dev>

Replace two instances of the legacy '/* Fall through */' comment with the
standardized 'fallthrough;' macro in hsr_get_node_status() and
hsr_get_node_list(). The kernel has standardized on the fallthrough macro
since the migration from comment-based annotations, which provides
compiler-level verification of intentional case fall-throughs.

Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
---
 net/hsr/hsr_netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c
index db0b0af7a692..32c1b77cf84b 100644
--- a/net/hsr/hsr_netlink.c
+++ b/net/hsr/hsr_netlink.c
@@ -433,7 +433,7 @@ static int hsr_get_node_status(struct sk_buff *skb_in, struct genl_info *info)
 
 nla_put_failure:
 	kfree_skb(skb_out);
-	/* Fall through */
+	fallthrough;
 
 fail:
 	rcu_read_unlock();
@@ -524,7 +524,7 @@ static int hsr_get_node_list(struct sk_buff *skb_in, struct genl_info *info)
 
 nla_put_failure:
 	nlmsg_free(skb_out);
-	/* Fall through */
+	fallthrough;
 
 fail:
 	rcu_read_unlock();
-- 
2.53.0


  parent reply	other threads:[~2026-03-24 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 14:46 [PATCH net-next v1 0/7] net: hsr: subsystem cleanups and modernization luka.gejak
2026-03-24 14:46 ` [PATCH net-next v1 1/7] net: hsr: constify hsr_ops and prp_ops protocol operation structures luka.gejak
2026-03-24 14:46 ` luka.gejak [this message]
2026-03-26 13:34   ` [PATCH net-next v1 2/7] net: hsr: replace fallthrough comments with fallthrough macro kernel test robot
2026-03-26 16:25   ` Felix Maurer
2026-03-26 21:31   ` kernel test robot
2026-03-26 22:16   ` kernel test robot
2026-03-24 14:46 ` [PATCH net-next v1 3/7] net: hsr: remove unnecessary void function return statement luka.gejak
2026-03-24 14:46 ` [PATCH net-next v1 4/7] net: hsr: use __func__ instead of hardcoded function name luka.gejak
2026-03-24 14:46 ` [PATCH net-next v1 5/7] net: hsr: remove unnecessary braces for single statement block luka.gejak
2026-03-24 14:46 ` [PATCH net-next v1 6/7] net: hsr: add missing blank lines after function declarations luka.gejak
2026-03-24 14:46 ` [PATCH net-next v1 7/7] net: hsr: use BIT() macro for bit shift constant luka.gejak
2026-03-26 16:26   ` Felix Maurer
2026-03-26 16:25 ` [PATCH net-next v1 0/7] net: hsr: subsystem cleanups and modernization Felix Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260324144630.189094-3-luka.gejak@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmaurer@redhat.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox