From: Jakub Ramaseuski <jramaseu@redhat.com>
To: mkubecek@suse.cz
Cc: netdev@vger.kernel.org, Jakub Ramaseuski <jramaseu@redhat.com>
Subject: [PATCH] sfpid: fix redundant print of Active Cu cmplnce.
Date: Tue, 24 Mar 2026 17:12:27 +0100 [thread overview]
Message-ID: <20260324161227.693666-1-jramaseu@redhat.com> (raw)
When ethtool -m is run on a module with an SFP active optical cable,
a redundant printf statement is being called before
the sff_print_any_hex_field is executed, causing multiple
"Active Cu cmplnce." labels to be printed to stdout.
Remove the excess printf statement from the
sff8079_show_wavelength_or_copper_compliance function.
Signed-off-by: Jakub Ramaseuski <jramaseu@redhat.com>
---
sfpid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sfpid.c b/sfpid.c
index 9d09256..228b3ee 100644
--- a/sfpid.c
+++ b/sfpid.c
@@ -362,7 +362,6 @@ static void sff8079_show_wavelength_or_copper_compliance(const __u8 *id)
"passive_cu_cmplnce.",
id[60], description);
} else if (id[8] & (1 << 3)) {
- printf("\t%-41s : 0x%02x", "Active Cu cmplnce.", id[60]);
switch (id[60]) {
case 0x00:
strncpy(description, "unspecified",
--
2.51.0
reply other threads:[~2026-03-24 16:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324161227.693666-1-jramaseu@redhat.com \
--to=jramaseu@redhat.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox