public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sfpid: fix redundant print of Active Cu cmplnce.
@ 2026-03-24 16:12 Jakub Ramaseuski
  0 siblings, 0 replies; only message in thread
From: Jakub Ramaseuski @ 2026-03-24 16:12 UTC (permalink / raw)
  To: mkubecek; +Cc: netdev, Jakub Ramaseuski

When ethtool -m is run on a module with an SFP active optical cable,
a redundant printf statement is being called before 
the sff_print_any_hex_field is executed, causing multiple 
"Active Cu cmplnce." labels to be printed to stdout.

Remove the excess printf statement from the
sff8079_show_wavelength_or_copper_compliance function.

Signed-off-by: Jakub Ramaseuski <jramaseu@redhat.com>
---
 sfpid.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sfpid.c b/sfpid.c
index 9d09256..228b3ee 100644
--- a/sfpid.c
+++ b/sfpid.c
@@ -362,7 +362,6 @@ static void sff8079_show_wavelength_or_copper_compliance(const __u8 *id)
 					"passive_cu_cmplnce.",
 					id[60], description);
 	} else if (id[8] & (1 << 3)) {
-		printf("\t%-41s : 0x%02x", "Active Cu cmplnce.", id[60]);
 		switch (id[60]) {
 		case 0x00:
 			strncpy(description, "unspecified",
-- 
2.51.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-03-24 16:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-24 16:12 [PATCH] sfpid: fix redundant print of Active Cu cmplnce Jakub Ramaseuski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox